Re: Refactoring patches

2020-10-15 Thread Yuriy Skalko
> All these look good to me, so please go on. Pavel Committed all. P.S. Sorry, committed also my local patches. Reverted them immediately. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Refactoring patches

2020-10-15 Thread Pavel Sanda
On Thu, Oct 15, 2020 at 10:56:29PM +0300, Yuriy Skalko wrote: > Here is an update with include cleanup in headers. All these look good to me, so please go on. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Refactoring patches

2020-10-15 Thread Pavel Sanda
On Thu, Oct 15, 2020 at 07:57:50PM +0300, Yuriy Skalko wrote: > > 1, 2, 9 are good to go. > > Committed these. > > > For 8 I do not understand the +#include "insets/Inset.h" part yet. > > Since CutAndPaste.h depends on Inset. It was included from Clipboard.h, > that includes it from Cursor.h, th

Re: Refactoring patches

2020-10-15 Thread Yuriy Skalko
Here is an update with include cleanup in headers. Yuriy From 677ae51c11b1441cc4e1cb616d5fef42c691 Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Thu, 15 Oct 2020 21:09:21 +0300 Subject: [PATCH 1/3] Move Cursor.h from TocWidget.h --- src/frontends/qt/TocWidget.cpp | 1 + src/frontends/q

Re: Refactoring patches

2020-10-15 Thread Yuriy Skalko
> 1, 2, 9 are good to go. Committed these. > For 8 I do not understand the +#include "insets/Inset.h" part yet. Since CutAndPaste.h depends on Inset. It was included from Clipboard.h, that includes it from Cursor.h, that includes it from DocIterator.h, that includes it from CursorSlice.h that in

Re: Refactoring patches

2020-10-15 Thread Pavel Sanda
On Thu, Oct 15, 2020 at 10:14:50AM +0300, Yuriy Skalko wrote: > > Agreed. Unfortunately I suspect that we can achive this only by manually > > going through the suspects proposed by some tools instead of just > > taking their results. > > Here are manual cleaning of some headers is separate patche

Re: Refactoring patches

2020-10-15 Thread Yuriy Skalko
> Agreed. Unfortunately I suspect that we can achive this only by manually > going through the suspects proposed by some tools instead of just > taking their results. Here are manual cleaning of some headers is separate patches. But I don't think I'll be able to process all the headers. >> And no