Re: Manage counters

2020-10-12 Thread Daniel
On 2020-10-13 00:24, Richard Kimberly Heck wrote: On 10/12/20 4:58 AM, Daniel wrote: I have just played a bit with Edit > Manage Counter Values. It's a nice feature to have available. However, it was not what I expected at first. It seems to be "just" a counter inset which sets the counter at th

Re: New inset for \nopagebreak

2020-10-12 Thread Richard Kimberly Heck
On 10/10/20 6:24 PM, Pavel Sanda wrote: > On Fri, Oct 09, 2020 at 06:12:01PM -0400, Richard Kimberly Heck wrote: >> On 10/9/20 5:34 PM, Pavel Sanda wrote: >>> On Thu, Oct 08, 2020 at 09:57:00PM -0400, Richard Kimberly Heck wrote: > Implementation-wise it could be just variant of page-break inse

Re: support/filetools.cpp: why the double colon in the warning message when binary invocation fails?

2020-10-12 Thread Thibaut Cuvelier
On Tue, 13 Oct 2020 at 00:11, Richard Kimberly Heck wrote: > On 10/12/20 5:33 PM, Thibaut Cuvelier wrote: > > Dear list, > > When running LyX on Windows, it first tries to use py -3 and py -2 to > determine the version of the available version of Python. However, on my > machine, none of these is

Re: Manage counters

2020-10-12 Thread Richard Kimberly Heck
On 10/12/20 4:58 AM, Daniel wrote: > I have just played a bit with Edit > Manage Counter Values. It's a > nice feature to have available. However, it was not what I expected at > first. It seems to be "just" a counter inset which sets the counter at > the place where it is inserted (which becomes c

Re: support/filetools.cpp: why the double colon in the warning message when binary invocation fails?

2020-10-12 Thread Richard Kimberly Heck
On 10/12/20 5:33 PM, Thibaut Cuvelier wrote: > Dear list, > > When running LyX on Windows, it first tries to use py -3 and py -2 to > determine the version of the available version of Python. However, on > my machine, none of these is available, so that I get warning messages: > > D:\LyX\lyx-unstab

support/filetools.cpp: why the double colon in the warning message when binary invocation fails?

2020-10-12 Thread Thibaut Cuvelier
Dear list, When running LyX on Windows, it first tries to use py -3 and py -2 to determine the version of the available version of Python. However, on my machine, none of these is available, so that I get warning messages: D:\LyX\lyx-unstable\cmake-build-debug\bin\LyX.exe RunCommand:: could not t

Re: Refactoring patches

2020-10-12 Thread Pavel Sanda
On Mon, Oct 12, 2020 at 11:38:33PM +0300, Yuriy Skalko wrote: > > I propose to apply only changes to headers for now. I will > > try to revive my old scripts which will try to remove unnecessary > > includes in headers first. Only then we look on .cpp files. > > So, if I remove include changing in

Re: Refactoring patches

2020-10-12 Thread Yuriy Skalko
> I propose to apply only changes to headers for now. I will > try to revive my old scripts which will try to remove unnecessary > includes in headers first. Only then we look on .cpp files. So, if I remove include changing in .cpp from patch, then it can be committed for now? Yuriy -- lyx-devel

Re: Refactoring patches

2020-10-12 Thread Pavel Sanda
On Mon, Oct 12, 2020 at 10:36:36PM +0300, Yuriy Skalko wrote: > > Getting rid of unnecessary includes is a valuable goal. > > There are two things to keep in mind: > > - One should try to get rid of redundant includes from headers first, only > > after that reducing .cpp files (otherwise the check

Re: Refactoring patches

2020-10-12 Thread Yuriy Skalko
> Getting rid of unnecessary includes is a valuable goal. > There are two things to keep in mind: > - One should try to get rid of redundant includes from headers first, only > after that reducing .cpp files (otherwise the check of .h files becomes more > tricky). > - some generic headers were in

Re: Refactoring patches

2020-10-12 Thread Pavel Sanda
On Mon, Oct 12, 2020 at 05:26:03PM +0200, Jean-Marc Lasgouttes wrote: > Le 12/10/2020 ?? 15:51, Pavel Sanda a écrit : > >Getting rid of unnecessary includes is a valuable goal. > >There are two things to keep in mind: > >- One should try to get rid of redundant includes from headers first, only >

Re: Refactoring patches

2020-10-12 Thread Jean-Marc Lasgouttes
Le 12/10/2020 à 15:51, Pavel Sanda a écrit : Getting rid of unnecessary includes is a valuable goal. There are two things to keep in mind: - One should try to get rid of redundant includes from headers first, only after that reducing .cpp files (otherwise the check of .h files becomes more tric

Re: Refactoring patches

2020-10-12 Thread Jean-Marc Lasgouttes
Le 12/10/2020 à 15:51, Pavel Sanda a écrit : On Mon, Oct 12, 2020 at 03:33:45PM +0300, Yuriy Skalko wrote: The 1-3 patches look fine. They are in now. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Refactoring patches

2020-10-12 Thread Pavel Sanda
On Mon, Oct 12, 2020 at 03:33:45PM +0300, Yuriy Skalko wrote: The 1-3 patches look fine. > From 7081d5c9f2e441fdce68d672fd07da6f1c121bfc Mon Sep 17 00:00:00 2001 > From: Yuriy Skalko > Date: Mon, 12 Oct 2020 15:30:07 +0300 > Subject: [PATCH 4/4] Remove unused forward declarations and header incl

Refactoring patches

2020-10-12 Thread Yuriy Skalko
I've continued with refactoring of LyX codebase. Here are my new patches. Yuriy From 942ddea047c807b1f0fed82f089847be6543ddaa Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Fri, 9 Oct 2020 18:50:24 +0300 Subject: [PATCH 1/4] Constify --- src/Counters.cpp| 2 +- src/Counters.

Re: warning: unknown warning option '-Wno-deprecated-copy'

2020-10-12 Thread Daniel
On 2020-10-12 11:11, Jean-Marc Lasgouttes wrote: Le 12/10/2020 à 11:06, Daniel a écrit : In case I have managed to correctly revert a change (first time), it did not make any difference to the warning. I am not sure which change triggered it then. Or maybe I need to update/change something else

Re: warning: unknown warning option '-Wno-deprecated-copy'

2020-10-12 Thread Jean-Marc Lasgouttes
Le 12/10/2020 à 11:06, Daniel a écrit : In case I have managed to correctly revert a change (first time), it did not make any difference to the warning. I am not sure which change triggered it then. Or maybe I need to update/change something else for it to take effect? Did you run ./autogen.s

Re: warning: unknown warning option '-Wno-deprecated-copy'

2020-10-12 Thread Daniel
On 2020-10-09 12:18, Jean-Marc Lasgouttes wrote: [reply on lyx-devel, since this is not something I 100% understand] Le 08/10/2020 à 09:32, racoon a écrit : I am getting lots of warning: unknown warning option '-Wno-deprecated-copy'; did you mean '-Wno-deprecated'?    [-Wunknown-warning-op

Manage counters

2020-10-12 Thread Daniel
I have just played a bit with Edit > Manage Counter Values. It's a nice feature to have available. However, it was not what I expected at first. It seems to be "just" a counter inset which sets the counter at the place where it is inserted (which becomes clear when looking at the code). I think