Re: [LyX/master] Mark labels in non-outputting insets as inactive.

2020-10-03 Thread Scott Kostyshak
On Sat, Oct 03, 2020 at 08:56:48AM +0200, Jürgen Spitzmüller wrote: > Am Samstag, den 03.10.2020, 08:18 +0200 schrieb Jürgen Spitzmüller: > > > > We can probably omit the mark if the ref is in the same non- > > > > outputting > > > > context (or generally if it is in a non-outputting context > > it

Re: [LyX/master] Mark labels in non-outputting insets as inactive.

2020-10-03 Thread Scott Kostyshak
On Sat, Oct 03, 2020 at 08:18:06AM +0200, Jürgen Spitzmüller wrote: > Am Freitag, den 02.10.2020, 16:09 -0400 schrieb Scott Kostyshak: > > On Fri, Oct 02, 2020 at 08:35:16AM +0200, Jürgen Spitzmüller wrote: > > > Am Donnerstag, den 01.10.2020, 17:21 -0400 schrieb Scott Kostyshak: > > > > Starting w

Re: [PATCH] Add override specifier

2020-10-03 Thread Yuriy Skalko
> And now clang++ 10 complains a lot... > > JMarc This should fix it. I assume there will be more places... Yuriy From dd855c31bcb983ab533d1002ab7515b74ab4b290 Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Sat, 3 Oct 2020 15:42:14 +0300 Subject: [PATCH] Amend efc0877f --- src/frontends/qt

Re: [PATCH] Add override specifier

2020-10-03 Thread Jean-Marc Lasgouttes
Le 03/10/2020 à 13:19, Jean-Marc Lasgouttes a écrit : Le 02/10/2020 à 19:53, Yuriy Skalko a écrit : Here is an updated patch. Yes, there are more places to add the `override`. I'll try to change the rest on the second step. Is it OK to commit the patch in its current state? Thanks a lot. It

Re: [PATCH] Refactoring based on cppcheck suggestions

2020-10-03 Thread Jean-Marc Lasgouttes
Le 02/10/2020 à 20:05, Yuriy Skalko a écrit : I've done some refactorings based on suggestions from cppcheck analyzer. Thanks, it is in. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [PATCH] Add override specifier

2020-10-03 Thread Jean-Marc Lasgouttes
Le 02/10/2020 à 19:53, Yuriy Skalko a écrit : Here is an updated patch. Yes, there are more places to add the `override`. I'll try to change the rest on the second step. Is it OK to commit the patch in its current state? Thanks a lot. It is in now. JMarc -- lyx-devel mailing list lyx-devel@li