Re: [LyX/master] Mark labels in non-outputting insets as inactive.

2020-10-01 Thread Jürgen Spitzmüller
Am Donnerstag, den 01.10.2020, 17:21 -0400 schrieb Scott Kostyshak: > Starting with this commit, if a deactivated branch has a reference to > a label that's in the same branch, > the reference is marked as "BROKEN". See attached. Actually, the ref _is_ "Broken" as the target label is in a non- out

Re: tex2lyx assertion on master

2020-10-01 Thread Jürgen Spitzmüller
Am Donnerstag, den 01.10.2020, 22:42 +0200 schrieb Enrico Forestieri: > It is not this specific chunk of code. The assertion triggers even > when pasting a single word as LaTeX. Bisect leads to the following > commit: > > commit 0b7305024a33e6616ef3ae73a0df63c5a62e3d10 > > Author: Juergen Spitzmu

Re: Possible regression regarding repainting jump

2020-10-01 Thread Scott Kostyshak
On Thu, Oct 01, 2020 at 06:11:49PM +0200, Jean-Marc Lasgouttes wrote: > Le 08/09/2020 à 14:32, Jean-Marc Lasgouttes a écrit : > > Le 07/09/2020 à 19:09, Scott Kostyshak a écrit : > > > Thanks for confirming. Do you think it could be cc349fd0? If you don't > > > think so, let me know and I can do a

Re: Cursor height regression (wrt 2.2.0)

2020-10-01 Thread Scott Kostyshak
On Thu, Oct 01, 2020 at 04:33:40PM +0200, Jean-Marc Lasgouttes wrote: > Le 01/10/2020 à 16:24, Scott Kostyshak a écrit : > > On Thu, Oct 01, 2020 at 02:23:35PM +0200, Jean-Marc Lasgouttes wrote: > > > Le 01/10/2020 à 13:19, Kornel Benko a écrit : > > > > This works, but now next effect > > > > > >

Re: [LyX/master] Fix #11520 Wrong inpute encoding when master and child use different setting.

2020-10-01 Thread Scott Kostyshak
On Mon, Mar 18, 2019 at 06:13:40PM +0100, Günter Milde wrote: > commit 553bebc3550f932ca3c25bbd4ae3905b60026b3c > Author: Günter Milde > Date: Mon Mar 18 18:16:40 2019 +0100 > > Fix #11520 Wrong inpute encoding when master and child use different > setting. > --- Should 11520 be marked as

Re: [LyX/master] Mark labels in non-outputting insets as inactive.

2020-10-01 Thread Scott Kostyshak
On Mon, Dec 31, 2018 at 06:32:10PM +0100, Juergen Spitzmueller wrote: > commit 1db5abbfbd38c8a709eefe63aea65e1297b7725e > Author: Juergen Spitzmueller > Date: Mon Dec 31 18:32:38 2018 +0100 > > Mark labels in non-outputting insets as inactive. > > Fixes: #11437 > --- Starting with

Re: tex2lyx assertion on master

2020-10-01 Thread Scott Kostyshak
On Thu, Oct 01, 2020 at 10:42:02PM +0200, Enrico Forestieri wrote: > On Wed, Sep 30, 2020 at 09:39:23PM -0400, Scott Kostyshak wrote: > > The following chunk causes a tex2lyx assertion on current master, if I > > paste as LaTeX (or if I save it to a file and import). > > > > % excerpt from here: >

Re: tex2lyx assertion on master

2020-10-01 Thread Enrico Forestieri
On Wed, Sep 30, 2020 at 09:39:23PM -0400, Scott Kostyshak wrote: > The following chunk causes a tex2lyx assertion on current master, if I > paste as LaTeX (or if I save it to a file and import). > > % excerpt from here: > % https://tex.stackexchange.com/a/280891/12212 > \author[Short Name (U ABC)]

[PATCH] Add override specifier

2020-10-01 Thread Yuriy Skalko
Hello, I've added `override` specifiers into the LyX codebase. This will improve code maintainability in future. To find overridden methods I've used the Cppcheck static analyzer. Probably some are missed and should be marked later. Jean-Marc already marked some of such methods in commit c8f4b684

Re: Possible regression regarding repainting jump

2020-10-01 Thread Jean-Marc Lasgouttes
Le 08/09/2020 à 14:32, Jean-Marc Lasgouttes a écrit : Le 07/09/2020 à 19:09, Scott Kostyshak a écrit : Thanks for confirming. Do you think it could be cc349fd0? If you don't think so, let me know and I can do a bisect. I checked, and it is this one indeed. Weird. Actually, it is not this one

Re: Cursor height regression (wrt 2.2.0)

2020-10-01 Thread Scott Kostyshak
On Thu, Oct 01, 2020 at 04:33:40PM +0200, Jean-Marc Lasgouttes wrote: > Le 01/10/2020 à 16:24, Scott Kostyshak a écrit : > > On Thu, Oct 01, 2020 at 02:23:35PM +0200, Jean-Marc Lasgouttes wrote: > > > Le 01/10/2020 à 13:19, Kornel Benko a écrit : > > > > This works, but now next effect > > > > > >

Re: [RFC] Make caret width scalable wrt current font, not zoom.

2020-10-01 Thread Scott Kostyshak
On Thu, Oct 01, 2020 at 02:30:13PM +0200, Jean-Marc Lasgouttes wrote: > Hi there, > > This is an experiment to see what people think about it. The idea is > > 1/ make cursor width scalable by default I like this idea. > 2/ instead of setting a width that depends on zoom, choose one that depends

Re: Cursor height regression (wrt 2.2.0)

2020-10-01 Thread Jean-Marc Lasgouttes
Le 01/10/2020 à 16:24, Scott Kostyshak a écrit : On Thu, Oct 01, 2020 at 02:23:35PM +0200, Jean-Marc Lasgouttes wrote: Le 01/10/2020 à 13:19, Kornel Benko a écrit : This works, but now next effect Type any text (default size) Backspace select giant size type more than on char The first type is

Re: Cursor height regression (wrt 2.2.0)

2020-10-01 Thread Scott Kostyshak
On Thu, Oct 01, 2020 at 02:23:35PM +0200, Jean-Marc Lasgouttes wrote: > Le 01/10/2020 à 13:19, Kornel Benko a écrit : > > This works, but now next effect > > > > Type any text (default size) > > Backspace > > select giant size > > type more than on char > > The first type is OK, but next ones are

Re: Cursor height regression (wrt 2.2.0)

2020-10-01 Thread Kornel Benko
Am Thu, 1 Oct 2020 15:58:50 +0200 schrieb Jean-Marc Lasgouttes : > Le 01/10/2020 à 15:43, Kornel Benko a écrit : > > Am Thu, 1 Oct 2020 15:22:42 +0200 > > schrieb Jean-Marc Lasgouttes : > > I thought that moving the cursor e.g. forward from position x to position > > x+1, we can > > get the info

Re: Cursor height regression (wrt 2.2.0)

2020-10-01 Thread Jean-Marc Lasgouttes
Le 01/10/2020 à 15:43, Kornel Benko a écrit : Am Thu, 1 Oct 2020 15:22:42 +0200 schrieb Jean-Marc Lasgouttes : I thought that moving the cursor e.g. forward from position x to position x+1, we can get the info of char at position x. Same if moving from pos x+1 to x, we can get the info (of pos

Re: Cursor height regression (wrt 2.2.0)

2020-10-01 Thread Kornel Benko
Am Thu, 1 Oct 2020 15:22:42 +0200 schrieb Jean-Marc Lasgouttes : > Le 01/10/2020 à 15:02, Kornel Benko a écrit : > > What I would like: > > > > If moving cursor from right to left, I'd like the size to be of the char to > > the right. > > If moving cursor from left to right, it should have the s

Re: Cursor height regression (wrt 2.2.0)

2020-10-01 Thread Jean-Marc Lasgouttes
Le 01/10/2020 à 15:02, Kornel Benko a écrit : What I would like: If moving cursor from right to left, I'd like the size to be of the char to the right. If moving cursor from left to right, it should have the size of char to the left. This should be independent of LTR or RTL. Does this sound r

Re: Cursor height regression (wrt 2.2.0)

2020-10-01 Thread Kornel Benko
Am Thu, 1 Oct 2020 14:56:42 +0200 schrieb Kornel Benko : > Am Thu, 1 Oct 2020 14:23:35 +0200 > schrieb Jean-Marc Lasgouttes : > > > Le 01/10/2020 à 13:19, Kornel Benko a écrit : > > > This works, but now next effect > > > > > > Type any text (default size) > > > Backspace > > > select giant si

Re: Cursor height regression (wrt 2.2.0)

2020-10-01 Thread Kornel Benko
Am Thu, 1 Oct 2020 14:23:35 +0200 schrieb Jean-Marc Lasgouttes : > Le 01/10/2020 à 13:19, Kornel Benko a écrit : > > This works, but now next effect > > > > Type any text (default size) > > Backspace > > select giant size > > type more than on char > > The first type is OK, but next ones are smal

[RFC] Make caret width scalable wrt current font, not zoom.

2020-10-01 Thread Jean-Marc Lasgouttes
Hi there, This is an experiment to see what people think about it. The idea is 1/ make cursor width scalable by default 2/ instead of setting a width that depends on zoom, choose one that depends on current font line width (like the height depends on font height). What I still do not like is

Re: Cursor height regression (wrt 2.2.0)

2020-10-01 Thread Jean-Marc Lasgouttes
Le 01/10/2020 à 13:19, Kornel Benko a écrit : This works, but now next effect Type any text (default size) Backspace select giant size type more than on char The first type is OK, but next ones are small again Typing at the end of paragraph works. Typing anything in the mid of word has the same

Re: Cursor height regression (wrt 2.2.0)

2020-10-01 Thread Kornel Benko
Am Thu, 1 Oct 2020 12:47:27 +0200 schrieb Jean-Marc Lasgouttes : > Le 27/09/2020 à 20:26, Scott Kostyshak a écrit : > > steps to reproduce: > > > > 1. Open the attached .lyx file. > > 2. Select all. > > 3. Delete. > > > > Cursor is shorter than expected. If you do > > > > 4. Type "a". > > 5. Ba

Re: Cursor height regression (wrt 2.2.0)

2020-10-01 Thread Jean-Marc Lasgouttes
Le 27/09/2020 à 20:26, Scott Kostyshak a écrit : steps to reproduce: 1. Open the attached .lyx file. 2. Select all. 3. Delete. Cursor is shorter than expected. If you do 4. Type "a". 5. Backspace. Now the cursor is back to expected height. Better now? I am uneasy with this, since there are