Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

2020-03-05 Thread Scott Kostyshak
Fix deprecation warnings from use of qSort() in master at 14f369b4. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

2020-03-05 Thread Scott Kostyshak
On Tue, Mar 03, 2020 at 02:24:39PM -0500, Scott Kostyshak wrote: > On Fri, Feb 28, 2020 at 02:35:18PM -0500, Scott Kostyshak wrote: > > Compiling LyX with Qt 5.14.1 gives deprecation warnings, which breaks > > compilation of LyX with -Werror. I'm working on a patch to address > > these. I'm sending

Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

2020-03-05 Thread Scott Kostyshak
On Thu, Mar 05, 2020 at 12:00:32PM +0100, Pavel Sanda wrote: > On Tue, Mar 03, 2020 at 08:40:38PM -0500, Scott Kostyshak wrote: > > When you dereference an iterator, isn't it usually expected to return the > > object, not a pointer to the object? > > It might be we don't use that in lyx codebase,

Re: Currently working on a patch to address deprecations that trigger -Werror with Qt 5.14.1

2020-03-05 Thread Pavel Sanda
On Tue, Mar 03, 2020 at 08:40:38PM -0500, Scott Kostyshak wrote: > When you dereference an iterator, isn't it usually expected to return the > object, not a pointer to the object? It might be we don't use that in lyx codebase, but I don't have any particular expectations for the underlying type.