Re: [REGRESSION] Temporary Directory Ignored

2020-02-17 Thread Stephan Witt
Am 18.02.2020 um 04:38 schrieb Richard Kimberly Heck : > > On 2/16/20 1:01 PM, Enrico Forestieri wrote: >> On Sun, Feb 16, 2020 at 07:01:04AM -0500, Richard Kimberly Heck wrote: >>> On 2/16/20 5:59 AM, Enrico Forestieri wrote: On Sun, Feb 16, 2020 at 01:47:43AM +0100, Stephan Witt wrote:

Re: [RFC][PATCH] Next results from code analyzer - suspicious variable usage

2020-02-17 Thread Jürgen Spitzmüller
Am Montag, den 17.02.2020, 22:56 +0100 schrieb Pavel Sanda: > > Any comments or ok to apply? > > The first snippet looks fine, the second is technically correct but > it might > signalize that author (Juergen?) might have different logic in mind > and there > is some thinko in the code. I think t

Re: [REGRESSION] Temporary Directory Ignored

2020-02-17 Thread Richard Kimberly Heck
On 2/16/20 1:01 PM, Enrico Forestieri wrote: > On Sun, Feb 16, 2020 at 07:01:04AM -0500, Richard Kimberly Heck wrote: >> On 2/16/20 5:59 AM, Enrico Forestieri wrote: >>> On Sun, Feb 16, 2020 at 01:47:43AM +0100, Stephan Witt wrote: Am 16.02.2020 um 01:25 schrieb Enrico Forestieri : >

Re: [RFC][PATCH] Next results from code analyzer - suspicious variable usage

2020-02-17 Thread Pavel Sanda
On Mon, Feb 17, 2020 at 04:35:05PM +0100, Stephan Witt wrote: > Any comments or ok to apply? The first snippet looks fine, the second is technically correct but it might signalize that author (Juergen?) might have different logic in mind and there is some thinko in the code. Pavel -- lyx-devel ma

Re: Valgrind "definitely lost" backtrace

2020-02-17 Thread Richard Kimberly Heck
On 2/17/20 2:08 PM, Scott Kostyshak wrote: > On Mon, Feb 17, 2020 at 12:35:19PM -0500, Richard Kimberly Heck wrote: >> On 2/17/20 8:17 AM, Pavel Sanda wrote: >>> On Sun, Feb 16, 2020 at 07:21:17PM -0500, Scott Kostyshak wrote: On Sat, Feb 15, 2020 at 09:42:52PM +0100, Pavel Sanda wrote: >

Re: Valgrind "definitely lost" backtrace

2020-02-17 Thread Scott Kostyshak
On Mon, Feb 17, 2020 at 12:35:19PM -0500, Richard Kimberly Heck wrote: > On 2/17/20 8:17 AM, Pavel Sanda wrote: > > On Sun, Feb 16, 2020 at 07:21:17PM -0500, Scott Kostyshak wrote: > >> On Sat, Feb 15, 2020 at 09:42:52PM +0100, Pavel Sanda wrote: > >>> On Fri, Feb 14, 2020 at 08:09:09PM -0500, Scot

LyX 2.3.4.3 for Windows

2020-02-17 Thread Richard Kimberly Heck
Public release of LyX version 2.3.4-3 = This is another emergency release that, hopefully, actually fixes the first bug that 2.3.4-2 was meant to fix: A delay when saving files on Windows. The new bug is #11737. There are no other changes. Only Windows users wi

Re: [RFC][PATCH] Change to GuiView::goToFileRow

2020-02-17 Thread Richard Kimberly Heck
On 2/17/20 11:14 AM, Stephan Witt wrote: > Am 17.02.2020 um 11:00 schrieb Enrico Forestieri : >> On Mon, Feb 17, 2020 at 08:28:20AM +0100, Stephan Witt wrote: >>> Am 16.02.2020 um 22:02 schrieb Enrico Forestieri : On Sun, Feb 16, 2020 at 09:28:57PM +0100, Stephan Witt wrote: > Am 16.02.202

Re: [RFC][PATCH] Next results from code analyzer - null pointers

2020-02-17 Thread Richard Kimberly Heck
On 2/17/20 9:28 AM, Stephan Witt wrote: > Hi all, > > this is the next step in evaluating the code analyzing results. > > There are some potential null pointer problems found. > > Because I’m not able to preclude unwanted or side effects I present > two patches here. Any comments or ok to apply? in

Re: Valgrind "definitely lost" backtrace

2020-02-17 Thread Richard Kimberly Heck
On 2/17/20 8:17 AM, Pavel Sanda wrote: > On Sun, Feb 16, 2020 at 07:21:17PM -0500, Scott Kostyshak wrote: >> On Sat, Feb 15, 2020 at 09:42:52PM +0100, Pavel Sanda wrote: >>> On Fri, Feb 14, 2020 at 08:09:09PM -0500, Scott Kostyshak wrote: Thanks to both of you for taking a look. I was hoping t

Re: [RFC][PATCH] Change to GuiView::goToFileRow

2020-02-17 Thread Stephan Witt
Am 17.02.2020 um 11:00 schrieb Enrico Forestieri : > > On Mon, Feb 17, 2020 at 08:28:20AM +0100, Stephan Witt wrote: >> Am 16.02.2020 um 22:02 schrieb Enrico Forestieri : >>> >>> On Sun, Feb 16, 2020 at 09:28:57PM +0100, Stephan Witt wrote: Am 16.02.2020 um 17:54 schrieb Enrico Forestieri :

Re: [RFC][PATCH] Next results from code analyzer - suspicious variable usage

2020-02-17 Thread Kornel Benko
Am Mon, 17 Feb 2020 16:35:05 +0100 schrieb Stephan Witt : > Hi all, > > this is the next step in evaluating the code analyzing results. > > There are some problems found with useless assignments and one > uninitialized variable. > > Any comments or ok to apply? > > Or is there some flaw in log

[RFC][PATCH] Next results from code analyzer - suspicious variable usage

2020-02-17 Thread Stephan Witt
Hi all, this is the next step in evaluating the code analyzing results. There are some problems found with useless assignments and one uninitialized variable. Any comments or ok to apply? Or is there some flaw in logic and the improvement not straightforward? Stephan suspicious-variable-usa

[RFC][PATCH] Next results from code analyzer - null pointers

2020-02-17 Thread Stephan Witt
Hi all, this is the next step in evaluating the code analyzing results. There are some potential null pointer problems found. Because I’m not able to preclude unwanted or side effects I present two patches here. Any comments or ok to apply? Stephan Converter.patch Description: Binary data

Re: Valgrind "definitely lost" backtrace

2020-02-17 Thread Pavel Sanda
On Sun, Feb 16, 2020 at 07:21:17PM -0500, Scott Kostyshak wrote: > On Sat, Feb 15, 2020 at 09:42:52PM +0100, Pavel Sanda wrote: > > On Fri, Feb 14, 2020 at 08:09:09PM -0500, Scott Kostyshak wrote: > > > Thanks to both of you for taking a look. I was hoping to investigate > > > this memory leak but

Re: [RFC][PATCH] Using "lyx_tmpdir" magic constant

2020-02-17 Thread Stephan Witt
Am 17.02.2020 um 11:29 schrieb Enrico Forestieri : > > On Mon, Feb 17, 2020 at 10:05:01AM +0100, Stephan Witt wrote: >> Hi all, >> >> while trying to understand how temp directory management works >> I’ve stumbled over the „lyx_tmpdir“ string constant use. >> >> 1. This magic name should be code

Re: [RFC][PATCH] Using "lyx_tmpdir" magic constant

2020-02-17 Thread Enrico Forestieri
On Mon, Feb 17, 2020 at 10:05:01AM +0100, Stephan Witt wrote: > Hi all, > > while trying to understand how temp directory management works > I’ve stumbled over the „lyx_tmpdir“ string constant use. > > 1. This magic name should be coded in filetools only. > For this I didn’t prepare a patch. > >

Re: [RFC][PATCH] Change to GuiView::goToFileRow

2020-02-17 Thread Enrico Forestieri
On Mon, Feb 17, 2020 at 08:28:20AM +0100, Stephan Witt wrote: > Am 16.02.2020 um 22:02 schrieb Enrico Forestieri : > > > > On Sun, Feb 16, 2020 at 09:28:57PM +0100, Stephan Witt wrote: > >> Am 16.02.2020 um 17:54 schrieb Enrico Forestieri : > >>> > >>> On Sun, Feb 16, 2020 at 02:52:52PM +0100, St

[RFC][PATCH] Using "lyx_tmpdir" magic constant

2020-02-17 Thread Stephan Witt
Hi all, while trying to understand how temp directory management works I’ve stumbled over the „lyx_tmpdir“ string constant use. 1. This magic name should be coded in filetools only. For this I didn’t prepare a patch. BTW: is the code in lyxSockets() of lyxclient ok? There is a check for "lyx_tmp