Re: Comments on patch for paragraph-move-down to move sub-items as well

2020-02-02 Thread Scott Kostyshak
On Sun, Feb 02, 2020 at 08:36:53PM -0500, Scott Kostyshak wrote: > The logic in RandomAccessList is overly > complicated (and inefficient) and I'm working on simplifying it by using > a splice instead of all of those swaps. The attached patch implements the splice approach. I've tested the patch

Re: Comments on patch for paragraph-move-down to move sub-items as well

2020-02-02 Thread Scott Kostyshak
On Sun, Feb 02, 2020 at 07:08:50PM -0500, Richard Kimberly Heck wrote: > On 2/1/20 12:40 PM, Scott Kostyshak wrote: > > I've been working on a patch for LFUN_PARAGRAPH_MOVE_DOWN move subitems > > of an item along with the item. For example, consider the following > > situation: > > > > 1. One ite

Re: Comments on patch for paragraph-move-down to move sub-items as well

2020-02-02 Thread Richard Kimberly Heck
On 2/1/20 12:40 PM, Scott Kostyshak wrote: > I've been working on a patch for LFUN_PARAGRAPH_MOVE_DOWN move subitems > of an item along with the item. For example, consider the following > situation: > > 1. One item > a. "subitem" > 2. Another item > > Currently (i.e., without the patch),

Re: Comments on patch for paragraph-move-down to move sub-items as well

2020-02-02 Thread Scott Kostyshak
On Sat, Feb 01, 2020 at 08:43:15PM +0100, Jean-Marc Lasgouttes wrote: > Le 01/02/2020 à 18:40, Scott Kostyshak a écrit : > > I've been working on a patch for LFUN_PARAGRAPH_MOVE_DOWN move subitems > > of an item along with the item. For example, consider the following > > situation: > > > >1.

Re: Question on undo: Remove a finishUndo() after a recordUndo() ?

2020-02-02 Thread Scott Kostyshak
On Sat, Feb 01, 2020 at 08:41:12PM +0100, Jean-Marc Lasgouttes wrote: > Le 01/02/2020 à 18:39, Scott Kostyshak a écrit : > > What would the consequences be of the attached patch? > > > > From what I understand, finishUndo() is meant for when there have been > > som undos of type INSERT or DELETE