Re: Bug #11484

2019-03-11 Thread Jürgen Womser-Schütz
Hello Jürgen, I think it is now much better than I could do it without your help. But I am still learning :-) Another thing: In the case of include type "Input" or "Include" only LyX or LaTeX-files are meaningful. I wasn't aware this fact during my tests and so I got conversion errors because I w

Re: Reconfigure does not work for a specific user directory

2019-03-11 Thread Scott Kostyshak
On Mon, Mar 11, 2019 at 09:54:12AM +0100, Jean-Pierre Chrétien wrote: > Le 11/03/2019 à 01:47, Scott Kostyshak a écrit : > > Attached is a user directory. I believe I happened to create it from a > > weird situation. Maybe TeX Live was half-way installed or something like > > that. In any case, LyX

Re: lyx2lyx tests failing on master

2019-03-11 Thread Scott Kostyshak
On Mon, Mar 11, 2019 at 12:11:38PM +0100, Jürgen Spitzmüller wrote: > Am Mo., 11. März 2019 um 11:54 Uhr schrieb Kornel Benko : > > > Thanks, interesting problems (while following your recent commits) :) > > > > Yes, it's a tricky task. But apart from some edge cases, language reversion > should

Re: Bug #11484

2019-03-11 Thread Jürgen Spitzmüller
Am Mo., 11. März 2019 um 08:40 Uhr schrieb Jürgen Spitzmüller > Some more comments: > The attached patch includes my suggestions (incl. the ltrimming of the file name). What do you think, Jürgen? Jürgen (not talking to himself) diff --git a/src/insets/InsetInclude.cpp b/src/insets/InsetInclude

Re: lyx2lyx tests failing on master

2019-03-11 Thread Jürgen Spitzmüller
Am Mo., 11. März 2019 um 11:54 Uhr schrieb Kornel Benko : > Thanks, interesting problems (while following your recent commits) :) > Yes, it's a tricky task. But apart from some edge cases, language reversion should work now (and much better than before). Jürgen

Re: lyx2lyx tests failing on master

2019-03-11 Thread Kornel Benko
Am Montag, 11. März 2019 10:38:58 CET schrieb Jürgen Spitzmüller : > Am Mo., 11. März 2019 um 09:44 Uhr schrieb Kornel Benko : > > > According to the log, the loop is inside > > $ lyx -e lyx22x autotests/export/lyx2lyx/lyx_2_3_test.lyx > > So, trying > > $ lyx2lyx -V 2.2 lyx_2_3_t

Re: lyx2lyx tests failing on master

2019-03-11 Thread Jürgen Spitzmüller
Am Mo., 11. März 2019 um 09:44 Uhr schrieb Kornel Benko : > According to the log, the loop is inside > $ lyx -e lyx22x autotests/export/lyx2lyx/lyx_2_3_test.lyx > So, trying > $ lyx2lyx -V 2.2 lyx_2_3_test.lyx > The loop is fixed now. There are some other things to polish. I'll do

Re: lyx2lyx tests failing on master

2019-03-11 Thread Kornel Benko
Am Montag, 11. März 2019 09:44:25 CET schrieb Kornel Benko : > Am Sonntag, 10. März 2019 19:18:49 CET schrieb Scott Kostyshak > : > > I get the following on current master: > > > > $ ctest --timeout 60 -R "lyx2lyx" > > > > The following tests FAILED: > > 1357 - INVERTED.TODO_export/export/ly

Re: Reconfigure does not work for a specific user directory

2019-03-11 Thread Jean-Pierre Chrétien
Le 11/03/2019 à 01:47, Scott Kostyshak a écrit : Attached is a user directory. I believe I happened to create it from a weird situation. Maybe TeX Live was half-way installed or something like that. In any case, LyX won't compile to PDF with pdflatex when this user directory is used. That's proba

Re: lyx2lyx tests failing on master

2019-03-11 Thread Kornel Benko
Am Sonntag, 10. März 2019 19:18:49 CET schrieb Scott Kostyshak : > I get the following on current master: > > $ ctest --timeout 60 -R "lyx2lyx" > > The following tests FAILED: > 1357 - INVERTED.TODO_export/export/lyx2lyx/lyx_2_3_test_lyx16 (Timeout) > 1358 - INVERTED.TODO_export/expo

Re: Bug #11484

2019-03-11 Thread Jürgen Spitzmüller
Am Mo., 11. März 2019 um 08:40 Uhr schrieb Jürgen Spitzmüller: > BTW I see that the file name is not trimmed (hence " " is not treated as > empty filename); we should probably do that: > > if (trim(params()["filename"]).empty()) > temp += "???"; > It turns out we need to ltrim the file n

Re: Bug #11484

2019-03-11 Thread Jürgen Spitzmüller
Am So., 10. März 2019 um 21:56 Uhr schrieb Jürgen Womser-Schütz < jws1...@gmx.de>: > Jürgen's improvements for "GNU Gettext" are now includet. > I looked into the documentation (chapter "Child Documents" in the > "Embedded Objects" helpfile ): a change seems to me not really necessary. > Maybe it