Re: Behavior of overset inset creation on selection

2018-11-04 Thread Jean-Marc Lasgouttes
Le 04/11/2018 à 11:16, Scott Kostyshak a écrit : I see, sounds tricky. Perhaps we should leave things untouched? Would it be complicated to allow for the multi-cell inset to decide what the behavior is? I'm guessing this would be too complicated and is not the best use of your time, but in case I

Re: Policy for breaking compilation with -Werror

2018-11-04 Thread Jean-Marc Lasgouttes
Le 28/10/2018 à 09:39, Scott Kostyshak a écrit : Dear all, I think that preserving compilation with -Werror can help catch real bugs. Most of the time, warnings are harmless/incorrect, and can even be a pain to address. It's thus debatable whether the bother of fixing harmless/incorrect warnings

Re: Behavior of overset inset creation on selection

2018-11-04 Thread Scott Kostyshak
On Sun, Nov 04, 2018 at 08:42:42AM -1000, Jean-Marc Lasgouttes wrote: > Le 04/11/2018 à 18:38, Scott Kostyshak a écrit : > > > OK, so you would like to put the selection contents to the first cell, but > > > the cursor in the next one. Is that right? > > > > Yes, that is the most natural to me as

Re: Uninitialized variable use in nextKeyIdx LatexInfo::dispatch

2018-11-04 Thread Kornel Benko
Am Sonntag, 4. November 2018 08:03:24 CET schrieb Jean-Marc Lasgouttes : > Le 04/11/2018 à 09:42, Kornel Benko a écrit : > > Am Sonntag, 4. November 2018 10:07:19 CET schrieb Stephan Witt > > : > >> Hi Kornel, > >> > >> Apple clang has spotted a problem probably introduced in change 74c849d651. >

Alignment of section titles in KOMA classes

2018-11-04 Thread Guy Rutenberg
Hi, In the regular document classes, if a document's main language is Hebrew, than alignment in LyX's display of section titles is context-dependent (right if Hebrew, left otherwise). In the Koma classes (for example KOMA-Script article) it does not work that way. I suspect the relevant code is t

Re: Behavior of overset inset creation on selection

2018-11-04 Thread Jean-Marc Lasgouttes
Le 04/11/2018 à 18:38, Scott Kostyshak a écrit : OK, so you would like to put the selection contents to the first cell, but the cursor in the next one. Is that right? Yes, that is the most natural to me as a user. From the technical perspective (in the way you describe), it does appear unintuit

Re: Behavior of overset inset creation on selection

2018-11-04 Thread Scott Kostyshak
On Sun, Nov 04, 2018 at 08:07:51AM -1000, Jean-Marc Lasgouttes wrote: > Le 04/11/2018 à 17:58, Scott Kostyshak a écrit : > > If I do the following steps: > > > > 1. In math mode, type "=". > > 2. Select the "=" you just typed. > > 3. Choose "Overset" from the math toolbar (alternatively, just type

Re: [LyX/master] Comment out unused functions to restore -Werror

2018-11-04 Thread Jean-Marc Lasgouttes
Le 28/10/2018 à 22:30, Kornel Benko a écrit : It is not a global function, it is in an anonymous namespace. Are you sure? lyxfind.cpp:60 namespace lyx { ... lyxfind.cpp:2763 } // namespace lyx Kornel Yes. lyxfind.cpp: namespace { lyxfind.cpp:2619 } // name

Re: Behavior of overset inset creation on selection

2018-11-04 Thread Jean-Marc Lasgouttes
Le 04/11/2018 à 17:58, Scott Kostyshak a écrit : If I do the following steps: 1. In math mode, type "=". 2. Select the "=" you just typed. 3. Choose "Overset" from the math toolbar (alternatively, just type "\overset"). 4. Type "def". OK, so you would like to put the selection contents to the

Re: Uninitialized variable use in nextKeyIdx LatexInfo::dispatch

2018-11-04 Thread Jean-Marc Lasgouttes
Le 04/11/2018 à 09:42, Kornel Benko a écrit : Am Sonntag, 4. November 2018 10:07:19 CET schrieb Stephan Witt : Hi Kornel, Apple clang has spotted a problem probably introduced in change 74c849d651. src/lyxfind.cpp:1672:10: warning: variable 'nextKeyIdx' is used uninitialized whenever sw

FINDADV ready for stresstests

2018-11-04 Thread Kornel Benko
The only drawback I can see is the slowness on large paragraphs ( > 500 chars) which have the requested features set in the search pattern. Please try it out. Kornel signature.asc Description: This is a digitally signed message part.

Debugging question

2018-11-04 Thread Kornel Benko
I am hunting an error, which only shows if I disable the debug output. So, using '-dbg find', there is no error, the findadv routines work OK. Without this, the outcome is surprising. For instance open a file with some text in English and some in another languages. In findadv deselect 'igmore f

Re: Behavior of overset inset creation on selection

2018-11-04 Thread Jean-Marc Lasgouttes
Le 30/10/2018 à 16:39, Scott Kostyshak a écrit : The issue is now fixed in master. I have another feature request: I think the cursor should be put in the newly created box (just like with superscript, for example). Should I make a trac ticket for this enhancement? I am not sure of what you mea

Re: Uninitialized variable use in nextKeyIdx LatexInfo::dispatch

2018-11-04 Thread Kornel Benko
Am Sonntag, 4. November 2018 10:07:19 CET schrieb Stephan Witt : > Hi Kornel, > > Apple clang has spotted a problem probably introduced in change 74c849d651. > > > src/lyxfind.cpp:1672:10: warning: variable 'nextKeyIdx' is used uninitialized > whenever switch case is taken > [-Wsomet

Uninitialized variable use in nextKeyIdx LatexInfo::dispatch

2018-11-04 Thread Stephan Witt
Hi Kornel, Apple clang has spotted a problem probably introduced in change 74c849d651. src/lyxfind.cpp:1672:10: warning: variable 'nextKeyIdx' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized] case KeyInfo::isMain: { ^~~ src/lyxfi