Re: Memory leak with WordList

2016-12-31 Thread Jean-Marc Lasgouttes
Le 31/12/2016 à 15:42, Guillaume Munch a écrit : Snippet of Valgrind output for stable below. The WordList object created in theWordList() never gets deleted, although QThreadStorage is supposed to be automagic. According to the docs, the GlobalWordLists were deleted with the QApplication, tha

Re: LyX 2.2 slowness

2016-12-31 Thread Jean-Marc Lasgouttes
Le 31/12/2016 à 17:34, Kornel Benko a écrit : commit c5119c97fcf84e8dd2cfcdd605cc0a9ffa8b5bc4 Author: Jean-Marc Lasgouttes Date: Tue Jul 5 14:06:22 2016 +0200 Add caching for the QTextLayout objects we use I see. Yes, that was what I have seen, not realizing when it was pushed. Does

Re: LyX 2.2 slowness

2016-12-31 Thread Kornel Benko
Am Samstag, 31. Dezember 2016 um 15:26:47, schrieb Jean-Marc Lasgouttes > Le 31/12/2016 à 15:24, Jean-Marc Lasgouttes a écrit : > > It is this particular patch. I amended it since the initial July 5 > > creattion, but apparently git does not update date by default. > > To be more precise, this i

Re: [LyX features/biblatex2] Fix isDefaultBiblio() test

2016-12-31 Thread Jürgen Spitzmüller
Am Samstag, den 31.12.2016, 15:52 + schrieb José Abílio Matos: > It should be possible now to write this as: > > for(string const &s: default_biblios_) >     if (suffixIs(s, bfs) || bf == s) >     return true; > > Or is there any reason against it? No. Except for my ignorance. Thanks!

Re: [LyX features/biblatex2] Fix isDefaultBiblio() test

2016-12-31 Thread José Abílio Matos
On Saturday, December 31, 2016 4:01:31 PM WET Juergen Spitzmueller wrote: > + vector::const_iterator it = default_biblios_.begin(); > + vector::const_iterator end = default_biblios_.end(); > + for (; it != end; ++it) { > + string const s = *it; > + if

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

2016-12-31 Thread Jean-Marc Lasgouttes
Le 31/12/2016 à 15:48, Guillaume Munch a écrit : Using weak pointers instead of naked pointers could be used to let you know when an inset has been destroyed. The cursor could then check if all slices are valid, and if not then fix itself. This would implement the original intent that the pointer

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

2016-12-31 Thread Guillaume Munch
Le 30/12/2016 à 21:02, Richard Heck a écrit : On 12/30/2016 12:15 PM, Guillaume Munch wrote: Thanks for the patch. It is the same as calling fixIfBroken in GuiView::structureChanged (as attached) which I agree becomes even simpler. But, provided one accepts the idea that DocIterators hold peris

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

2016-12-31 Thread Guillaume Munch
Le 30/12/2016 à 22:48, Jean-Marc Lasgouttes a écrit : At some time where DEPM was causing issues, there was the idea of registering cursors with their buffer. This would allow to keep track of what is happening. Another possibility would be to register insets, so that one can know when cursor.in

Re: Memory leak with WordList

2016-12-31 Thread Guillaume Munch
Le 31/12/2016 à 13:16, Jean-Marc Lasgouttes a écrit : WordList leaks all its contents on exit, which is very impolite (even though the memory will be reclaimed anyway). This hides real memory leaks that may happen elsewhere. Snippet of Valgrind output for stable below. The WordList object create

Re: problems with quotes

2016-12-31 Thread Jean-Marc Lasgouttes
Le 18/12/2016 à 12:21, Jürgen Spitzmüller a écrit : Would you like to have a go? After all, inset-forall is your child ;-) This particular child was born in 2009, and I'd say that in lfun-years, it is very much adult. But in memory of the good old days, I'll try to have a look. JMarc

Re: LyX 2.2 slowness

2016-12-31 Thread Jean-Marc Lasgouttes
Le 31/12/2016 à 15:24, Jean-Marc Lasgouttes a écrit : It is this particular patch. I amended it since the initial July 5 creattion, but apparently git does not update date by default. To be more precise, this is the commit below, pushed on Dec 19. I have prepared a version for stable (for disc

Re: LyX 2.2 slowness

2016-12-31 Thread Jean-Marc Lasgouttes
Le 31/12/2016 à 13:26, Kornel Benko a écrit : Am Samstag, 31. Dezember 2016 um 13:16:41, schrieb Jean-Marc Lasgouttes Le 16/12/2016 à 16:42, Jean-Marc Lasgouttes a écrit : I'd be interested to see other tests, especially on MacOS and Windows. Since there not much testing going on, I pushed

Re: UserGuide.lyx lyx2lyx error "unusual contents found"

2016-12-31 Thread Guenter Milde
On 2016-12-31, Jürgen Spitzmüller wrote: > [-- Type: text/plain, Encoding: quoted-printable --] > Am Samstag, den 31.12.2016, 06:41 -0500 schrieb Scott Kostyshak: >> $ lyx master -e lyx22x UserGuide.lyx >> $ lyx master -e lyx22x UserGuide.22.lyx  >> unusual contents found: [formula simple [grid [

Re: UserGuide.lyx lyx2lyx error "unusual contents found"

2016-12-31 Thread Jürgen Spitzmüller
Am Samstag, den 31.12.2016, 06:41 -0500 schrieb Scott Kostyshak: > $ lyx master -e lyx22x UserGuide.lyx > $ lyx master -e lyx22x UserGuide.22.lyx  > unusual contents found: [formula simple [grid [row [cell [symbol > langle][kern -2.5pt][symbol langle] [formula simple [grid [row > [cell   >

Re: LyX 2.2 slowness

2016-12-31 Thread Kornel Benko
Am Samstag, 31. Dezember 2016 um 13:16:41, schrieb Jean-Marc Lasgouttes > Le 16/12/2016 à 16:42, Jean-Marc Lasgouttes a écrit : > > I'd be interested to see other tests, especially on MacOS and Windows. > > Since there not much testing going on, I pushed the patch to master :) When? I do not s

Re: LyX 2.2 slowness

2016-12-31 Thread Jean-Marc Lasgouttes
Le 16/12/2016 à 16:42, Jean-Marc Lasgouttes a écrit : I'd be interested to see other tests, especially on MacOS and Windows. Since there not much testing going on, I pushed the patch to master :) Notable differences are: * the caching of getLayout is disabled with Qt5 * the profiling hooks ar

Memory leak with WordList

2016-12-31 Thread Jean-Marc Lasgouttes
WordList leaks all its contents on exit, which is very impolite (even though the memory will be reclaimed anyway). This hides real memory leaks that may happen elsewhere. Snippet of Valgrind output for stable below. The WordList object created in theWordList() never gets deleted, although QThr

UserGuide.lyx lyx2lyx error "unusual contents found"

2016-12-31 Thread Scott Kostyshak
See the following: $ lyx master -e lyx22x UserGuide.lyx $ lyx master -e lyx22x UserGuide.22.lyx unusual contents found: [formula simple [grid [row [cell [symbol langle][kern -2.5pt][symbol langle] [formula simple [grid [row [cell unusual contents found: [formula simple [grid [row [cell

Re: Fwd: X-Apps

2016-12-31 Thread Guenter Milde
On 2016-12-27, Paul A. Rubin wrote: > With version 18 (Sarah), Linux Mint switched to a new set of tools > called "X-Apps >", at least > for Cinnamon users. In particular, the new default PDF viewer is > "xreader", and /Evince is no lo

Re: dynamic quotes

2016-12-31 Thread Jürgen Spitzmüller
Am Freitag, den 30.12.2016, 22:39 + schrieb Guenter Milde: > Currently, there are two ways to activate a keybinding for inserting > "dynamic" quote insets: > > a) add or change a keybinding in Tools>Preferences>Editing>Shortcuts > > b) change the default behaviour of the "quote-insert" LFUN w