Re: autogen regex error

2016-12-30 Thread Scott Kostyshak
On Fri, Dec 30, 2016 at 03:05:34PM -0500, Richard Heck wrote: > On 12/30/2016 01:54 PM, Pavel Sanda wrote: > > this is what i get with current master > > > > Building Makefile templates... > > Unescaped left brace in regex is deprecated, passed through in regex; > > marked by <-- HERE in m/\${ <--

Re: dynamic quotes

2016-12-30 Thread Guillaume Munch
Le 30/12/2016 à 23:39, Guenter Milde a écrit : Dear Jürgen, dear LyX developers, I am glad to see the "dynamic quotes" and optional arguments to the quote-insert LFUN are implemented. Now, M-x quote-insert * * dynamic inserts a quote-inset that * is rendered blue in the GUI, so we can see i

dynamic quotes

2016-12-30 Thread Guenter Milde
Dear Jürgen, dear LyX developers, I am glad to see the "dynamic quotes" and optional arguments to the quote-insert LFUN are implemented. Now, M-x quote-insert * * dynamic inserts a quote-inset that * is rendered blue in the GUI, so we can see it is not a "normal" character * can be changed:

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

2016-12-30 Thread Jean-Marc Lasgouttes
Le 30/12/2016 à 17:44, Guillaume Munch a écrit : In general this is when we add a cursor.fixIfBroken() somewhere. Ok, I saw that DocIterator::sanitize and DocIterator::updateInsets both fix the pointers, but I missed that fixIfBroken does that too, and indeed there's a lot of calls to that. Why

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

2016-12-30 Thread Jean-Marc Lasgouttes
At some time where DEPM was causing issues, there was the idea of registering cursors with their buffer. This would allow to keep track of what is happening. Another possibility would be to register insets, so that one can know when cursor.inset() is not valid anymore. Or to turn this method int

Re: autogen regex error

2016-12-30 Thread Richard Heck
On 12/30/2016 01:54 PM, Pavel Sanda wrote: > this is what i get with current master > > Building Makefile templates... > Unescaped left brace in regex is deprecated, passed through in regex; marked > by <-- HERE in m/\${ <-- HERE ([^ \t=:+{}]+)}/ at /usr/bin/automake-1.15 line > 3936. Isn't this

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

2016-12-30 Thread Richard Heck
On 12/30/2016 12:15 PM, Guillaume Munch wrote: > Le 30/12/2016 à 17:11, Richard Heck a écrit : >> On 12/29/2016 01:21 AM, Guillaume Munch wrote: >>> Le 27/12/2016 à 23:11, Scott Kostyshak a écrit : On Tue, May 31, 2016 at 01:15:38AM +0200, Guillaume Munch wrote: > commit 1cc14a31ca8320d881

autogen regex error

2016-12-30 Thread Pavel Sanda
this is what i get with current master Building Makefile templates... Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/\${ <-- HERE ([^ \t=:+{}]+)}/ at /usr/bin/automake-1.15 line 3936. Using automake (GNU automake) 1.15 Using autoconf (GNU Autoconf)

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

2016-12-30 Thread Guillaume Munch
Le 30/12/2016 à 17:11, Richard Heck a écrit : On 12/29/2016 01:21 AM, Guillaume Munch wrote: Le 27/12/2016 à 23:11, Scott Kostyshak a écrit : On Tue, May 31, 2016 at 01:15:38AM +0200, Guillaume Munch wrote: commit 1cc14a31ca8320d881b674f93c34a09cf1666cca Author: Guillaume Munch Date: Mon Ma

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

2016-12-30 Thread Jean-Marc Lasgouttes
Le 30/12/2016 à 17:26, Richard Heck a écrit : Here's a modified version of this patch, taking into account JMarc's suggestions. I'd rather call the indirection functions fixCursorsIfBroken. It is ugly, but at least by reading the code I can guess what happens. JMarc

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

2016-12-30 Thread Guillaume Munch
Le 30/12/2016 à 17:05, Jean-Marc Lasgouttes a écrit : Le 29/12/2016 à 07:21, Guillaume Munch a écrit : Le 27/12/2016 à 23:11, Scott Kostyshak a écrit : On Tue, May 31, 2016 at 01:15:38AM +0200, Guillaume Munch wrote: commit 1cc14a31ca8320d881b674f93c34a09cf1666cca Author: Guillaume Munch Date

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

2016-12-30 Thread Richard Heck
On 12/30/2016 11:05 AM, Jean-Marc Lasgouttes wrote: > Le 29/12/2016 à 07:21, Guillaume Munch a écrit : >> Le 27/12/2016 à 23:11, Scott Kostyshak a écrit : >>> On Tue, May 31, 2016 at 01:15:38AM +0200, Guillaume Munch wrote: commit 1cc14a31ca8320d881b674f93c34a09cf1666cca Author: Guillaume

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

2016-12-30 Thread Richard Heck
On 12/29/2016 01:21 AM, Guillaume Munch wrote: > Le 27/12/2016 à 23:11, Scott Kostyshak a écrit : >> On Tue, May 31, 2016 at 01:15:38AM +0200, Guillaume Munch wrote: >>> commit 1cc14a31ca8320d881b674f93c34a09cf1666cca >>> Author: Guillaume Munch >>> Date: Mon May 30 21:42:08 2016 +0100 >>> >>>

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

2016-12-30 Thread Richard Heck
On 12/29/2016 01:21 AM, Guillaume Munch wrote: > Le 27/12/2016 à 23:11, Scott Kostyshak a écrit : >> On Tue, May 31, 2016 at 01:15:38AM +0200, Guillaume Munch wrote: >>> commit 1cc14a31ca8320d881b674f93c34a09cf1666cca >>> Author: Guillaume Munch >>> Date: Mon May 30 21:42:08 2016 +0100 >>> >>>

Re: [LyX/master] TocWidget: fix an erroneous collapse and optimise updates based on profiling

2016-12-30 Thread Jean-Marc Lasgouttes
Le 29/12/2016 à 07:21, Guillaume Munch a écrit : Le 27/12/2016 à 23:11, Scott Kostyshak a écrit : On Tue, May 31, 2016 at 01:15:38AM +0200, Guillaume Munch wrote: commit 1cc14a31ca8320d881b674f93c34a09cf1666cca Author: Guillaume Munch Date: Mon May 30 21:42:08 2016 +0100 TocWidget: fix