Re: Comments on patch for #9597?

2015-07-17 Thread Scott Kostyshak
On Fri, Jul 17, 2015 at 4:03 PM, Jean-Marc Lasgouttes wrote: > Le 17/07/2015 16:48, Scott Kostyshak a écrit : >> in the LaTeX source. This is correct. Now close without saving and >> open newfile8.lyx again. Click to put the cursor inside the first >> chunk's options. Then keep pressing until yo

Re: Comments on patch for #9597?

2015-07-17 Thread Scott Kostyshak
On Fri, Jul 17, 2015 at 4:03 PM, Jean-Marc Lasgouttes wrote: > No, I started from the LFUN_CHAR_FORWARD handler in Text3.cpp, which calls > cursorForward in general. In normal cases it is setCursor that calls > setCurrentFont. When entering an inset though, all is done through > checkAndActivateI

Re: Remove InsetGraphics noUnzip

2015-07-17 Thread Jean-Marc Lasgouttes
Le 17/07/2015 18:57, Pavel Sanda a écrit : Scott Kostyshak wrote: On Fri, Jul 17, 2015 at 12:35 PM, Pavel Sanda wrote: Jean-Marc Lasgouttes wrote: I think you should remove it. Are people really still using EPS files anyway? Major for me. What vector format do you use for submitting papers?

Re: Comments on patch for #9597?

2015-07-17 Thread Jean-Marc Lasgouttes
Le 17/07/2015 16:48, Scott Kostyshak a écrit : I did some testing now. Indeed the "potentially unwanted" behavior that you describe is a bug. There is no reason why text editing should change depending on what is after current word. Try this patch instead (I stole part of your commit log :). W

Re: Remove InsetGraphics noUnzip

2015-07-17 Thread Scott Kostyshak
On Fri, Jul 17, 2015 at 12:57 PM, Pavel Sanda wrote: > Scott Kostyshak wrote: >> On Fri, Jul 17, 2015 at 12:35 PM, Pavel Sanda wrote: >> > Jean-Marc Lasgouttes wrote: >> >> I think you should remove it. Are people really still using EPS files >> >> anyway? >> > >> > Major for me. What vector form

Re: Remove InsetGraphics noUnzip

2015-07-17 Thread Pavel Sanda
Scott Kostyshak wrote: > On Fri, Jul 17, 2015 at 12:35 PM, Pavel Sanda wrote: > > Jean-Marc Lasgouttes wrote: > >> I think you should remove it. Are people really still using EPS files > >> anyway? > > > > Major for me. What vector format do you use for submitting papers? > > PDF. Funny, couple

Re: Crash when closing on Fedora 22

2015-07-17 Thread Richard Heck
On 07/17/2015 05:12 AM, Stephan Witt wrote: Am 17.07.2015 um 10:56 schrieb José Matos : Hi, yesterday we got a bug report on Fedora regarding lyx crash on exit: https://bugzilla.redhat.com/show_bug.cgi?id=1243967 This seems to be related with the graphical interface so I am out of my l

Re: Visual feedback of \textsc\emph

2015-07-17 Thread Richard Heck
On 07/17/2015 06:12 AM, Jean-Marc Lasgouttes wrote: Le 26/06/2015 15:20, Cor Blom a écrit : Hi, Sometimes I want text to be both small caps and emphasized. I can do that and it is correct in the output, but in lyx itself it just shows as regular text, indistinguishable from normal text, which m

Re: Remove InsetGraphics noUnzip

2015-07-17 Thread Scott Kostyshak
On Fri, Jul 17, 2015 at 12:35 PM, Pavel Sanda wrote: > Jean-Marc Lasgouttes wrote: >> I think you should remove it. Are people really still using EPS files >> anyway? > > Major for me. What vector format do you use for submitting papers? PDF. Scott

Re: Remove InsetGraphics noUnzip

2015-07-17 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > I think you should remove it. Are people really still using EPS files > anyway? Major for me. What vector format do you use for submitting papers? P

Re: Comments on patch for #9597?

2015-07-17 Thread Scott Kostyshak
On Fri, Jul 17, 2015 at 10:17 AM, Jean-Marc Lasgouttes wrote: > Le 17/07/2015 16:07, Jean-Marc Lasgouttes a écrit : >> >> I have to admit that at this point I am in theoretical debugging code. I >> have not applied any patch nor launched a debugger. I may have to >> actually test your patch and se

Re: Comments on patch for #9597?

2015-07-17 Thread Jean-Marc Lasgouttes
Le 17/07/2015 16:07, Jean-Marc Lasgouttes a écrit : I have to admit that at this point I am in theoretical debugging code. I have not applied any patch nor launched a debugger. I may have to actually test your patch and see what are the effects you describe. But changing Text::checkAndActivateIns

Re: Comments on patch for #9597?

2015-07-17 Thread Jean-Marc Lasgouttes
Le 17/07/2015 15:01, Scott Kostyshak a écrit : We have to understand what is the difference between these two insets. I see. I was thinking about if from a different way. I was thinking that there is a method that is not called when entering an inset from the keyboard. I see though that we need

Re: Comments on patch for #9597?

2015-07-17 Thread Scott Kostyshak
On Fri, Jul 17, 2015 at 8:45 AM, Jean-Marc Lasgouttes wrote: > Le 17/07/2015 14:36, Scott Kostyshak a écrit : >>> >>> What made you try to add the SetCurrentFont()? >> >> >> Once I could reproduce, I looked for differences between the "bad" and >> "good" cases. I saw a difference in the status bar

Re: Comments on patch for #9597?

2015-07-17 Thread Jean-Marc Lasgouttes
Le 17/07/2015 14:36, Scott Kostyshak a écrit : What made you try to add the SetCurrentFont()? Once I could reproduce, I looked for differences between the "bad" and "good" cases. I saw a difference in the status bar at the bottom of the screen. I set a break point at some font-related code and

Re: [LyX/master] Fix logic error in on-screen font shape

2015-07-17 Thread Jean-Marc Lasgouttes
Le 17/07/2015 14:32, Scott Kostyshak a écrit : Fix logic error in on-screen font shape This made text in smallcaps+emph display as upright instead of plain emph. There is no latex font for smallcaps + emph, but it is not a reason for displaying it wrong. Is this #3519? Sco

Re: Comments on patch for #9597?

2015-07-17 Thread Scott Kostyshak
On Fri, Jul 17, 2015 at 8:18 AM, Jean-Marc Lasgouttes wrote: > Le 16/07/2015 20:18, Scott Kostyshak a écrit : >> >> I do not know if my approach is the correct one. The behavior that it >> changes (see the ticket or commit message) makes me think that it might >> not be the correct approach. Even

Re: [LyX/master] Fix logic error in on-screen font shape

2015-07-17 Thread Scott Kostyshak
On Fri, Jul 17, 2015 at 6:10 AM, Jean-Marc Lasgouttes wrote: > commit 4cdd9732d3f29f212d6abda019e3cf88623272df > Author: Jean-Marc Lasgouttes > Date: Fri Jul 17 12:07:52 2015 +0200 > > Fix logic error in on-screen font shape > > This made text in smallcaps+emph display as upright instea

Re: InsetInfo does not use the right set of icons.

2015-07-17 Thread Jean-Marc Lasgouttes
Le 17/07/2015 12:09, Kornel Benko a écrit : Works here. After changing the icon set I have to reload the file though. It is probable that the toolbar uses a theme icon, and InsetInfo does not know how to handle that. JMarc

Re: Comments on patch for #9597?

2015-07-17 Thread Jean-Marc Lasgouttes
Le 16/07/2015 20:18, Scott Kostyshak a écrit : I do not know if my approach is the correct one. The behavior that it changes (see the ticket or commit message) makes me think that it might not be the correct approach. Even if it is a reasonable, it would need testing in master. First, what is d

Re: Crash when closing on Fedora 22

2015-07-17 Thread José Matos
On Friday 17 July 2015 11:12:18 Stephan Witt wrote: > This type of crash was reported for Mac OS X only until now. > > I'd guess it is similar to LyX bug 9659 (http://www.lyx.org/trac/ticket/9659). > > The fix was not backported yet, we may consider doing so now. (No string > change involved.) >

Re: Visual feedback of \textsc\emph

2015-07-17 Thread Jean-Marc Lasgouttes
Le 26/06/2015 15:20, Cor Blom a écrit : Hi, Sometimes I want text to be both small caps and emphasized. I can do that and it is correct in the output, but in lyx itself it just shows as regular text, indistinguishable from normal text, which makes it hard to use this. Is this a bug? Or is there

Re: InsetInfo does not use the right set of icons.

2015-07-17 Thread Kornel Benko
Am Freitag, 17. Juli 2015 um 11:51:14, schrieb Jean-Marc Lasgouttes > Hello, > > I just noticed that inset-info does not use the same set of icons as the > toolbar (see redo icon in attached screenshot). Is that to be expected? > > JMarc Works here. After changing the icon set I have to reloa

InsetInfo does not use the right set of icons.

2015-07-17 Thread Jean-Marc Lasgouttes
Hello, I just noticed that inset-info does not use the same set of icons as the toolbar (see redo icon in attached screenshot). Is that to be expected? JMarc

Re: Crash when closing on Fedora 22

2015-07-17 Thread Stephan Witt
Am 17.07.2015 um 10:56 schrieb José Matos : > Hi, > yesterday we got a bug report on Fedora regarding lyx crash on exit: > https://bugzilla.redhat.com/show_bug.cgi?id=1243967 > > This seems to be related with the graphical interface so I am out of my > league here. :-) > This type of cra

Re: Lyx slow even with small documents

2015-07-17 Thread Jean-Marc Lasgouttes
Le 17/07/2015 10:53, Jean-Marc Lasgouttes a écrit : Can you try to use \use_qimage false in .lyx/preferences? Normally the default is "true" but you could maybe try both. And does using --no-argb with awesome help? I am not even sure this still exists, it is a tip given in older discussions

Crash when closing on Fedora 22

2015-07-17 Thread José Matos
Hi, yesterday we got a bug report on Fedora regarding lyx crash on exit: https://bugzilla.redhat.com/show_bug.cgi?id=1243967 This seems to be related with the graphical interface so I am out of my league here. :-) Regards, -- José Abílio

Re: Lyx slow even with small documents

2015-07-17 Thread Jean-Marc Lasgouttes
Le 17/07/2015 01:51, Sad Lyxer a écrit : Jean-Marc Lasgouttes lyx.org> writes: That make the problem similar to some of the other bug reports. I suspect that the profiler will tell you that most of the time is spent in the X server. Did you try "top" or similar to see that? top says lyx is u