Re: Wrong enum as boolean usage in Text3.cpp

2015-05-08 Thread Stephan Witt
Am 09.05.2015 um 05:12 schrieb Scott Kostyshak : > On Fri, May 8, 2015 at 10:29 PM, Stephan Witt wrote: >> Since change 02cb5fd3 one can see the clever code fragment in Text3.cpp line >> 2934..2943 has a problem with Clipboard::PdfGraphicsType. The assignment of >> type for "pdf" at line 2935 i

Re: Wrong enum as boolean usage in Text3.cpp

2015-05-08 Thread Scott Kostyshak
On Fri, May 8, 2015 at 10:29 PM, Stephan Witt wrote: > Since change 02cb5fd3 one can see the clever code fragment in Text3.cpp line > 2934..2943 has a problem with Clipboard::PdfGraphicsType. The assignment of > type for "pdf" at line 2935 is not true for arg value "pdf". The enum > Clipboard::

Wrong enum as boolean usage in Text3.cpp

2015-05-08 Thread Stephan Witt
Since change 02cb5fd3 one can see the clever code fragment in Text3.cpp line 2934..2943 has a problem with Clipboard::PdfGraphicsType. The assignment of type for "pdf" at line 2935 is not true for arg value "pdf". The enum Clipboard::GraphicsType shouldn't start with PdfGraphicsType or the code

Re: C++ question about auto_ptr

2015-05-08 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > With C++11, auto_ptr is deprecated and we get warnings. > > I am trying to see how we can get rid of it. unique_ptr is new to C++11, > so I'd rather avoid that. Why not use unique_ptr fpr C++11 and auto_ptr else? The difference is in the copying semantics, which do

C++ question about auto_ptr

2015-05-08 Thread Jean-Marc Lasgouttes
With C++11, auto_ptr is deprecated and we get warnings. I am trying to see how we can get rid of it. unique_ptr is new to C++11, so I'd rather avoid that. I have many places like in the patch below. Is there a reason why I should keep the auto_ptr instead of a naked pointer? What is it good f

Re: Failure to compile lyx with gcc 5.1 with the new ABI

2015-05-08 Thread Georg Baum
José Matos wrote: > While testing what packages failed with the new ABI one of the cases is > LyX (2.1.3), the first builder to fail was the x86_64 one and this is why > this message refers to it: > > https://kojipkgs.fedoraproject.org//work/tasks/1267/9651267/build.log > > The failures start at

Re: [LyX/master] Fix compilation after e93444e7

2015-05-08 Thread Stephan Witt
Am 08.05.2015 um 14:17 schrieb Enrico Forestieri : > commit bc8717b297e0b3001ccaf5146ba5ec945c77ad42 > Author: Enrico Forestieri > Date: Fri May 8 14:15:38 2015 +0200 > > Fix compilation after e93444e7 > > Stephan, please check whether RowPainter::paintMisspelledMark has > to be extended to u

Re: [LyX/master] #9514 improved document iterator for correct check of speller disabled state

2015-05-08 Thread Kornel Benko
Am Freitag, 8. Mai 2015 um 11:13:57, schrieb Stephan Witt > commit e93444e7e9d6f1aeabd356d414d4e5af3cea8569 > Author: Stephan Witt > Date: Fri May 8 11:13:32 2015 +0200 > > #9514 improved document iterator for correct check of speller disabled > state > I cannot compile ATM. [ 77%] Bui