Re: Key board based horizontal scrolling

2013-09-11 Thread Hashini Senaratne
Hello Jean-Marc, > I think this behavior (of Cursor::bottomRow) is fixed in the attached > commit. I also reverted some of the workarounds that you introduced. > Please test and commit if it is satisfying. I test this patch and committed to the repository. Moreover I deleted the setLeftEdge(0)

Re: Key board based horizontal scrolling

2013-09-11 Thread Jean-Marc Lasgouttes
Dear Hashini, As you probably saw, I just answered to your previous message and sent a patch. 11/09/2013 14:54, Hashini Senaratne: But after the last commit I think now I can use, left_edge != > cur.getLeftEdge() too. Although, to me this boolean is more clear. Yes, I will follow the term you

Re: Key board based horizontal scrolling

2013-09-11 Thread Jean-Marc Lasgouttes
11/09/2013 11:43, Hashini Senaratne: As &row do not give the expected row address in checkCursorLeftEdge() method in BufferView when selecting certain positions in Math inset using the mouse pointer, above first two bugs caused. Here the row is defined as, Row const & row = cur.bottomRow(); At th

Re: Key board based horizontal scrolling

2013-09-11 Thread Hashini Senaratne
Hello Jean-Marc, > 1/ In checkCursorLeftEdge, you introduce a new bool row_need_slide that > in my mind is equivalent to the old test "left_edge != > cur.getLeftEdge()", since the goal is to know whether the row needs to > be repainted. Does the new form make a difference? > > I am OK with the

Re: Key board based horizontal scrolling

2013-09-11 Thread Jean-Marc Lasgouttes
11/09/2013 11:43, Hashini Senaratne: Hello Jean-Marc, Now it seems like most of the bugs are fixed with keyboard based solution. *Selecting a different position in an already slid row *Selecting a range of text in an already slid row *Behaviour related to Home and End keys Above features seems

Re: LyX + Qt5 + CMake + XCode - attached files (1/1)

2013-09-11 Thread Jean-Marc Lasgouttes
09/09/2013 20:39, pdv: Where do I find the features/str-metrics branch? Following http://wiki.lyx.org/Devel/LyXGit#toc3, here is what I would suggest: git remote add features git:features.git git checkout --track -b features/str-metrics JMarc

Key board based horizontal scrolling

2013-09-11 Thread Hashini Senaratne
Hello Jean-Marc, Now it seems like most of the bugs are fixed with keyboard based solution. *Selecting a different position in an already slid row *Selecting a range of text in an already slid row *Behaviour related to Home and End keys Above features seems to work well in this commit: http://gi

"Star" arguments for true/false options

2013-09-11 Thread Andrew Parsloe
I've now used the new treatment of flex inset arguments "in earnest" (and will no doubt burden the user list with the result in due course). The new treatment is a real advance. Initially the positioning of "post" arguments in the LyX display confused me. My naive expectation was that they wou