unicodesymbols and tex2lyx

2013-07-26 Thread Pavel Sanda
Unicode experts, I just failed to correctly import .tex file into lyx, more precisely while \'a gets correctly translated into á, \'i is not translated and you see only ERT with the \'i. Looking into unicodesymbols file the difference seems to be clear: 0x00e1 "\\'{a}" "" "matha

difficulty getting variable value to reflect whether checkbox is checked/unchecked

2013-07-26 Thread Josh Hieronymus
I'm trying to figure out how to add an option to write CSS generated during XHTML export to a separate directory, but I'm running into some difficulties. I've pushed my attempt to a new branch in the GSoC repo as seen here: http://git.lyx.org/?p=gsoc.git;a=shortlog;h=refs/heads/xhtml/new_features/c

Re: [PATCH] Fix Qt5 decimal separator bug

2013-07-26 Thread Enrico Forestieri
On Fri, Jul 19, 2013 at 10:32:27PM +0200, Stephan Witt wrote: > I think another move would be better: the internal representation of > numeric values as strings is not a good idea. The code looks much > nicer when making the font_sizes an array of double values. > > Of course making the font_size

Re: lyx-tester

2013-07-26 Thread Kornel Benko
Am Freitag, 26. Juli 2013 um 15:34:43, schrieb Vincent van Ravesteijn > > > I would be very interested in a unit test framework but I do not know > > how to set that up. > > > > Scott > > I have a branch in my personal repo that has a unit testing framework > base on google test. > > http:/

Re: LyX-2.1.0beta1 on FTP

2013-07-26 Thread Richard Heck
On 07/26/2013 10:07 AM, Richard Heck wrote: On 07/26/2013 09:18 AM, John Kennan wrote: Vincent van Ravesteijn lyx.org> writes: The source code and Windows installer for LyX-2.1.0beta1 are now available at ftp://ftp.lyx.org/pub/lyx/devel/lyx-2.1/lyx-2.1.0beta1/ Editing and saving a fi

Re: LyX-2.1.0beta1 on FTP

2013-07-26 Thread Richard Heck
On 07/26/2013 09:18 AM, John Kennan wrote: Vincent van Ravesteijn lyx.org> writes: The source code and Windows installer for LyX-2.1.0beta1 are now available at ftp://ftp.lyx.org/pub/lyx/devel/lyx-2.1/lyx-2.1.0beta1/ Editing and saving a file makes it unreadable on 2.0.6 (Windows XP)

Re: lyx-tester

2013-07-26 Thread Vincent van Ravesteijn
Op 25-7-2013 19:39, Scott Kostyshak schreef: On Thu, Jul 25, 2013 at 11:52 AM, Vincent van Ravesteijn wrote: Another thing is that we probably don't want to test the documents in the attic directory. I've changed my mind a couple of times on this. Right now my opinion is that I disagree. It de

Re: lyx-tester

2013-07-26 Thread Vincent van Ravesteijn
I would be very interested in a unit test framework but I do not know how to set that up. Scott I have a branch in my personal repo that has a unit testing framework base on google test. http://git.lyx.org/?p=developers/vfr/lyx.git;a=shortlog;h=refs/heads/tests Vincent

Re: LyX-2.1.0beta1 on FTP

2013-07-26 Thread Jean-Marc Lasgouttes
26/07/2013 15:18, John Kennan: Vincent van Ravesteijn lyx.org> writes: The source code and Windows installer for LyX-2.1.0beta1 are now available at ftp://ftp.lyx.org/pub/lyx/devel/lyx-2.1/lyx-2.1.0beta1/ Editing and saving a file makes it unreadable on 2.0.6 (Windows XP) It gives a

Re: LyX-2.1.0beta1 on FTP

2013-07-26 Thread John Kennan
Vincent van Ravesteijn lyx.org> writes: > > The source code and Windows installer for LyX-2.1.0beta1 are now > available at > > ftp://ftp.lyx.org/pub/lyx/devel/lyx-2.1/lyx-2.1.0beta1/ > Editing and saving a file makes it unreadable on 2.0.6 (Windows XP) It gives a message about a Buffer

Re: [BUG] Langauge Change When Outputting Optional Argument

2013-07-26 Thread Marius Bühlmann
Jürgen Spitzmüller lyx.org> writes: > > 2013/3/19 Richard Heck lyx.org>: > > If this one is fixed in trunk, we could leave it there. It's a pretty > > obscure bug. > > We need to check. If someone has a recipe for the bug, please test. > > Jürgen > > > rh > > > > I'm using Lyx 2.0.6 in G

Re: Row by Row sliding (review of 095060cfcaa8f)

2013-07-26 Thread Jean-Marc Lasgouttes
26/07/2013 10:54, Jean-Marc Lasgouttes: I continue my backwards visit of history. I forgot a couple of remarks in this commit. - RowPainter rp(pi, *text_, pit, row, bidi, x, y); + + cur.setTargetX(); Do you really need to set targetX? This seems plain wrong to me

Re: automake 1.14

2013-07-26 Thread Jean-Marc Lasgouttes
26/07/2013 10:54, Stephan Witt: This works for me and I need this change because I have automake 1.14 now. So, may I commit it? The same patch is needed for 2.0.X. I think you should. JMarc

Re: Row by Row sliding (review of 27fbf20e9b)

2013-07-26 Thread Jean-Marc Lasgouttes
As a preamble, the most important remark is that you should never declare methods and members in a commit and implement them in anothe rone. Each commit should be self contained and leave the trunk compilable. The idea is not to commit file-by-file, but function-by-function. JMarc +++ b/src/

Re: Row by Row sliding (review of

2013-07-26 Thread Jean-Marc Lasgouttes
I continue the review. Coding style point: please leave two empty lines between method definitions. JMarc +++ b/src/Cursor.cpp @@ -278,7 +278,7 @@ CursorData::CursorData(DocIterator const & dit) // bv functions are not yet available! Cursor::Cursor(BufferView & bv) : CursorData(&bv.bu

Re: Row by Row sliding (review of 095060cfcaa8f)

2013-07-26 Thread Jean-Marc Lasgouttes
I continue my backwards visit of history. JMarc +++ b/src/TextMetrics.cpp @@ -16,7 +16,6 @@ */ #include - #include "TextMetrics.h" There is no reason to delete a line here. You should always before pushing a commit look at the diff and spot this kind of unintented changes. #include

Re: automake 1.14

2013-07-26 Thread Stephan Witt
Am 24.07.2013 um 15:22 schrieb Jean-Marc Lasgouttes : > 24/07/2013 10:09, Vincent van Ravesteijn: >> Is this already committed, or can anyone say something smart about this ? > > The patch is not committed AFAICS. The warning does not hrm, it just tells us > whet is going to happen with automake

Re: Row by Row sliding (review of 78364e430)

2013-07-26 Thread Jean-Marc Lasgouttes
Hi Hashinni, I thought I would review your commits to gsoc/master, in reverse order. I start from 78364e430. +++ b/src/frontends/qt4/GuiWorkArea.cpp @@ -627,6 +627,17 @@ void GuiWorkArea::Private::showCursor() && !completer_->inlineVisible(); cursor_visible_ = true;