Re: German Users Guide for 2.1

2013-06-26 Thread Stephan Witt
Am 26.06.2013 um 23:15 schrieb Uwe Stöhr : > Am 26.06.2013 11:56, schrieb Stephan Witt: > >> I catched a wrong word in Section 2.1. >> >> The sentence "Es gibt keinen vertikalen Rollbalken" is wrong. >> Obviously it should be "Es gibt keinen horizontalen Rollbalken". > > Thanks for the report,

Re: German Users Guide for 2.1

2013-06-26 Thread Uwe Stöhr
Am 26.06.2013 11:56, schrieb Stephan Witt: I catched a wrong word in Section 2.1. The sentence "Es gibt keinen vertikalen Rollbalken" is wrong. Obviously it should be "Es gibt keinen horizontalen Rollbalken". Thanks for the report, I fixed this now. I cannot fix it because a change of this

Re: Row by Row sliding

2013-06-26 Thread Hashini Senaratne
Hello Jean-Marc, > There is a mechanism to avoid drawing rows when they are unchanged. Look > for this code in drawParagrph: > > // Row signature; has row changed since last paint? > row.setCrc(pm.computeRowSignature(row, bparams)); > bool row_has_change

Re: Row by Row sliding

2013-06-26 Thread Jean-Marc Lasgouttes
Le 26/06/2013 16:09, Hashini Senaratne a écrit : Jean-Marc Lasgouttes lyx.org> writes: OK, what about using TexMetrics::cursorX() or maybe BufferView::getPos()? The later is what is called by setTargetX. Nothing that work. I think the reason is when the cursor moves along a row as a result o

Re: Row by Row sliding

2013-06-26 Thread Hashini Senaratne
Jean-Marc Lasgouttes lyx.org> writes: > OK, what about using TexMetrics::cursorX() or maybe > BufferView::getPos()? The later is what is called by setTargetX. Nothing that work. I think the reason is when the cursor moves along a row as a result of key board presses of arrow keys, drawparagraph

Re: Row by Row sliding

2013-06-26 Thread Jean-Marc Lasgouttes
Le 26/06/2013 14:13, Hashini Senaratne a écrit : I think I figured out some clue. When the cursor is in a Math inset and when I move the cursor using "ARROW KEYS", no change happens. But when I use the "MOUSE" for select a different position in the same row, the value targetX() gets change. What

Re: Row by Row sliding

2013-06-26 Thread Hashini Senaratne
Hello Jean-Marc, > > You can use setTargetX() to force a recomputation. Does this work? > > > > Sorry that did not work. > > I am using this within drawparagraph() of TextMetrics. As setTargetX() is > not a const method, I cannot call it as cur.setTargetX(). So I defined > another non- cnstant

Re: Row by Row sliding

2013-06-26 Thread Hashini Senaratne
Hello Jean-Marc, > > Le 26/06/2013 08:45, Hashini Senaratne a écrit : > > Hello Jean-Marc, > > > >> * A Cursor is a descendant of CursorData that contains interesting > >> display-related information, in particular targetX(), the horizontal > >> position of the cursor in pixels. > > > > I checked

German Users Guide for 2.1

2013-06-26 Thread Stephan Witt
Hi, I catched a wrong word in Section 2.1. The sentence "Es gibt keinen vertikalen Rollbalken" is wrong. Obviously it should be "Es gibt keinen horizontalen Rollbalken". I cannot fix it because a change of this word results in a diff of 100% of the document. Stephan

Re: [PATCH] LFUN_DOWN: if cursor is on last line, move to end

2013-06-26 Thread Stephan Witt
Am 26.06.2013 um 10:41 schrieb Jean-Marc Lasgouttes : > Le 26/06/2013 10:07, Stephan Witt a écrit : >> How does this look? >> >> bool Cursor::atFirstOrLastRowOfDocument(bool up) >> { >>Cursor dummy = *this; >>bool result = dummy.atFirstOrLastRow(up); >>while (result && dummy.depth() >

Re: [PATCH] LFUN_DOWN: if cursor is on last line, move to end

2013-06-26 Thread Jean-Marc Lasgouttes
Le 26/06/2013 10:07, Stephan Witt a écrit : How does this look? bool Cursor::atFirstOrLastRowOfDocument(bool up) { Cursor dummy = *this; bool result = dummy.atFirstOrLastRow(up); while (result && dummy.depth() > 1) { dummy.pop(); result = dummy.atFirstOrLastRow(up);

Re: [PATCH] LFUN_DOWN: if cursor is on last line, move to end

2013-06-26 Thread Jean-Marc Lasgouttes
Le 25/06/2013 12:19, Stephan Witt a écrit : The value of result is overwritten until the bottom of the stack. The value of "result" is checked on every loop. The loop stops at the first cursor slice not atFirstOrLastRow. Then the method returns false. Doh! The worst part is that I read it sev

Re: [PATCH] LFUN_DOWN: if cursor is on last line, move to end

2013-06-26 Thread Stephan Witt
Am 25.06.2013 um 12:19 schrieb Stephan Witt : > Am 25.06.2013 um 11:30 schrieb Jean-Marc Lasgouttes : > >> Le 24/06/2013 17:13, Stephan Witt a écrit : >>> +bool Cursor::atFirstOrLastRowOfDocument(bool up) >>> +{ >>> + Cursor dummy = *this; >>> + bool result = dummy.atFirstOrLastRow(up); >>>

Re: Row by Row sliding

2013-06-26 Thread Jean-Marc Lasgouttes
Le 26/06/2013 08:45, Hashini Senaratne a écrit : Hello Jean-Marc, * A Cursor is a descendant of CursorData that contains interesting display-related information, in particular targetX(), the horizontal position of the cursor in pixels. I checked targetX() and it only gets changed when the cur