Re: [patch] #2179 LaTeX and chktex error handling problem

2009-07-29 Thread John McCabe-Dansted
OK, I noticed a problem in the last patch. It would cause the error in the ErrorListDialog to become unhighlighted when clicking on the main window. The root cause of the problem appears to be that GuiDialog::updateView calls updateContents, which causes ErrorListDialog to reread all the error eac

[patch] #2179 LaTeX and chktex error handling problem

2009-07-29 Thread John McCabe-Dansted
How does this patch look? I thought it would be cleaner if I could avoid needing to add the variable "bool need_to_set_row", however I cannot see how this could be done. If I put setCurrentRow(0) in GuiErrorList::showEvent it doesn't do anything, and calling setCurrentRow(0) on every update was the

Re: r30766 - lyx-devel/trunk/src

2009-07-29 Thread Enrico Forestieri
On Wed, Jul 29, 2009 at 01:34:45PM +0200, Jürgen Spitzmüller wrote: > Enrico Forestieri wrote: > > I was still able to find cases where it would fail. Looking more closely at > > the code, it was clear that a similar treatment should have also been > > performed in TeXEnvironment(). After careful

[patch] Re: RFC: Use Author hash value to identify tracked changes

2009-07-29 Thread Gregory Jefferis
Hello all, After a long hiatus, I returned to this problem, editing my previous patch series to respond to the helpful comments from various people on the list. Vincent made the most detailed response so I responded below point by point and attached the v2 patch series for comment. This complete e

Lyx git mirror

2009-07-29 Thread Gregory Jefferis
I just wondered if the lyx git mirror is going to be restarted? Many thanks, Greg. -- Gregory Jefferis, PhD jeffe...@mrc-lmb.cam.ac.uk Division of Neurobiology LMB Lab:+44 (0)1223 252943 MRC Laboratory of Molecular Biology, LMB Office: +44 (0)1223

Re: r30766 - lyx-devel/trunk/src

2009-07-29 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: > I was still able to find cases where it would fail. Looking more closely at > the code, it was clear that a similar treatment should have also been > performed in TeXEnvironment(). After careful testing, I have committed a > fix to trunk that doesn't fail for all the cont