Re: [patch] support for paragraph indentation

2009-07-16 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > Index: BufferParams.cpp > === > --- BufferParams.cpp(revision 30639) > +++ BufferParams.cpp(working copy) > @@ -289,6 +289,7 @@ > /** This is the amount of space used for paragraph_separation > "skip"

Re: r30636 - lyx-devel/trunk/src/frontends/qt4

2009-07-16 Thread John McCabe-Dansted
On Fri, Jul 17, 2009 at 7:10 AM, rgheck wrote: > On 07/16/2009 06:24 PM, rgh...@lyx.org wrote: >> >> Author: rgheck >> Date: Fri Jul 17 00:24:39 2009 >> New Revision: 30636 >> URL: http://www.lyx.org/trac/changeset/30636 Minor nitpick: s/coudl/could/ 1509 _("LyX

Re: r30636 - lyx-devel/trunk/src/frontends/qt4

2009-07-16 Thread Jürgen Spitzmüller
rgheck wrote: > > Log: > > Fix bug #6076. As said there, other configuration files probably need to > > be checked. > > > > > > For branch? Yes, please. Jürgen

Re: [patch] support for paragraph indentation

2009-07-16 Thread Uwe Stöhr
> AFAICS, you have not defined a default length, but a default unit. This might > be confused with the already used defaultUnit(), and it doesn't look like a > clean solution. > > The by far best method, I think, would be to setup a HSpace class similar to > the VSpace class. This class could inhe

Re: r30636 - lyx-devel/trunk/src/frontends/qt4

2009-07-16 Thread rgheck
On 07/16/2009 06:24 PM, rgh...@lyx.org wrote: Author: rgheck Date: Fri Jul 17 00:24:39 2009 New Revision: 30636 URL: http://www.lyx.org/trac/changeset/30636 Log: Fix bug #6076. As said there, other configuration files probably need to be checked. For branch? rh

Re: r30634 - in lyx-devel/trunk/src: . insets mathed

2009-07-16 Thread rgheck
On 07/16/2009 05:26 PM, Jean-Marc Lasgouttes wrote: - lyxerr << "LyX Code: " << lyxCode() << " name: " << name() << std::endl; + lyxerr << "LyX Code: " << lyxCode() << " name: " << insetName(lyxCode()) << std::endl; Just to make sure that we agree: the method name() ha nothing to do with inse

Re: Another assertion

2009-07-16 Thread rgheck
On 07/16/2009 08:32 AM, Enrico Forestieri wrote: Load the attached file, selected both lines in the Quote environment and center them using the Paragraph settings dialog. ../../src/Paragraph.cpp(1357): pos: 7 size: 6 ../../../src/support/lassert.cpp(21): ASSERTION pos<= size() VIOLATED IN ../..

Re: r30634 - in lyx-devel/trunk/src: . insets mathed

2009-07-16 Thread Jean-Marc Lasgouttes
- lyxerr << "LyX Code: " << lyxCode() << " name: " << name() << std::endl; + lyxerr << "LyX Code: " << lyxCode() << " name: " << insetName(lyxCode()) << std::endl; Just to make sure that we agree: the method name() ha nothing to do with insetName(lyxCodde()). It returns the string used f

Re: Approaching LyX 1.6.4 [status update #1]

2009-07-16 Thread rgheck
On 07/16/2009 05:22 PM, Jean-Marc Lasgouttes wrote: Le 16 juil. 09 à 21:21, rgheck a écrit : I'd suggest closing the bug. Keytest has already found another SIGSEGV, and is minimising the number of keycodes needed to reproduce. I don't see any point spending time worrying about old irreducible ke

Re: Approaching LyX 1.6.4 [status update #1]

2009-07-16 Thread Jean-Marc Lasgouttes
Le 16 juil. 09 à 21:21, rgheck a écrit : I'd suggest closing the bug. Keytest has already found another SIGSEGV, and is minimising the number of keycodes needed to reproduce. I don't see any point spending time worrying about old irreducible keytest bugs, when there are new reproducible keytes

Re: Approaching LyX 1.6.4 [status update #1]

2009-07-16 Thread rgheck
On 07/16/2009 03:15 PM, John McCabe-Dansted wrote: On Thu, Jul 16, 2009 at 9:52 PM, rgheck wrote: #5997 lyx::Buffer::save calls 0x0016 (SIGSEGV) Since this was a keypress crash, I have no idea how to reproduce. Neither do I unfortunately. This was from an old version

Re: Approaching LyX 1.6.4 [status update #1]

2009-07-16 Thread John McCabe-Dansted
On Thu, Jul 16, 2009 at 9:52 PM, rgheck wrote: >> #5997  lyx::Buffer::save calls 0x0016 (SIGSEGV) >> > > Since this was a keypress crash, I have no idea how to reproduce. Neither do I unfortunately. This was from an old version of keytest that didn't generate very useful logs. I'm running key

Math Assertion

2009-07-16 Thread rgheck
Enrico's assertion can be had this way: Ctrl-N Ctrl-M Ctrl-M Type a few characters Click on one of them The assertion is due to an empty buffer_ in an InsetMathChar. From what I can tell, there just isn't the code there to set the insets of all the nested math stuff. InsetMathHull seems to ha

Re: Sweave string

2009-07-16 Thread Liviu Andronic
Dear all, On Sun, Jul 12, 2009 at 8:17 PM, Philippe Grosjean wrote: > I have worked a little bit with Romain François (an independent R developer) > to make a better Sweave engine that allows for syntax coloring of the R > code. Everything is pretty much customizable from there. I'll look if I can

Re: Assert when clicking a math inset

2009-07-16 Thread rgheck
On 07/16/2009 09:49 AM, Vincent van Ravesteijn - TNW wrote: On Thu, Jul 16, 2009 at 12:09:40AM +0200, Vincent van Ravesteijn - TNW wrote: Current trunk: LyX asserts when clicking in a math inset. There's no problem entering a math inset using the arrow keys. Still there. Steps

Re: Another assertion

2009-07-16 Thread rgheck
On 07/16/2009 09:54 AM, rgheck wrote: On 07/16/2009 08:32 AM, Enrico Forestieri wrote: Load the attached file, selected both lines in the Quote environment and center them using the Paragraph settings dialog. ../../src/Paragraph.cpp(1357): pos: 7 size: 6 ../../../src/support/lassert.cpp(21): AS

Re: Another assertion

2009-07-16 Thread rgheck
On 07/16/2009 08:32 AM, Enrico Forestieri wrote: Load the attached file, selected both lines in the Quote environment and center them using the Paragraph settings dialog. ../../src/Paragraph.cpp(1357): pos: 7 size: 6 ../../../src/support/lassert.cpp(21): ASSERTION pos<= size() VIOLATED IN ../..

Re: Approaching LyX 1.6.4 [status update #1]

2009-07-16 Thread rgheck
On 07/16/2009 02:01 AM, Jürgen Spitzmüller wrote: Looking at status.16x, I see a long, steadily growing list, so I think it's time for some planning. I think we have enough new features in and we should concentrate on stabilization and crucial issues now (I know Vincent still has pending patches

RE: Assert when clicking a math inset

2009-07-16 Thread Vincent van Ravesteijn - TNW
On Thu, Jul 16, 2009 at 12:09:40AM +0200, Vincent van Ravesteijn - TNW wrote: >> >> Current trunk: LyX asserts when clicking in a math inset. >> >> There's no problem entering a math inset using the arrow keys. >> > >> >Still there. Steps to reproduce: >> >> What if you remove "setBuffer(..) {}

Re: Assert when clicking a math inset

2009-07-16 Thread Enrico Forestieri
On Thu, Jul 16, 2009 at 12:09:40AM +0200, Vincent van Ravesteijn - TNW wrote: > >> Current trunk: LyX asserts when clicking in a math inset. > >> There's no problem entering a math inset using the arrow keys. > > > >Still there. Steps to reproduce: > > What if you remove "setBuffer(..) {}" from In

Re: Assert when clicking a math inset

2009-07-16 Thread Enrico Forestieri
On Wed, Jul 15, 2009 at 07:05:02PM -0400, rgheck wrote: > On 07/15/2009 05:57 PM, Enrico Forestieri wrote: > > On Wed, Jul 15, 2009 at 01:41:28PM +0200, Enrico Forestieri wrote: > > > >> Current trunk: LyX asserts when clicking in a math inset. > >> There's no problem entering a math inset usin

Another assertion

2009-07-16 Thread Enrico Forestieri
Load the attached file, selected both lines in the Quote environment and center them using the Paragraph settings dialog. ../../src/Paragraph.cpp(1357): pos: 7 size: 6 ../../../src/support/lassert.cpp(21): ASSERTION pos <= size() VIOLATED IN ../../src/Paragraph.cpp:1358 -- Enrico #LyX 2.0.0svn

Re: Approaching LyX 1.6.4 [status update #1]

2009-07-16 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller writes: > I don't think it's too much to ask that people respect that doing > release management is not always a job where you can please everybody > at every time I don't understand, when I did it, I pleased everybody every time. Or this is what I recall, at least. I'm sure I

Re: r30624 - lyx-devel/trunk/src/frontends/qt4

2009-07-16 Thread Jürgen Spitzmüller
Vincent van Ravesteijn - TNW wrote: > Juergen 1.6.4 (very easy change) > > - setCustomPapersize(!extern_geometry && psize); > + setCustomPapersize(!extern_geometry && psize == 1); > > A regression occurred because the parameter of this function was > converted into a bool by adding !ext

Re: Approaching LyX 1.6.4 [status update #1]

2009-07-16 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > thats right. but my feeling is that the real point here is to keep Vincent > motivated while he has enough enthusiasm to fix years old bugs which nobody > else would even touch. after all what the milestone 1.6.x means? if you > consider those bugs as candy and bling worthless

Re: Approaching LyX 1.6.4 [status update #1]

2009-07-16 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > People who do not see a reason to upgrade should stick with their version. I > do not see the point of adding candy and bling just for the sake of getting > people to upgrade. My aim is to make LyX as robust and reliable as possible, > not to get as many users as poss

RE: r30624 - lyx-devel/trunk/src/frontends/qt4

2009-07-16 Thread Vincent van Ravesteijn - TNW
>Juergen 1.6.4 (very easy change) Juergen 1.6.4 (very easy change) ?? Vincent

RE: r30624 - lyx-devel/trunk/src/frontends/qt4

2009-07-16 Thread Vincent van Ravesteijn - TNW
>Author: vfr >Date: Thu Jul 16 10:39:22 2009 >New Revision: 30624 >URL: http://www.lyx.org/trac/changeset/30624 > >Log: >Fix the enabling of the custom page size field in GuiDocument. > >Modified: > lyx-devel/trunk/src/frontends/qt4/GuiDocument.cpp > lyx-devel/trunk/src/frontends/qt4/GuiDocumen

Re: Approaching LyX 1.6.4 [status update #1]

2009-07-16 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller writes: > If your colleague is fine with 1.6.3: fine. Why not? +1 JMarc