[patch] Finishing cs26547 (Move NOCITE to the end)

2008-10-24 Thread Vincent van Ravesteijn
Richard, You moved NOCITE to the end of citeStylesArray, but you forgot to do the same with citeCommand and CiteStyle. As a consequence, at least GuiCitation Dialog didn't show the correct style. http://www.lyx.org/trac/changeset/26547/ Move NOCITE to the end of the enum, so that it will appear

Re: Exporting problems

2008-10-24 Thread PeerLynt
>> There were some changes to htlatex-based export that were supposed to >> improve the situation on Windows. Maybe not >> > >rh > > AFAIK HTML export has not been changed. OpenDocument export has been broken > on Windows for a long time but > works now after updating MiKTeX. Unfortun

Re: [patch] Bug 5166

2008-10-24 Thread Uwe Stöhr
Vincent van Ravesteijn schrieb: without the typo.. thanks, it's in. regards Uwe

Re: scrclass.inc patch

2008-10-24 Thread Guenter Milde
José Matos <[EMAIL PROTECTED]> schrieb: > On Friday 24 October 2008 14:34:50 Jürgen Spitzmüller wrote: >> I'm not sure about this. After all, "Labeling" is the name which is to be >> found in the KOMA documentation. > On one hand we should follow the upstream naming scheme, on the other > hand we

Re: [patch] Bug 5166

2008-10-24 Thread Vincent van Ravesteijn
without the typo.. Index: src/Text3.cpp === --- src/Text3.cpp (revision 27090) +++ src/Text3.cpp (working copy) @@ -1414,6 +1414,9 @@ doInsertInset(cur, this, cmd, true, true); cur.posForward(); + // If some text is moved into

Re: [patch] Bug 5166

2008-10-24 Thread Vincent van Ravesteijn
On Fri, 2008-10-24 at 22:57 +0200, Uwe Stöhr wrote: > Your patch work and I have comitted it: > http://www.lyx.org/trac/changeset/27090 > > > + if (content) > > + cur.backwardPos(); > > Things like this should be documented in the code by comments (why do we do > what

Re: [patch] Bug 5166

2008-10-24 Thread Uwe Stöhr
Your patch work and I have comitted it: http://www.lyx.org/trac/changeset/27090 > + if (content) > + cur.backwardPos(); Things like this should be documented in the code by comments (why do we do what?). thanks and regards Uwe

Re: [PATCH] Re: SubFigure conversion error

2008-10-24 Thread rgheck
Jürgen Spitzmüller wrote: rgheck wrote: I've got a working patch where lyx2lyx writes an empty caption inset. Patch is attached. We could omit the caption inset altogether if we wanted, but will LyX accept that? What is the output? I think it should look as comparable as possible. I.e.

Re: LyX version 1.6.0 (release candidate 4) is released

2008-10-24 Thread Joost Verburg
José Matos wrote: Prebuilt binaries (rpms for linux distributions, Mac OS X and Windows installers) should soon be available at ftp://ftp.devel.lyx.org/pub/lyx/devel/ I've uploaded Windows installers and a new dependency package to http://www.lyx.org/~joost/ . Can you move the installer

Problem with Mac-Key-Symbols (MUSTFIX)

2008-10-24 Thread Konrad Hofbauer
I am a bit in a hurry now, but: In rc4 the UserGuide does not compile on the Mac because it uses InsetInfo->Shortcuts which outputs the pretty unicode symbols ⌘⌥⇧, but for which no Latex equivalent is there. I proposose: *** For LyX 1.6.0 *** The attached patch. Quick and dirty, but does the

Re: [patch] Bug 5166

2008-10-24 Thread Pavel Sanda
Vincent van Ravesteijn wrote: > Patch to solve bug 5166. > > doInsertInset has the behaviour to put the cursor inside the new inset > when there was no selection, thus when the new inset is empty. If there > was a selection, the cursor is put outside the inset. > > cur.backwardPos() puts the curs

Re: [patch] Solving selection painting bugs

2008-10-24 Thread Pavel Sanda
José Matos wrote: > On Thursday 23 October 2008 20:20:13 Vincent van Ravesteijn wrote: > > Jose, I hope I'm not too late for 1.6 :S... Otherwise I'll have to make > > it smell like a major bug fix.. > > For rc4 certainly it is late. :-) > > For it to be applied to 1.6.0 I would like to hear from

Re: [patch] Bug 5399

2008-10-24 Thread Pavel Sanda
Vincent van Ravesteijn wrote: > > Looks good if completeBaseName is doing what it suggests. > > > > Stefan > > > > > > Unless you load newfile2.lyx.emergency... then it's wrong. this is visible in title and its still better then the previous version. it has two ok's, i commited it. pavel

Re: Patch for 5310

2008-10-24 Thread Abdelrazak Younes
On 24/10/2008 17:50, Jean-Marc Lasgouttes wrote: Abdelrazak Younes<[EMAIL PROTECTED]> writes: After thinking more about it and trying it out I think now it is the right solution. This code was needed when we were iterating with the full cursor (not the top slice). Alfredo missed this when h

Re: About the documentation files - again

2008-10-24 Thread Jean-Marc Lasgouttes
José Matos <[EMAIL PROTECTED]> writes: >> I propose to do it now nevertheless. Here is what it would look like. >> >> Jose'? > > OK. Done. JMarc

Re: Patch for 5310

2008-10-24 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> After thinking more about it and trying it out I think now it is the >> right solution. This code was needed when we were iterating with the >> full cursor (not the top slice). Alfredo missed this when he rewrite the >> code last year. >> > ACK.

Re: Patch for 5310

2008-10-24 Thread Jean-Marc Lasgouttes
José Matos <[EMAIL PROTECTED]> writes: > On Friday 24 October 2008 16:29:22 Jean-Marc Lasgouttes wrote: >> Jose'? > > OK. Applied. JMarc

Re: [PATCH] show changes when merging and another change tracking bug

2008-10-24 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: >>> It makes sure that the BufferView is updated after doing findNextChange. >>> Abdel, is it how it is supposed to be done? >>> > Yes. OK, applied. JMarc

Re: About the documentation files - again

2008-10-24 Thread José Matos
On Friday 24 October 2008 11:08:48 Jean-Marc Lasgouttes wrote: > Pavel Sanda <[EMAIL PROTECTED]> writes: > > unfortunately i was not able to finish it before rc4. since it is not bug > > i postpone this to 1.7 otherwise we can damage makefiles for 1.6.0... > > I propose to do it now nevertheless. H

Re: scrclass.inc patch

2008-10-24 Thread José Matos
On Friday 24 October 2008 14:34:50 Jürgen Spitzmüller wrote: > I'm not sure about this. After all, "Labeling" is the name which is to be > found in the KOMA documentation. It would be nice to have some kind of additional information (like a tooltip) when selecting the different layouts. On one h

Re: Patch for 5310

2008-10-24 Thread Abdelrazak Younes
On 24/10/2008 17:29, Jean-Marc Lasgouttes wrote: Jean-Marc Lasgouttes<[EMAIL PROTECTED]> writes: Then a more annoying problem occurs: in findnextChange, we have the code // avoid crash (assertion violation) if the imaginary end-of-par // character of the last paragraph of

Re: Patch for 5310 (was: Re: [PATCH] show changes when merging and another change tracking bug)

2008-10-24 Thread José Matos
On Friday 24 October 2008 16:29:22 Jean-Marc Lasgouttes wrote: > Jose'? OK. > JMarc -- José Abílio

Re: RC4.1?

2008-10-24 Thread José Matos
On Friday 24 October 2008 16:35:08 Jean-Marc Lasgouttes wrote: > BTW you did not announce rc4 on the web site. The single reason was a busy schedule. I would not mind (I would appreciate) if someone beat me announcing it. > JMarc -- José Abílio

Re: RC4.1?

2008-10-24 Thread José Matos
On Friday 24 October 2008 16:33:41 Richard Heck wrote: > It's entirely up to you. It's an easy fix for users to make themselves, > and if RC5 will be out next week, I have no problem waiting. The easy fix part was the main reason to suggest postpone the release. > rh -- José Abílio

Re: [PATCH] show changes when merging and another change tracking bug

2008-10-24 Thread Abdelrazak Younes
On 24/10/2008 17:06, Jean-Marc Lasgouttes wrote: Jean-Marc Lasgouttes<[EMAIL PROTECTED]> writes: The following patch is related to bug 5310 http://bugzilla.lyx.org/show_bug.cgi?id=5310 It makes sure that the BufferView is updated after doing findNextChange. Abdel, is it how it is supposed

Re: RC4.1?

2008-10-24 Thread Jean-Marc Lasgouttes
José Matos <[EMAIL PROTECTED]> writes: > I intend to release rc5 next week as an intermediate release before 1.6.0 can > not this wait? I agree. BTW you did not announce rc4 on the web site. JMarc

Re: RC4.1?

2008-10-24 Thread Richard Heck
José Matos wrote: On Friday 24 October 2008 13:31:38 rgheck wrote: A stupid mistake on my part has made article (AMS) and book (AMS) fail in RC4. When I converted the layout files to the format 11, I overwrote the changes to those ones before doing so. This is fixed at r27081. We should perh

Re: RC4.1?

2008-10-24 Thread José Matos
On Friday 24 October 2008 13:31:38 rgheck wrote: > A stupid mistake on my part has made article (AMS) and book (AMS) fail > in RC4. When I converted the layout files to the format 11, I overwrote > the changes to those ones before doing so. This is fixed at r27081. > > We should perhaps release RC4

Patch for 5310 (was: Re: [PATCH] show changes when merging and another change tracking bug)

2008-10-24 Thread Jean-Marc Lasgouttes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > Then a more annoying problem occurs: in findnextChange, we have the code > > // avoid crash (assertion violation) if the imaginary end-of-par > // character of the last paragraph of the document is marked as changed > if (tip.at_

Re: [PATCH] show changes when merging and another change tracking bug

2008-10-24 Thread Jean-Marc Lasgouttes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > The following patch is related to bug 5310 > http://bugzilla.lyx.org/show_bug.cgi?id=5310 > > It makes sure that the BufferView is updated after doing findNextChange. > Abdel, is it how it is supposed to be done? Oops. svndiff src Index: src/Bu

[PATCH] show changes when merging and another change tracking bug

2008-10-24 Thread Jean-Marc Lasgouttes
The following patch is related to bug 5310 http://bugzilla.lyx.org/show_bug.cgi?id=5310 It makes sure that the BufferView is updated after doing findNextChange. Abdel, is it how it is supposed to be done? Then a more annoying problem occurs: in findnextChange, we have the code // avoid

Re: Exporting problems

2008-10-24 Thread Joost Verburg
rgheck wrote: [EMAIL PROTECTED] wrote: Dear list, I do have two difficulties with RC4 while exporting. Firstly, exporting any sort of text to html (ws word) makes lyx freeze. Secondly, exporting to opendocument produces an empty document. I am using RC4 on Windows Vista. There were some c

Re: scrclass.inc patch

2008-10-24 Thread Jürgen Spitzmüller
Guenter Milde wrote: > -Style Labeling > +# KOMA Script provides 'labeling' with the features of 'lyxlist' > +Style List I'm not sure about this. After all, "Labeling" is the name which is to be found in the KOMA documentation. Jürgen

Re: [PATCH] Re: SubFigure conversion error

2008-10-24 Thread Jürgen Spitzmüller
rgheck wrote: > I've got a working patch where lyx2lyx writes an empty caption inset. > Patch is attached. We could omit the caption inset altogether if we > wanted, but will LyX accept that? What is the output? I think it should look as comparable as possible. I.e., if the 1.5 document outputted

Re: Exporting problems

2008-10-24 Thread rgheck
[EMAIL PROTECTED] wrote: Dear list, I do have two difficulties with RC4 while exporting. Firstly, exporting any sort of text to html (ws word) makes lyx freeze. Secondly, exporting to opendocument produces an empty document. I am using RC4 on Windows Vista. There were some changes to ht

Re: 1.6.0rc4 amsart could not be loaded

2008-10-24 Thread rgheck
Neal Becker wrote: I just tried opening one of my docs. I'm pretty sure this didn't happen with 1.6.0rc3: TextClass.cpp(599): Error: Textclass 'amsart' is missing a defaultstyle. Error reading `[layouts/amsart.layout]' (Check `amsart') Check your installation and try Options/Reconfigure... Err

RC4.1?

2008-10-24 Thread rgheck
A stupid mistake on my part has made article (AMS) and book (AMS) fail in RC4. When I converted the layout files to the format 11, I overwrote the changes to those ones before doing so. This is fixed at r27081. We should perhaps release RC4.1. rh -- --- Richard G Heck Jr

[PATCH] Re: SubFigure conversion error

2008-10-24 Thread rgheck
Jürgen Spitzmüller wrote: rgheck wrote: One of our users has had a problem converting certain documents into 1.6. Turns out these are documents that have subfigures but NO subcaption. Right now, lyx2lyx throws an error in this case. It's easy to fix this, but what should we do? Can we just om

Exporting problems

2008-10-24 Thread PeerLynt
Dear list, I do have two difficulties with RC4 while exporting. Firstly, exporting any sort of text to html (ws word) makes lyx freeze. Secondly, exporting to opendocument produces an empty document. I am using RC4 on Windows Vista. best regards and thanks alot for this wonderful software. p

scrclass.inc patch

2008-10-24 Thread Guenter Milde
The following patch to scrclass.inc provides a better coherence between KOMA- and non-KOMA classes. Advantages: * Uniform GUI names (no need to translate Labeling) * Prevent hard to find error if a Style in a module uses CopyStyle List (with document-class set to one of the K

Crosscompile Lyx for Windows on Linux (Gentoo)

2008-10-24 Thread Matthias Coy
Hi there, I'm new to that topic, so, has anyone tried that yet? Any help, suggestions or links would be appreciated. Regards Matthias Coy

Re: Failed test on make distcheck

2008-10-24 Thread Enrico Forestieri
On Fri, Oct 24, 2008 at 09:37:41AM +0200, Abdelrazak Younes wrote: > Nope, I would just test the difference to be less than 'epsilon' > instead. And 'epsilon = 1e-307' for a double IIRC. You don't recall correctly. That is the smallest number representable with a double. The precision epsilon is

Re: [patch]: fix tabular crash in branch

2008-10-24 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: > Helge Hafting wrote: >> Perhaps something like [tabular lost!] or >> [tabular paste currently unsupported], >> so the user won't wonder what went wrong. > > I really wouldn't paste error messages into a document. OK then. I thought we did something

Re: About the documentation files - again

2008-10-24 Thread Jean-Marc Lasgouttes
Pavel Sanda <[EMAIL PROTECTED]> writes: > unfortunately i was not able to finish it before rc4. since it is not bug > i postpone this to 1.7 otherwise we can damage makefiles for 1.6.0... I propose to do it now nevertheless. Here is what it would look like. Jose'? JMarc svndiff Index: developm

Re: [patch]: fix tabular crash in branch

2008-10-24 Thread Jürgen Spitzmüller
Helge Hafting wrote: > Perhaps something like [tabular lost!] or > [tabular paste currently unsupported], > so the user won't wonder what went wrong. I really wouldn't paste error messages into a document. Jürgen

Re: [patch]: fix tabular crash in branch

2008-10-24 Thread Helge Hafting
Jürgen Spitzmüller wrote: Jean-Marc Lasgouttes wrote: So I just let Cursor::selectionAsString return an empty docstring() with multi-cell selection. This breaks middle mouse pasting. Why not return something like "[tabular]" instead? Hm would you really want this? Perhaps something like [ta

1.6svn: edit button gone from "external inset" dialog?

2008-10-24 Thread Helge Hafting
Is this on purpose? I only get a "browse" button now. So I can select existing files. And I can edit _existing_ files using the context menu. But how am I supposed to create a _new_ xfig figure these days? Creating the inset, then closing the dialog and using "edit" from the context menu is more

Re: [patch]: fix tabular crash in branch

2008-10-24 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > > So I just let Cursor::selectionAsString return an empty docstring() > > with multi-cell selection. This breaks middle mouse pasting. > > Why not return something like "[tabular]" instead? Hm would you really want this? Jürgen

Re: external xfig inset broken in 1.6svn?

2008-10-24 Thread Helge Hafting
Looks like this error was transient. Other old documents are fine, and so is new xfig figures I make. Helge Hafting

Re: [patch]: fix tabular crash in branch

2008-10-24 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: > So I just let Cursor::selectionAsString return an empty docstring() > with multi-cell selection. This breaks middle mouse pasting. Why not return something like "[tabular]" instead? JMarc

Re: 1.6svn bug: open an included file, and the containing file gets "changed"?

2008-10-24 Thread Helge Hafting
Jean-Marc Lasgouttes wrote: Helge Hafting <[EMAIL PROTECTED]> writes: Now, editing the child document may change the whole of it, so that view->pdf and friends need to recompile and can't use cached dvi files and such. A cross reference to something in the subdocument might change, perhaps. Tha

[patch]: fix tabular crash in branch

2008-10-24 Thread Jürgen Spitzmüller
As you can reproduce with the attached test case, branch crashes if you select all the cells starting from the last cell ending up in the first. The reason is that Cursor::selectionAsString does not handle multiple cell selection and mixes the cursor positions in the starting and ending cells (r

SubFigure LaTeX error

2008-10-24 Thread Guenter Milde
I really like the new way to insert SubFigures. However, I had a bad surprise when I tried to look at the LaTeX output - uncomprehensible errors about missing (or spurious) endgroups appeared. It turned out that I must not put any ERTs with \psfraq replacements inside the sub-figure float. Moving

Re: SubFigure conversion error

2008-10-24 Thread Jürgen Spitzmüller
rgheck wrote: > One of our users has had a problem converting certain documents into > 1.6. Turns out these are documents that have subfigures but NO > subcaption. Right now, lyx2lyx throws an error in this case. It's easy > to fix this, but what should we do? Can we just omit the caption? Should >

rc4-Mac app filenaming

2008-10-24 Thread Konrad Hofbauer
Hi Bennett, thanks for creating the Mac-binary! Just a cosmetic thing, but should be fixed for the final release: In the new rc4-Mac-Universal.dmg, the included lyx-1.6.0rc4.app has LyX in lowercase spelling (and this is also how it will show up everywhere in the operating system). Do you c

Re: Failed test on make distcheck

2008-10-24 Thread Abdelrazak Younes
On 24/10/2008 09:30, José Matos wrote: Yesterday while running the update procedure I got one test failed. The fail happens in convert where a double is converted to a string. The double is 1.1. The test fails because 1.1 is converted to 1.11 (I am typing this by heart so I am not su

Re: LyX version 1.6.0 (release candidate 4) is released

2008-10-24 Thread Konrad Hofbauer
Bennett Helm wrote: I've put the Mac binary here: http://edisk.fandm.edu/bennett.helm/LyX/LyX-1.6.4RC4-Mac-Universal.dmg Bennett: Looks good after a quick test. José: Will you make an announcement on the website as well (News)? Always fun seeing the activity bursts when you start swinging the

Failed test on make distcheck

2008-10-24 Thread José Matos
Yesterday while running the update procedure I got one test failed. The fail happens in convert where a double is converted to a string. The double is 1.1. The test fails because 1.1 is converted to 1.11 (I am typing this by heart so I am not sure how many zeros there are). This hap