Re: [patch] fix bugs 3242 and 4233

2007-09-23 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > @@ -353,7 +367,10 @@ > innerBoxCO->clear(); > innerBoxCO->addItem(qt_("Parbox")); > innerBoxCO->addItem(qt_("Minipage")); > -   innerBoxCO->setCurrentIndex(i - 1); > +   if (i != 0) > +   

Re: [patch] fix bugs 3242 and 4233

2007-09-23 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > The problem was that we set a height as second optional argument for plain > minipages and parboxes, but they only have one optional argument. Only when > there is a decoration box around it, a second argument can be used. You say that parboxes and minipages only have one option

Re: [patch] fix lyx2lyx bug 2995

2007-09-23 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > José, Jürgen, OK for branch? I don't think this is the correct approach. The error you see is not bound to a specific LyX version, you can also produce it with LyX 1.5: - insert a table - make a cell of fixed width with some content - Edit->Paragraph->Center - remove fixed wid

Re: Index as flex inset

2007-09-23 Thread Martin Vermeer
On Sun, Sep 23, 2007 at 06:06:23AM +0300, Martin Vermeer wrote: > On Sat, Sep 22, 2007 at 06:49:34PM +0200, Jürgen Spitzmüller wrote: > > Martin Vermeer wrote: > > > Actually have a look at the attached. I somewhat changed my mind since > > > the previous reply: what is inside an index inset is rea

Re: Compile failure 1.6 svn, missing FloatList.cpp

2007-09-23 Thread Martin Vermeer
On Mon, Sep 24, 2007 at 12:09:07AM +0200, Helge Hafting wrote: > make[1]: Entering directory `/usr/src/lyx-devel/src/tex2lyx' > make PCH_FLAGS= pch-file > make[2]: Entering directory `/usr/src/lyx-devel/src/tex2lyx' > g++ -DHAVE_CONFIG_H -DTEX2LYX -I../../src/tex2lyx -I../../src > -I../../src

Re: InsetCommand[Params]

2007-09-23 Thread Richard Heck
In the end, I don't think this will be needed. But yes, the serialization here is a hassle, and it's sheer luck that it isn't a problem. How would an optimal/a better solution look like in your opinion? [Serious question] Well, there are advantages to the serialization. I can't remember

[patch] fix lyx2lyx bug 2995

2007-09-23 Thread Uwe Stöhr
The attached patch fixes http://bugzilla.lyx.org/show_bug.cgi?id=2995 Documents with centered tables are wrongly converted to LyX 1.4's and newer file formats. The resulting files are unusable as they produce LaTeX-errors. The problem was that the \align tags within tables were not removed in t

Compile failure 1.6 svn, missing FloatList.cpp

2007-09-23 Thread Helge Hafting
make[1]: Entering directory `/usr/src/lyx-devel/src/tex2lyx' make PCH_FLAGS= pch-file make[2]: Entering directory `/usr/src/lyx-devel/src/tex2lyx' g++ -DHAVE_CONFIG_H -DTEX2LYX -I../../src/tex2lyx -I../../src -I../../src -Wextra -Wall -g -Os -x c++-header -fPIC -DPIC ./pch.h -o ./pch.h.g

[patch] fix bugs 3242 and 4233

2007-09-23 Thread Uwe Stöhr
The attached patch fixes: http://bugzilla.lyx.org/show_bug.cgi?id=3242 and http://bugzilla.lyx.org/show_bug.cgi?id=4233 The problem was that we set a height as second optional argument for plain minipages and parboxes, but they only have one optional argument. Only when there is a decoration box

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-23 Thread Pavel Sanda
> It does, I put it in. thanks > (I don't understand what the "x" does.) it represents default hyperref settings. good night :) pavel

Re: InsetCommand[Params]

2007-09-23 Thread Andre Poenitz
On Sun, Sep 23, 2007 at 03:57:52PM -0400, Richard Heck wrote: > Andre Poenitz wrote: > >>The bad news is that this change will require one controller class for > >>each > >>inset. Currently there is only one command controller, used by all command > >>insets. That is the only reason I did not do t

Re: [patch] fix bug 2931: add missing optional parameters for wrapfig

2007-09-23 Thread Uwe Stöhr
Uwe Stöhr schrieb: The attached patch add the optional parameters "lines" and "overhang" for wrap figures. Here's a better one where the lengths are validated. regards Uwe Index: development/FORMAT === --- development/FORMAT (rev

Re: InsetCommand[Params]

2007-09-23 Thread Richard Heck
Andre Poenitz wrote: The bad news is that this change will require one controller class for each inset. Currently there is only one command controller, used by all command insets. That is the only reason I did not do this change already during the InsetCommandParams rewrite. So again an ins

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-23 Thread Uwe Stöhr
Pavel Sanda schrieb: the following patch should correct this. It does, I put it in. (I don't understand what the "x" does.) regards Uwe

obsolete files in SVN's /development folder

2007-09-23 Thread Uwe Stöhr
In SVN's trunk development folder are some obsolete file. I guess "TodoPlan-1.3" and "boostworkaround.txt" can be removed. What else do you think is not needed anymore? regards Uwe

Layout counter/label help

2007-09-23 Thread Paul A. Rubin
I'm trying to hack the AMS layouts to display a list environment with items numbered "Case 1:", "Case 2:", ... The LaTeX is done but I'm stuck on the GUI side. If I use LabelType Enumerate, numbering in the GUI is correct (the first item is #1 each time the environment is used, and subsequent

Re: current_font in ERT insets

2007-09-23 Thread Dov Feldstern
Martin Vermeer wrote: On Sun, Sep 23, 2007 at 02:43:02AM +0200, Dov Feldstern wrote: Attached find a patch which fixes this issue. The actual fix is what's being done in the LFUN_FINISHED_* lfuns. The fixes in cursorLeft and cursorRight aren't relevant to the problem we're dealing with,

Re: r20422 --- RTL fix

2007-09-23 Thread Dov Feldstern
Abdelrazak Younes wrote: Dov Feldstern wrote: Hi, Abdel! I appreciate it that you're trying to keep your eye out for RTL issues! Unfortunately, in this case I think that the fix is wrong --- it does more harm than good. Attached is a patch to reverse this changeset OK, I now understand wh

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-23 Thread Pavel Sanda
>> - Minor: when the colorlinks option is set, the option no frames should >> also be set since colorlinks does the same as the no frame option > > Perhaps implementing this only confuses people. So we can leave it as it is agreed > > its rather minor issue - when the user temporarily switch of

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-23 Thread Andre Poenitz
On Sat, Sep 22, 2007 at 03:07:03AM +0200, Pavel Sanda wrote: > > Pavel Sanda schrieb: > > > >> btw disagreement with your last fix > >> - opt += (pdfborder ?'1':'0'); + opt += (pdfborder ?'0':'1'); > >> havent tried but expect it will break elsewhere and also reverts the > >> semantic

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-23 Thread Andre Poenitz
On Fri, Sep 21, 2007 at 11:38:54AM -0400, Richard Heck wrote: > Pavel Sanda wrote: > >>>1. view source dialog is still broken (Can not update). Can anyone fix > >>>it? > >>> > >>i will look. > >> > > > >ahh, i misread your post thinking that pdf stuff broke source dialog, > >which is no

Re: Installing libraries (was: Re: Small puzzle.)

2007-09-23 Thread Andre Poenitz
On Fri, Sep 21, 2007 at 03:51:26PM +0200, Enrico Forestieri wrote: > On Fri, Sep 21, 2007 at 02:13:55AM +0200, Andre Poenitz wrote: > > > On Thu, Sep 20, 2007 at 02:23:28PM +0200, Enrico Forestieri wrote: > > > > What about deciding that we do not install the libraries? Of course, > > > > this wou

Re: Small puzzle.

2007-09-23 Thread Andre Poenitz
On Fri, Sep 21, 2007 at 12:19:47PM +0200, Helge Hafting wrote: > Andre Poenitz wrote: > >Little puzzle for you: > > > >What belongs together? > > > >Configurations: > > > > (A) current svn, --enable-pch > > (B) current svn, --disable-pch > > > At some point, pch defaulted to on, and it broke the

Re: InsetCommand[Params]

2007-09-23 Thread Andre Poenitz
On Fri, Sep 21, 2007 at 11:59:56AM +0200, Georg Baum wrote: > Richard Heck wrote: > > > The change should be fairly simple, both in the code and in lyx2lyx: > > It's mostly a matter of file format, not so much of internal > > representation. Internal code concerned with writing and reading will be

Re: r20422 --- RTL fix

2007-09-23 Thread Abdelrazak Younes
Dov Feldstern wrote: Hi, Abdel! I appreciate it that you're trying to keep your eye out for RTL issues! Unfortunately, in this case I think that the fix is wrong --- it does more harm than good. Attached is a patch to reverse this changeset OK, I now understand what was the problem and modi

new wiki page for SVN crashes and regressions

2007-09-23 Thread Uwe Stöhr
LyX 1.6svn has become unusable very quickly after the feature freeze has gone. I created a wiki list with the current regressions and crashes: http://wiki.lyx.org/Devel/RegressionListSVN (please add there other regressions and crashes) My proposal: To keep SVN in a more or less usable state, it w

Re: [Patch#4] Bug 3527 - Basic PDF support via hyperref

2007-09-23 Thread Uwe Stöhr
As last missing piece for now, I fixed the lyx2lyx stuff: You forgot to increase the fileformat. Therefore you didn't see that your lyx2lyx routine don't work. I fixed now both: http://www.lyx.org/trac/changeset/20448 regards Uwe

[patch] fix bug 2931: add missing optional parameters for wrapfig

2007-09-23 Thread Uwe Stöhr
The attached patch add the optional parameters "lines" and "overhang" for wrap figures. It furthermore fixes a current bug that the placement option was not predefined: Since we changed to wrapfig from floatflt, the placement is now mandatory and must not be empty. I tested it carefully, also

Re: [Cvslog] r20366 - in /lyx-devel/trunk: lib/bind/cua.bind src/LyXAc...

2007-09-23 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: I understand that there are very advanced use of PS but please think about the typical end-user. If we recommend him/she to use PDFLateX then it's only natural to make the view/update binding defaulting to that, don't you think? A typical end

Re: [Cvslog] r20366 - in /lyx-devel/trunk: lib/bind/cua.bind src/LyXAc...

2007-09-23 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > I understand that there are very advanced use of PS but please think > about the typical end-user. If we recommend him/she to use PDFLateX then > it's only natural to make the view/update binding defaulting to that, > don't you think? A typical end user might use the pow

Re: [Cvslog] r20366 - in /lyx-devel/trunk: lib/bind/cua.bind src/LyXAc...

2007-09-23 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Postscript is pretty useless nowadays /me thinks... You don't use pstricks or any other postscript specials, do you? No, I use LyX "as-is" as do most LyX users I reckon ;-) I understand that there are very advanced use of PS but please thin

Re: [Cvslog] r20366 - in /lyx-devel/trunk: lib/bind/cua.bind src/LyXAc...

2007-09-23 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > Postscript is pretty useless nowadays /me thinks... You don't use pstricks or any other postscript specials, do you? Jürgen

Re: r20422 --- RTL fix

2007-09-23 Thread Abdelrazak Younes
Dov Feldstern wrote: Hi, Abdel! I appreciate it that you're trying to keep your eye out for RTL issues! Unfortunately, in this case I think that the fix is wrong --- it does more harm than good. Attached is a patch to reverse this changeset Could you explain me how it makes things worse? Th

Re: [Cvslog] r20366 - in /lyx-devel/trunk: lib/bind/cua.bind src/LyXAc...

2007-09-23 Thread Abdelrazak Younes
Bennett Helm wrote: Notice, however, that I've changed master-buffer-view ps to master-buffer-view pdf (and same for ...-update). That's consistent with other bindings in mac.bind, such as C-t being bound to buffer-view pdf. Could the various Windows packagers do the same? Postscript is prett