Re: explicit destruction and placement new

2004-11-23 Thread Martin Vermeer
On Tue, 2004-11-23 at 18:49, Andreas Vox wrote: > I think all of us would like to have a shiny, bugfree 1.4 release of LyX > as soon as possible (say for Christmas), but currently it looks as if there's > not enough man power to reach that goal. Actually it looks a lot better already than just

[Patch] Change priv_dispatch to doDispatch

2004-11-23 Thread Lars Gullik Bjønnes
Just to get this going bit by bit. Index: lfuns.h === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/lfuns.h,v retrieving revision 1.37 diff -u -p -B -b -w -r1.37 lfuns.h --- lfuns.h 22 Oct 2004 10:24:55 - 1.37 +++ lfuns.h 24 Nov

Re: [patch] fix multicolumn handling in tables

2004-11-23 Thread Alfredo Braunstein
Georg Baum wrote: > +CursorSlice::idx_typeÂconstÂsel_cell_startÂ= > cur.selBegin().idx(); > +CursorSlice::idx_typeÂconst > sel_cell_endÂ=Âcur.selEnd().idx(); > +//ÂFIXME:ÂIsÂthis > reallyÂnecessary? +//ÂIÂwouldÂthinkÂthat > +ÂÂÂ

[patch] fix multicolumn handling in tables

2004-11-23 Thread Georg Baum
The attached patch seems to put multicolumn handling into a workable state again. Is it really that simple? I would appreciate it if somebody could answer the FIXME question. Georg diff -p -r -U 3 -X excl.tmp lyx-1.4-clean/src/insets/ChangeLog lyx-1.4-cvs/src/insets/ChangeLog --- lyx-1.4-clean/

Re: lyx-devel src/frontends/gtk/: ChangeLog GWorkArea.C

2004-11-23 Thread John Spray
On Tue, 2004-11-23 at 15:18 +0100, Georg Baum wrote: > 2004-11-22 Georg Baum <[EMAIL PROTECTED]> > > * GSendto.C: Disable concept checks (see below) > + > + 2004-11-22 John Spray <[EMAIL PROTECTED]> > + > * GWorkArea.C: Set small scrolling interval to 3*lineheight >

Re: explicit destruction and placement new

2004-11-23 Thread Lars Gullik Bjønnes
Andreas Vox <[EMAIL PROTECTED]> writes: | I don't know if you two get along when drinking beer or if you are sitting | at opposite ends of the table then also, beer bottles are nice blunt instruments. We actually get a long pretty well. | but it surely gives bad vibrations | to read posts lik

Re: explicit destruction and placement new

2004-11-23 Thread Angus Leeming
Andreas Vox wrote: > I don't know if you two get along when drinking beer or if you are > sitting at opposite ends of the table then also, but it surely gives > bad vibrations to read posts like this on the list. When drinking beer they seem to get on fine, so long as they are both at the same en

Re: explicit destruction and placement new

2004-11-23 Thread Andreas Vox
Lars Gullik BjÃnnes <[EMAIL PROTECTED]> writes: < Andre Poenitz <[EMAIL PROTECTED]> writes: < < | To be even more blunt: This kind of work does not help us to get 1.4.0 < | out of the door. The small good it does is outweighed by distracting < | people as seen e.g. in the XML discussion. <

Re: [patch] fix crash in mathhullinset

2004-11-23 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > What does not work for example? My limited testing seemd to work... - start lyx with -dbg action - create new document - create an empty formula - place cursor to the left of the formula - Press M-m n You get LyXFunc::dispatch: math-number [109] is disabled at this

Re: [patch] fix crash in mathhullinset

2004-11-23 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Jean-Marc Lasgouttes wrote: >> You are right, of course. Here is the patch I came up with, where I >> included your fix. I think things look cleaner this way. Comments? Georg> Looks clean, but does not work :-(( I believe that the mes

Re: coord branch - looks good

2004-11-23 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | They are mostly inter-dependant. ok > | I've tried to apply already bugfixes that were present identically in head. > >> (If at all possible it would be best if we could move it back to head >> bit by bit, and so that smaller parts can be review

Re: [patch] fix crash in mathhullinset

2004-11-23 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > You are right, of course. Here is the patch I came up with, where I > included your fix. I think things look cleaner this way. Comments? Looks clean, but does not work :-(( I believe that the message is overwritten by some other getStatus methods that are called from

Re: lyx-devel src/frontends/gtk/: ChangeLog GWorkArea.C

2004-11-23 Thread Georg Baum
John Spray wrote: > What's wrong with it? 2004-11-22 Georg Baum <[EMAIL PROTECTED]> * GSendto.C: Disable concept checks (see below) + + 2004-11-22 John Spray <[EMAIL PROTECTED]> + * GWorkArea.C: Set small scrolling interval to 3*lineheight as opposed to

Re: [PATCH] Safer inset hierarchy

2004-11-23 Thread Martin Vermeer
On Tue, 2004-11-23 at 15:03, Alfredo Braunstein wrote: > Lars Gullik BjÃnnes wrote: > > > This patch adds NVI for the clone function, adds some guards on its > > usage. > > > > Also I try to make sure that we use and call insets in a uniform way. > > (through pointers mainly, to avoid slicing) >

Re: [patch] fix crash in mathhullinset

2004-11-23 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> We still have the return statements in addRow() etc, so we Georg> don't get a crash. But I think we do not need to provide error Georg> diagnostics for this case (or if we do, we should provide them Georg> always). I am going to apply

Re: [PATCH] Safer inset hierarchy

2004-11-23 Thread Alfredo Braunstein
Lars Gullik BjÃnnes wrote: > This patch adds NVI for the clone function, adds some guards on its > usage. > > Also I try to make sure that we use and call insets in a uniform way. > (through pointers mainly, to avoid slicing) What's slicing? Alfredo

Re: help debugging CoordBranch

2004-11-23 Thread Alfredo Braunstein
Alfredo Braunstein wrote: >> The situation is better now, but not perfect. Look for example at what >> happens when using find/replace or spellcheck. Cursor size is not > > Right. The fix was to replace manual adjustment of cur.pit, cur.pos with a > call to setCursor that does that + DEPM + setCu

Re: lyx-devel src/frontends/gtk/: ChangeLog GWorkArea.C

2004-11-23 Thread John Spray
Georg Baum wrote: Modified files: lyx-devel/src/frontends/gtk/: ChangeLog GWorkArea.C Log message: tweak scrolling in gtk workarea The Changelog does not look right (it was not me who did this change) ;-) What's wrong with it? John

Re: coord branch - looks good

2004-11-23 Thread Alfredo Braunstein
Lars Gullik BjÃnnes wrote: > I just had a look at the coord branch, I it feels pretty good. > > But i test of over a 11Mbit 802.11b X-forwarded link so it is hard to > get a real feeling. But it feels a bit snappier than head, and several > display bugs seems to be gone. > > What is the status o

Re: help debugging CoordBranch

2004-11-23 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: >> "Alfredo" == Alfredo Braunstein >> <[EMAIL PROTECTED]> writes: > > Alfredo> Jean-Marc Lasgouttes wrote: >>> Where is the relevant code? I guess that real_current_font, which >>> is just a cache is not updated at this point (you get the size of >>> Author par

Re: [patch] fix crash in mathhullinset

2004-11-23 Thread Georg Baum
Jean-Marc Lasgouttes wrote: >> "Georg" == Georg Baum >> <[EMAIL PROTECTED]> >> writes: > > Georg> Andre Poenitz wrote: >>> On Mon, Nov 22, 2004 at 05:12:03PM +0100, Georg Baum wrote: - I assume that we can never enter e.g. addCol() if getStatus returns false for "append-colu

[PATCH] Safer inset hierarchy

2004-11-23 Thread Lars Gullik Bjønnes
This patch adds NVI for the clone function, adds some guards on its usage. Also I try to make sure that we use and call insets in a uniform way. (through pointers mainly, to avoid slicing) Unless you have objection I will apply this. (with one change: a simpler dynamic_cast in tabular.C) nvi-

Re: [patch] fix crash in mathhullinset

2004-11-23 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Andre Poenitz wrote: >> On Mon, Nov 22, 2004 at 05:12:03PM +0100, Georg Baum wrote: >>> - I assume that we can never enter e.g. addCol() if getStatus >>> returns false for "append-column". Therefore I removed the error >>> messages in

Re: help debugging CoordBranch

2004-11-23 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: Alfredo> Jean-Marc Lasgouttes wrote: >> Where is the relevant code? I guess that real_current_font, which >> is just a cache is not updated at this point (you get the size of >> Author paragraph). Alfredo> LCursor::getDim >> So yo

Re: lyx-devel src/frontends/gtk/: ChangeLog GWorkArea.C

2004-11-23 Thread Georg Baum
[EMAIL PROTECTED] wrote: > CVSROOT:  /usr/local/lyx/cvsroot > Module name:  lyx-devel > Repository:   lyx-devel/src/frontends/gtk/ > Changes by:[EMAIL PROTECTED]/11/22 18:44:50 > > Modified files: > lyx-devel/src/frontends/gtk/: ChangeLog GWorkArea.C > > Log message: > tweak scrolling in gtk