Re: booktabs branch

2004-11-11 Thread Juergen Spitzmueller
Georg Baum wrote: > I have created the branch for the booktabs support. The current diff > against HEAD is attached. Cool. I'm already updating. > TODO list: > > 1. Disable changing of vertical rules in the frontends if booktabs are > enabled. The output of vertical rules is already suppressed. >

booktabs branch

2004-11-11 Thread Georg Baum
Jürgen, I have created the branch for the booktabs support. The current diff against HEAD is attached. You can update an existing tree with cvs update -P -r BooktabBranch TODO list: 1. Disable changing of vertical rules in the frontends if booktabs are enabled. The output of vertical rules is

Re: Format hack in client.C

2004-11-11 Thread Georg Baum
Herbert Voss wrote: > I have an image with an unknown format, so LyX returns user. > If I save all these files as *.user then I am able to define > a converter so that all these images can be previewed inside > LyX. which is not possible when '' is returned, if I am not > wrong here. Defining a co

help debugging CoordBranch

2004-11-11 Thread Alfredo Braunstein
I finally had a look at why the xforms frontend is slower than qt in CoordBranch. For some reason, XWorkarea sends every PRESS event inmediately followed by an unexistent RELEASE event, even with wrong coordinates (negatives). THis explains why selection doesn't work in xforms as well... Now, I do

Re: [patch] another off-by-one

2004-11-11 Thread Juergen Spitzmueller
John Spray wrote: > Hmm, I see that num_units is actually the number of units +1.  Why not > fix this in the backend instead, to make the frontend code more obvious? > > - int const num_units = int(sizeof(unit_name) / sizeof(unit_name[0])); > + int const num_units = int(sizeof(unit_name) / sizeof(u

Re: lyx-devel /: Tag: BRANCH_1_3_X status.13x src/: Tag: BRANC ...

2004-11-11 Thread Jürgen Spitzmüller
[EMAIL PROTECTED] wrote: > Modified files: > lyx-devel/: Tag: BRANCH_1_3_X status.13x > lyx-devel/src/: Tag: BRANCH_1_3_X ChangeLog lengthcommon.C > > Log message: > fix off-by-one error (bug 1682) Jean-Marc, I do not think that this is correct. When you enter "4nonsense" into t

VSpace and lengths

2004-11-11 Thread Juergen Spitzmueller
What were again the reasons why we have excluded the %-lengths from VSpace? They certainly work, and IMO at least \textheight is highly sensible. Jürgen

Re: [patch] another off-by-one

2004-11-11 Thread John Spray
On Thu, 2004-11-11 at 12:04 +0100, Juergen Spitzmueller wrote: > This fixes another result of the bug1415-fix (the lengthcombo in qt has an > empty item at the end of its list). - for (int i=0; i < num_units; i++) + for (int i = 0; i < num_units - 1; i++) Hmm, I see that num_units is

[patch] another off-by-one

2004-11-11 Thread Juergen Spitzmueller
This fixes another result of the bug1415-fix (the lengthcombo in qt has an empty item at the end of its list). I'll commit this. Jürgen Index: lengthcombo.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/qt2/lengthcomb

Re: [patch] two fixes

2004-11-11 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: > I do not know actually. I do not have a good understanding of what > 1.3.x did. > > Setting the default font from the context just before computing > metrics is reasonable, since the fonts contained in a paragraph are > always relative to a base font. Therefore, it d

Re: [patch] tfrac

2004-11-11 Thread José Abílio Oliveira Matos
On Thu, Nov 11, 2004 at 09:25:57AM +0100, Alfredo Braunstein wrote: > Should I apply this now? > > Alfredo I think so. Lars only commented the code since André forgot to add those to cvs. -- José Abílio Matos LyX and docbook a perfect match. :-)

[patch] tfrac

2004-11-11 Thread Alfredo Braunstein
Should I apply this now? Alfredo Index: Makefile.am === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/mathed/Makefile.am,v retrieving revision 1.135 diff -u -p -u -r1.135 Makefile.am --- Makefile.am 7 Nov 2004 12:23:55 - 1.135 ++