[lxc-devel] [PATCH] lxc-alpine: allow /dev/full

2013-10-22 Thread Natanael Copa
The template creates /dev/full for the container but needs also give permission to access it. Signed-off-by: Natanael Copa --- templates/lxc-alpine.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/templates/lxc-alpine.in b/templates/lxc-alpine.in index 5fdf36f..8600a34 10

Re: [lxc-devel] [PATCH] lxc-alpine: allow /dev/full

2013-10-22 Thread Serge Hallyn
Quoting Natanael Copa (nc...@alpinelinux.org): > The template creates /dev/full for the container but needs also give > permission to access it. > Acked-by: Serge E. Hallyn > Signed-off-by: Natanael Copa > --- > templates/lxc-alpine.in | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)

[lxc-devel] [lxc/lxc] 6bd3f9: lxc-alpine: allow /dev/full

2013-10-22 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 6bd3f98c469f311f6afbffbb3586efddae3c4eb4 https://github.com/lxc/lxc/commit/6bd3f98c469f311f6afbffbb3586efddae3c4eb4 Author: Natanael Copa Date: 2013-10-22 (Tue, 22 Oct 2013) Changed paths: M templates/lxc

Re: [lxc-devel] [PATCH] umount $rootfs/lib on errors as well otherwise system ends up with stalled mounts

2013-10-22 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): > Hi Serge, > > Then there must be something else going on cause without this patch I find > myself in the situation that I described earlier in this email [1] > > [1] http://sourceforge.net/mailarchive/message.php?msg_id=31539485 Oh - yeah - but it doesn

Re: [lxc-devel] [PATCH] Use actual length of socket's name for abstract sockets

2013-10-22 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): > Hi, > > > On Mon, Oct 21, 2013 at 8:30 PM, Serge Hallyn wrote: > > > Quoting S.Çağlar Onur (cag...@10ur.org): > > > The addrlen parameter should be the actual length of socket's name for > > abstract sockets. Otherwise socket gets padded with NULLs. > >

Re: [lxc-devel] [PATCH] Eliminate duplicate entries from list_active_containers

2013-10-22 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): > Hi, > > > On Mon, Oct 21, 2013 at 8:22 PM, Serge Hallyn wrote: > > > Quoting S.Çağlar Onur (cag...@10ur.org): > > > list_active_containers parses /proc/net/unix which can contain multiple > > entries for the same container; > > > > > > :

Re: [lxc-devel] [PATCH] umount $rootfs/lib on errors as well otherwise system ends up with stalled mounts

2013-10-22 Thread Stéphane Graber
On Tue, Oct 22, 2013 at 11:41:31AM -0500, Serge Hallyn wrote: > Quoting S.Çağlar Onur (cag...@10ur.org): > > Hi Serge, > > > > Then there must be something else going on cause without this patch I find > > myself in the situation that I described earlier in this email [1] > > > > [1] http://sourc

[lxc-devel] [lxc/lxc] 7a409f: lxc-busybox: don't copy temp mounts into mtab

2013-10-22 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 7a409fd5167ecdcbf33a64f1cf9202dc051f0dcf https://github.com/lxc/lxc/commit/7a409fd5167ecdcbf33a64f1cf9202dc051f0dcf Author: Serge Hallyn Date: 2013-10-22 (Tue, 22 Oct 2013) Changed paths: M templates/lxc-

[lxc-devel] Kernel bug? Setuid apps and user namespaces

2013-10-22 Thread Sean Pajot
I've been playing with User Namespaces somewhat extensively and I think I've come across a bug in the handling of /proc/$PID/ entries. This is my example case on a 3.10.x kernel: -- /var/lib/lxc/test1/config lxc.rootfs = /lxc/c1 lxc.id_map = u 0 100 10 lxc.id_map = g 0 100 10 lxc

Re: [lxc-devel] Kernel bug? Setuid apps and user namespaces

2013-10-22 Thread Serge Hallyn
Quoting Sean Pajot (sean.pa...@execulink.com): > I've been playing with User Namespaces somewhat extensively and I think I've > come across a bug in the handling of /proc/$PID/ entries. > > This is my example case on a 3.10.x kernel: > > -- /var/lib/lxc/test1/config > > lxc.rootfs = /lxc/c1 > lx

Re: [lxc-devel] Kernel bug? Setuid apps and user namespaces

2013-10-22 Thread Eric W. Biederman
Serge Hallyn writes: > Quoting Sean Pajot (sean.pa...@execulink.com): >> I've been playing with User Namespaces somewhat extensively and I think I've >> come across a bug in the handling of /proc/$PID/ entries. >> >> This is my example case on a 3.10.x kernel: >> >> -- /var/lib/lxc/test1/config

[lxc-devel] [PATCH] install lua module 0644 instead of 0755

2013-10-22 Thread Dwight Engen
Fixes rpmlint error "script-without-shebang". Checked other lua modules and none are installed with execute permission. Signed-off-by: Dwight Engen --- src/lua-lxc/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lua-lxc/Makefile.am b/src/lua-lxc/Makefile.am in

[lxc-devel] [PATCH] update rpm .spec file

2013-10-22 Thread Dwight Engen
The following changes were made to fix rpmlint warnings/errors - use %global instead of %define http://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define - change Summary to match .deb - update License - do not mention the libcap dependency explicitly, rpm will fill it in - fix S

[lxc-devel] [lxc/lxc] 0adde0: update rpm .spec file

2013-10-22 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 0adde0f84150f14b1eed82f7438e084ba0460329 https://github.com/lxc/lxc/commit/0adde0f84150f14b1eed82f7438e084ba0460329 Author: Dwight Engen Date: 2013-10-22 (Tue, 22 Oct 2013) Changed paths: M lxc.spec.in

Re: [lxc-devel] [PATCH] install lua module 0644 instead of 0755

2013-10-22 Thread Stéphane Graber
On Tue, Oct 22, 2013 at 04:33:34PM -0400, Dwight Engen wrote: > Fixes rpmlint error "script-without-shebang". Checked other lua modules > and none are installed with execute permission. > > Signed-off-by: Dwight Engen Acked-by: Stéphane Graber > --- > src/lua-lxc/Makefile.am | 2 +- > 1 file

Re: [lxc-devel] [PATCH] update rpm .spec file

2013-10-22 Thread Stéphane Graber
On Tue, Oct 22, 2013 at 04:33:26PM -0400, Dwight Engen wrote: > The following changes were made to fix rpmlint warnings/errors > - use %global instead of %define > http://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define > - change Summary to match .deb > - update License > - do

Re: [lxc-devel] Kernel bug? Setuid apps and user namespaces

2013-10-22 Thread Sean Pajot
On 10/22/2013 03:50 PM, Eric W. Biederman wrote: > Serge Hallyn writes: > >> Quoting Sean Pajot (sean.pa...@execulink.com): >>> I've been playing with User Namespaces somewhat extensively and I think I've >>> come across a bug in the handling of /proc/$PID/ entries. >>> >>> This is my example cas

[lxc-devel] [lxc/lxc] 72e992: Pass through all options with -Bbest.

2013-10-22 Thread GitHub
Branch: refs/heads/master Home: https://github.com/lxc/lxc Commit: 72e99249b0c03c283bf68a3334d70a74fee49f34 https://github.com/lxc/lxc/commit/72e99249b0c03c283bf68a3334d70a74fee49f34 Author: Sidnei da Silva Date: 2013-10-22 (Tue, 22 Oct 2013) Changed paths: M src/lxc/bde

[lxc-devel] [PATCH 1/3] container creation: support unpriv container creation in user namespaces

2013-10-22 Thread Serge Hallyn
From: Serge Hallyn 1. lxcapi_create: don't try to unshare and mount for dir backed containers It's unnecessary, and breaks unprivileged lxc-create (since unpriv users cannot yet unshare(CLONE_NEWNS)). 2. api_create: chown rootfs chown rootfs to the host uid to which container root will be mapp

[lxc-devel] unprivileged create/start

2013-10-22 Thread Serge Hallyn
These patches address a few of the issues with creating and running containers without privilege. They are only a start. On an ubuntu trusty system (with a device_cgroup kernel patch) I can now do the following: # one-time system setup sudo apt-get -y install uidmap sudo usermod -v 10-1

[lxc-devel] [PATCH 2/3] fix chowning of tty and console uids

2013-10-22 Thread Serge Hallyn
From: Serge Hallyn It needs to be done from the handler, not the container, since the container may not have the rights. Signed-off-by: Serge Hallyn Changelog: Jul 22: remove hardcoded path for /bin/chown Jul 22: use new lxc-usernsexec Conflicts: src/lxc/lxccontainer.c --- sr

[lxc-devel] [PATCH 3/3] lxc-busybox: if in userns, don't try to mknod

2013-10-22 Thread Serge Hallyn
From: Serge Hallyn Signed-off-by: Serge Hallyn --- templates/lxc-busybox.in | 44 +++- 1 file changed, 31 insertions(+), 13 deletions(-) diff --git a/templates/lxc-busybox.in b/templates/lxc-busybox.in index cbdaaf3..7aa4130 100644 --- a/templates/lxc-bu

Re: [lxc-devel] Kernel bug? Setuid apps and user namespaces

2013-10-22 Thread Eric W. Biederman
Sean Pajot writes: > On 10/22/2013 03:50 PM, Eric W. Biederman wrote: >> Serge Hallyn writes: >> >>> Quoting Sean Pajot (sean.pa...@execulink.com): I've been playing with User Namespaces somewhat extensively and I think I've come across a bug in the handling of /proc/$PID/ entri