Re: [lxc-devel] 0.9.x versions before 1.0

2013-07-10 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > On Tue, Jul 09, 2013 at 06:05:28PM -0400, Dwight Engen wrote: > > Hi guys, > > > > Just curious, has there been any thought about doing any more lxc versions > > 0.9.x before lxc 1.0? Seems like a few things have accumulated since 0.9.0. > > Just pu

Re: [lxc-devel] 0.9.x versions before 1.0

2013-07-10 Thread Serge Hallyn
Quoting Qiang Huang (h.huangqi...@huawei.com): > On 2013/7/10 6:05, Dwight Engen wrote: > > Hi guys, > > > > Just curious, has there been any thought about doing any more lxc versions > > 0.9.x before lxc 1.0? Seems like a few things have accumulated since 0.9.0. > > Just pulled this out of git fo

Re: [lxc-devel] template output

2013-07-10 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): > Hi, > > It looks like LXC@staging started to write template outputs to stdout like > following when one uses the API; > > [caglar@oOo:~/go/src/github.com/caglar10ur/lxc/examples] sudo ./create > Creating container... > Checking cache download in /var/cac

Re: [lxc-devel] [PATCH] lxc-fedora template - Fix retries, use os-release for release, add utsname.

2013-07-10 Thread Serge Hallyn
Quoting Michael H. Warfield (m...@wittsend.com): > Hey all! > > Patch for the Fedora template. Several things... > > 1) A month or so ago, I floated an idea of adding an option for utsname > which Serge seemed to like but we let it float for more feedback (none > came). > > 2) In private mail t

Re: [lxc-devel] [PATCH] fix potential out of bounds pointer deref

2013-07-10 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > I noticed that if find_first_wholeword() is called with word at the very > beginning of p, we will deref *(p - 1) to see if it is a word boundary. > Fix by considering p = p0 to be a word boundary. > > Signed-off-by: Dwight Engen Acked-by: Serge

Re: [lxc-devel] [PATCH 2/2] oracle template: use clonehostname hook script

2013-07-10 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > On Tue, Jul 09, 2013 at 02:44:36PM -0400, Dwight Engen wrote: > > Signed-off-by: Dwight Engen > > Acked-by: Stéphane Graber > > Please don't push until we push the final version of 1/2. Both pushed. -

Re: [lxc-devel] template output

2013-07-10 Thread S . Çağlar Onur
Hi Serge, On Wed, Jul 10, 2013 at 10:36 AM, Serge Hallyn wrote: > Quoting S.Çağlar Onur (cag...@10ur.org): > > Hi, > > > > It looks like LXC@staging started to write template outputs to stdout > like > > following when one uses the API; > > > > [caglar@oOo:~/go/src/github.com/caglar10ur/lxc/examp

Re: [lxc-devel] 0.9.x versions before 1.0

2013-07-10 Thread Qiang Huang
On 2013/7/10 22:30, Serge Hallyn wrote: > Quoting Qiang Huang (h.huangqi...@huawei.com): >> On 2013/7/10 6:05, Dwight Engen wrote: >>> Hi guys, >>> >>> Just curious, has there been any thought about doing any more lxc versions >>> 0.9.x before lxc 1.0? Seems like a few things have accumulated since

Re: [lxc-devel] 0.9.x versions before 1.0

2013-07-10 Thread Serge Hallyn
Quoting Qiang Huang (h.huangqi...@huawei.com): > On 2013/7/10 22:30, Serge Hallyn wrote: > > Quoting Qiang Huang (h.huangqi...@huawei.com): > >> On 2013/7/10 6:05, Dwight Engen wrote: > >>> Hi guys, > >>> > >>> Just curious, has there been any thought about doing any more lxc versions > >>> 0.9.x b

Re: [lxc-devel] 0.9.x versions before 1.0

2013-07-10 Thread Stéphane Graber
On Wed, Jul 10, 2013 at 09:28:52PM -0500, Serge Hallyn wrote: > Quoting Qiang Huang (h.huangqi...@huawei.com): > > On 2013/7/10 22:30, Serge Hallyn wrote: > > > Quoting Qiang Huang (h.huangqi...@huawei.com): > > >> On 2013/7/10 6:05, Dwight Engen wrote: > > >>> Hi guys, > > >>> > > >>> Just curious

[lxc-devel] [PATCH 1/2] lxcapi_create: split out the template execution

2013-07-10 Thread Serge Hallyn
Make it its own function to make both more readable. Signed-off-by: Serge Hallyn --- src/lxc/lxccontainer.c | 215 +++-- 1 file changed, 118 insertions(+), 97 deletions(-) diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c index 245d5eb..caf

[lxc-devel] [PATCH 2/2] lxcapi_create: fix template handling

2013-07-10 Thread Serge Hallyn
1. If no template is passed in, then do not try to execute it. The user just wanted to write the configuration. 2. If template is passed in as a full path, then use that instead of constructing '$templatedir/lxc-$template'. Reported-by: Wanlong Gao Signed-off-by: Serge Hallyn --- src/lxc/lxcc