Re: [lxc-devel] [PATCH] configure: support for the "docbook2man" utility to build the documentation

2013-04-25 Thread Peter Simons
Hallo Stéphane, > I'm not sure whether you sent this after seeing a similar github issue > at: https://github.com/lxc/lxc/pull/18 no, I didn't see that issue. I sent the patch because we apply it in NixOS to build the documentation: https://github.com/NixOS/nixpkgs/tree/master/pkgs/os-specif

[lxc-devel] [PATCH] configure: support for the "docbook2man" utility to build the documentation

2013-04-25 Thread Stéphane Graber
From: Peter Simons This adds docbook2man as an alternative name for the docbook compiler. As that name was used on Debian based systems for an older version of the tool, this change also adds a check so that docbook2man is never used on Debian based systems. Reported-by: Peter Simons Reported-b

[lxc-devel] [PATCH 1/1] lxc_attach: Use clone() instead of second fork()

2013-04-25 Thread Christian Seiler
Because of an assertion in glibc's fork() wrapper that parent pid and pid of child should never be the same, one should avoid fork() after attaching to a PID namespace, since the pid inside the namespace may coincide with the pid of the parent outside the namespace, thus hitting the aforementioned

[lxc-devel] RFC: Refactoring lxc-attach

2013-04-25 Thread Christian Seiler
Hi there, Just a comment on my patch: > This patch just changes the code in the most simple manner to use > clone() instead of fork(). Since clone() requires a function to be > called instead of returning 0, we move the code of the child into a > function child_main. I wanted to make the patch a

Re: [lxc-devel] [PATCH] configure: support for the "docbook2man" utility to build the documentation

2013-04-25 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > From: Peter Simons > > This adds docbook2man as an alternative name for the docbook compiler. > As that name was used on Debian based systems for an older version of the > tool, > this change also adds a check so that docbook2man is never used on

Re: [lxc-devel] [PATCH 1/1] lxc_attach: Use clone() instead of second fork()

2013-04-25 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Because of an assertion in glibc's fork() wrapper that parent pid and > pid of child should never be the same, one should avoid fork() after > attaching to a PID namespace, since the pid inside the namespace may > coincide with the pid of the parent

[lxc-devel] [PATCH] lxc-wait should start monitord

2013-04-25 Thread Dwight Engen
If lxc-wait is run before the container the socket will not yet have been created and lxc_wait's connect to it will fail. Signed-off-by: Dwight Engen --- src/lxc/lxc_wait.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/lxc/lxc_wait.c b/src/lxc/lxc_wait.c index 18200e5..b2e6c0a 100

Re: [lxc-devel] [PATCH] lxc-wait should start monitord

2013-04-25 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > If lxc-wait is run before the container the socket will not yet have > been created and lxc_wait's connect to it will fail. > > Signed-off-by: Dwight Engen Oh, yeah, I was thinking it happened in the common code magically. Acked-by: Serge E. Hal

Re: [lxc-devel] [PATCH] lxc-wait should start monitord

2013-04-25 Thread Dwight Engen
On Thu, 25 Apr 2013 10:40:24 -0500 Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): > > If lxc-wait is run before the container the socket will not yet have > > been created and lxc_wait's connect to it will fail. > > > > Signed-off-by: Dwight Engen > > Oh, yeah, I was thi

[lxc-devel] [PATCH] lxc-monitor multiple paths

2013-04-25 Thread Dwight Engen
>From c4af03c0e6b74e550161e4c8382fb9d0889e4fe3 Mon Sep 17 00:00:00 2001 From: Dwight Engen Date: Thu, 25 Apr 2013 11:45:26 -0400 Subject: [PATCH] lxc-monitor multiple paths Signed-off-by: Dwight Engen --- doc/lxc-monitor.sgml.in | 7 ++ lxc.spec.in | 1 - src/lxc/arguments.c

Re: [lxc-devel] [PATCH] lxc-wait should start monitord

2013-04-25 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > On Thu, 25 Apr 2013 10:40:24 -0500 > Serge Hallyn wrote: > > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > If lxc-wait is run before the container the socket will not yet have > > > been created and lxc_wait's connect to it will fail. >

Re: [lxc-devel] [PATCH] lxc-wait should start monitord

2013-04-25 Thread Stéphane Graber
On 04/25/2013 06:05 PM, Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): >> On Thu, 25 Apr 2013 10:40:24 -0500 >> Serge Hallyn wrote: >> >>> Quoting Dwight Engen (dwight.en...@oracle.com): If lxc-wait is run before the container the socket will not yet have been crea

Re: [lxc-devel] [PATCH v2] lxc_wait should start monitord

2013-04-25 Thread Dwight Engen
If lxc_wait is called before the container has started the socket will not yet have been created and lxc_wait's connect to it will fail. Starting the daemon will create the socket for lxc_wait to connect to. Signed-off-by: Dwight Engen --- src/lxc/state.c | 3 +++ 1 file changed, 3 insertions(+)

Re: [lxc-devel] [PATCH] lxc-wait should start monitord

2013-04-25 Thread Dwight Engen
On Thu, 25 Apr 2013 18:20:13 +0200 Stéphane Graber wrote: > On 04/25/2013 06:05 PM, Serge Hallyn wrote: > > Quoting Dwight Engen (dwight.en...@oracle.com): > >> On Thu, 25 Apr 2013 10:40:24 -0500 > >> Serge Hallyn wrote: > >> > >>> Quoting Dwight Engen (dwight.en...@oracle.com): > If lxc-wa

Re: [lxc-devel] [PATCH v2] lxc_wait should start monitord

2013-04-25 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > If lxc_wait is called before the container has started the socket will not > yet have been created and lxc_wait's connect to it will fail. Starting the > daemon will create the socket for lxc_wait to connect to. > > Signed-off-by: Dwight Engen Ac

[lxc-devel] [PATCH] add zfs support to lxc-create and lxc-destroy

2013-04-25 Thread Serge Hallyn
This is based on patch from Papp Tamas (thanks). It also does some reorganizing of lxc-create to commonize some of the backingstore handling. I played with it using: sudo lvcreate -L 100G -n zfs vg0 sudo zpool create lxc /dev/vg0/zfs sudo lxc-create -B zfs --zfsroot lxc -

[lxc-devel] [PATCH] implement zfs bdev and clone

2013-04-25 Thread Serge Hallyn
Signed-off-by: Serge Hallyn --- src/lxc/bdev.c | 177 1 file changed, 177 insertions(+) diff --git a/src/lxc/bdev.c b/src/lxc/bdev.c index 990e8c5..3df53a5 100644 --- a/src/lxc/bdev.c +++ b/src/lxc/bdev.c @@ -427,6 +427,182 @@ struct bdev