[lxc-devel] [PATCH] configure: support for the "docbook2man" utility to build the documentation

>From 06fee02c1608a67abb6d23b93e3828d5e3ea6b2b Mon Sep 17 00:00:00 2001 From: Peter Simons Date: Mon, 15 Apr 2013 11:18:47 +0200 Subject: [PATCH] configure: support for the "docbook2man" utility to build the documentation Signed-off-by: Peter Simons --- configure.ac | 2 +- 1 file changed, 1 i

Re: [lxc-devel] [PATCH] python: Fix convert_tuple_to_char_pointer_array

Quoting Stéphane Graber (stgra...@ubuntu.com): > This finally fixes a few issues with the magic > convert_tuple_to_char_pointer_array function. > > This now clearly copies the char* from the python object so we don't > end up keeping reference to those. > > Also add the few required free calls to

Re: [lxc-devel] [PATCH] configure: support for the "docbook2man" utility to build the documentation

On 04/24/2013 02:53 PM, Peter Simons wrote: >>From 06fee02c1608a67abb6d23b93e3828d5e3ea6b2b Mon Sep 17 00:00:00 2001 > From: Peter Simons > Date: Mon, 15 Apr 2013 11:18:47 +0200 > Subject: [PATCH] configure: support for the "docbook2man" utility to build the > documentation > > Signed-off-by: Pe

Re: [lxc-devel] [PATCH] allow multiple monitor clients

Quoting Dwight Engen (dwight.en...@oracle.com): > Signed-off-by: Dwight Engen > --- > .gitignore | 1 + > src/lxc/Makefile.am| 2 + > src/lxc/lxc_console.c | 4 +- > src/lxc/lxc_monitor.c | 2 + > src/lxc/lxc_monitord.c | 381 > ++

Re: [lxc-devel] [PATCH] python: Fix convert_tuple_to_char_pointer_array

Hi, I'm getting this on ubuntu 12.10 with this [...] make[3]: Entering directory `/home/caglar/Projects/lxc-upstream/src/python-lxc' CFLAGS="-g -O2 -Wall -Werror -I ../../src -L../../src/lxc/" /usr/bin/python3 setup.py build running build running build_py creating build creating build/lib.linux-

Re: [lxc-devel] [PATCH] python: Fix convert_tuple_to_char_pointer_array

On 04/24/2013 05:10 PM, S.Çağlar Onur wrote: > Hi, > > I'm getting this on ubuntu 12.10 with this Hmm, that makes me wonder if that may be a python3.3 function... let me check with my usual python guru and if it's, I'll send a patch to have this be python3.2 compatible again. > [...] > > make[3

[lxc-devel] [PATCH] python: Make the code compatibly with 3.2

The previous change used some 3.3-specific functions. We still support 3.2 so revert to 3.2-compatible calls. Reported-by: S.Çağlar Onur Signed-off-by: Stéphane Graber --- src/python-lxc/lxc.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/python-lxc/lxc

Re: [lxc-devel] [PATCH] implement backend drivers and container clone API (v2)

Hi Serge, [resending as list rejected my first mail due to its size] On Wed, Apr 24, 2013 at 9:26 AM, Serge Hallyn wrote: > > +static void new_hwaddr(char *hwaddr) > +{ > + snprintf(hwaddr, 18, "00:16:3e:%02x:%02x:%02x", > + rand() % 255, rand() % 255, rand() % 255); >

Re: [lxc-devel] [PATCH] implement backend drivers and container clone API (v2)

Hi Serge, Also do you have a git repository somewhere to pull this patch as this one won't apply cleanly on top of staging tree and I wanted to give it a try. On Wed, Apr 24, 2013 at 11:51 AM, S.Çağlar Onur wrote: > Hi Serge, > > [resending as list rejected my first mail due to its size] > > O

Re: [lxc-devel] [PATCH] implement backend drivers and container clone API (v2)

Yup, it's branch s.9.clone6 in github.com/hallyn/lxc Quoting S.Çağlar Onur (cag...@10ur.org): > Hi Serge, > > Also do you have a git repository somewhere to pull this patch as this one > won't apply cleanly on top of staging tree and I wanted to give it a try. > > > On Wed, Apr 24, 2013 at 11:5

Re: [lxc-devel] [PATCH] implement backend drivers and container clone API (v2)

Quoting S.Çağlar Onur (cag...@10ur.org): > Hi Serge, > > [resending as list rejected my first mail due to its size] > > On Wed, Apr 24, 2013 at 9:26 AM, Serge Hallyn wrote: > > > > +static void new_hwaddr(char *hwaddr) > > +{ > > + snprintf(hwaddr, 18, "00:16:3e:%02x:%02x:%02x", > > +

Re: [lxc-devel] [PATCH] python: Make the code compatibly with 3.2

Quoting Stéphane Graber (stgra...@ubuntu.com): > The previous change used some 3.3-specific functions. > We still support 3.2 so revert to 3.2-compatible calls. > > Reported-by: S.Çağlar Onur > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn > --- > src/python-lxc/lxc.c | 14 +++

Re: [lxc-devel] [PATCH] implement backend drivers and container clone API (v2)

Not sure why the patch didn't apply, I just cherrypicked it into staging with no complaints. Pushed to branch s.b.clone1. Quoting Serge Hallyn (serge.hal...@ubuntu.com): > Yup, it's branch s.9.clone6 in github.com/hallyn/lxc > > Quoting S.Çağlar Onur (cag...@10ur.org): > > Hi Serge, > > > > Als

Re: [lxc-devel] [PATCH v2] allow multiple monitor clients

Thanks for the review Serge, I believe this fixes all your comments. Changes from v1 - made fd array dynamic, fix lxc-monitord when run by hand - removed BUGS section of lxc-monitor manpage --- Signed-off-by: Dwight Engen --- .gitignore | 1 + doc/lxc-monitor.sgml.in | 12 -- s

[lxc-devel] [PATCH] ubuntu: Don't break when the locale is C.*

Update the code to also match C.* so that C.UTF-8 doesn't make the container creation fail. Signed-off-by: Stéphane Graber --- templates/lxc-ubuntu.in | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/templates/lxc-ubuntu.in b/templates/lxc-ubuntu.in index 83311fd..7100

Re: [lxc-devel] [PATCH] ubuntu: Don't break when the locale is C.*

Quoting Stéphane Graber (stgra...@ubuntu.com): > Update the code to also match C.* so that C.UTF-8 doesn't make the > container creation fail. > > Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn > --- > templates/lxc-ubuntu.in | 8 +++- > 1 file changed, 3 insertions(+), 5 deleti

[lxc-devel] [PATCH 1/1] lxc-create: cleanup whenever exiting with error

Otherwise we leave bad containers sitting around and further confuse things on retries. Reported-by: Mukanyiligira Didacienne Signed-off-by: Serge Hallyn --- src/lxc/lxc-create.in | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/lxc/lxc-create.in b/src/lxc/lxc-

Re: [lxc-devel] [PATCH v2] allow multiple monitor clients

Quoting Dwight Engen (dwight.en...@oracle.com): > Thanks for the review Serge, I believe this fixes all your comments. > > Changes from v1 > - made fd array dynamic, fix lxc-monitord when run by hand > - removed BUGS section of lxc-monitor manpage > > --- > > Signed-off-by: Dwight Engen Well H

Re: [lxc-devel] [PATCH 1/2] Support starting containers concurrently

Just wanted to remind that we still need this on top of Dwight's awesome work so that start work reliably. On Tue, Apr 23, 2013 at 5:24 PM, S.Çağlar Onur wrote: > From: "S.Çağlar Onur" > > Trying to start multiple containers concurrently may cause > lxc_monitor_read_timeout to fail as select c

Re: [lxc-devel] [PATCH 1/2] Support starting containers concurrently

On 04/24/2013 10:35 PM, S.Çağlar Onur wrote: > Just wanted to remind that we still need this on top of Dwight's awesome > work so that start work reliably. Looks good to me. Acked-by: Stéphane Graber > On Tue, Apr 23, 2013 at 5:24 PM, S.Çağlar Onur > wrote: > > Fr

Re: [lxc-devel] [PATCH 1/1] lxc-create: cleanup whenever exiting with error

On 04/24/2013 10:16 PM, Serge Hallyn wrote: > Otherwise we leave bad containers sitting around and further confuse > things on retries. > > Reported-by: Mukanyiligira Didacienne > Signed-off-by: Serge Hallyn > --- > src/lxc/lxc-create.in | 10 +- > 1 file changed, 5 insertions(+), 5 del

Re: [lxc-devel] [PATCH 1/1] lxc-create: cleanup whenever exiting with error

Quoting Stéphane Graber (stgra...@ubuntu.com): > On 04/24/2013 10:16 PM, Serge Hallyn wrote: > > Otherwise we leave bad containers sitting around and further confuse > > things on retries. > > > > Reported-by: Mukanyiligira Didacienne > > Signed-off-by: Serge Hallyn > > --- > > src/lxc/lxc-crea

Re: [lxc-devel] [PATCH 1/1] lxc-create: cleanup whenever exiting with error

On 04/25/2013 01:46 AM, Serge Hallyn wrote: > Quoting Stéphane Graber (stgra...@ubuntu.com): >> On 04/24/2013 10:16 PM, Serge Hallyn wrote: >>> Otherwise we leave bad containers sitting around and further confuse >>> things on retries. >>> >>> Reported-by: Mukanyiligira Didacienne >>> Signed-off-b

Re: [lxc-devel] [PATCH] implement backend drivers and container clone API (v2)

Quoting S.Çağlar Onur (cag...@10ur.org): > Hi Serge, > > [resending as list rejected my first mail due to its size] > > On Wed, Apr 24, 2013 at 9:26 AM, Serge Hallyn wrote: > > > > +static void new_hwaddr(char *hwaddr) > > +{ > > + snprintf(hwaddr, 18, "00:16:3e:%02x:%02x:%02x", > > +

Re: [lxc-devel] [PATCH] implement backend drivers and container clone API (v2)

After this patch, I'd like to only re-introduce the original lxc-clone bash script's command line options in the new c program, then push to staging. Subject: [PATCH 2/3] on copy-clone of btrfs, create a subvolume so that it can be snapshotted. Signed-off-by: Serge Hallyn --- src/lxc/bdev.c |

[lxc-devel] No child processes - unexpected waitpid return value on double-fork

Hey Serge, Unfortunately I don't have time to debug it today but I believe started to get following after your last commit [1]. [caglar@qgq:~/Project/lxc/examples] sudo ./concurrent_start Starting the container (5)... Starting the container (7)... Starting the container (0)... Starting the contai

Re: [lxc-devel] No child processes - unexpected waitpid return value on double-fork

Interesting. Unexpected, but I'll go ahead and revert the commit that caused that - thanks! My hope is that getting rid of it isn't hiding a worse bug, but we can delve into that later. Quoting S.Çağlar Onur (cag...@10ur.org): > Hey Serge, > > Unfortunately I don't have time to debug it today b