[lxc-devel] [PATCH 2/2] Revert "start: Detect early failure of the new child"

2013-04-18 Thread Stéphane Graber
This reverts commit 5a5c35c3a01afec515e688c8366e6f893985518d. This commit was preventing startup of containers using lxc hooks and shutdown of all other containers, requiring the use of a good old kill -9 to get rid of lxc-start after a container shutdown. Signed-off-by: Stéphane Graber --- src

[lxc-devel] [PATCH 1/2] Revert "utils: reimplement/fix mkdir_p()"

2013-04-18 Thread Stéphane Graber
This reverts commit 8de4140644f01180f2fdab55b0ab0f13d1c761c6. This commit was preventing container startup on my machine, making them all fail with various "No such file or directory" errors. Signed-off-by: Stéphane Graber --- src/lxc/utils.c | 48 +++

Re: [lxc-devel] [PATCH 2/2] Revert "start: Detect early failure of the new child"

2013-04-18 Thread Stéphane Graber
On 04/18/2013 10:32 AM, Stéphane Graber wrote: > This reverts commit 5a5c35c3a01afec515e688c8366e6f893985518d. > > This commit was preventing startup of containers using lxc hooks and > shutdown of all other containers, requiring the use of a good old > kill -9 to get rid of lxc-start after a cont

Re: [lxc-devel] [PATCH 1/2] Revert "utils: reimplement/fix mkdir_p()"

2013-04-18 Thread Stéphane Graber
On 04/18/2013 10:32 AM, Stéphane Graber wrote: > This reverts commit 8de4140644f01180f2fdab55b0ab0f13d1c761c6. > > This commit was preventing container startup on my machine, making them > all fail with various "No such file or directory" errors. > > Signed-off-by: Stéphane Graber Was directly

[lxc-devel] [PATCH] python: Lots of fixes in C extension

2013-04-18 Thread Stéphane Graber
Fixes a lot of issues found by a code review done by Barry Warsaw. Those include: - Wrong signature for getters - Various memory leaks - Various optimizations - More consistent return values - Proper exception handling Reported-by: Barry Warsaw Signed-off-by: Stéphane Graber --- src/pytho

[lxc-devel] [PATCH] utils: reimplement/fix mkdir_p()

2013-04-18 Thread Richard Weinberger
Reimplement mkdir_p() such that it: ...handles relativ paths correctly. (currently it crashes) ...does not rely on dirname(). ...is not recursive. ...is shorter. ;-) Signed-off-by: Richard Weinberger --- src/lxc/utils.c | 46 +++--- 1 file changed, 15

Re: [lxc-devel] [PATCH] utils: reimplement/fix mkdir_p()

2013-04-18 Thread Richard Weinberger
Am 17.04.2013 22:49, schrieb Serge Hallyn: > Quoting Richard Weinberger (rich...@nod.at): >> Am 17.04.2013 18:00, schrieb Serge Hallyn: >>> Quoting Richard Weinberger (rich...@nod.at): Reimplement mkdir_p() such that it: ...handles relativ paths correctly. (currently it crashes)

Re: [lxc-devel] [PATCH 1/2] Revert "utils: reimplement/fix mkdir_p()"

2013-04-18 Thread Stéphane Graber
On 04/18/2013 10:34 AM, Stéphane Graber wrote: > On 04/18/2013 10:32 AM, Stéphane Graber wrote: >> This reverts commit 8de4140644f01180f2fdab55b0ab0f13d1c761c6. >> >> This commit was preventing container startup on my machine, making them >> all fail with various "No such file or directory" errors.

Re: [lxc-devel] [PATCH 1/2] Revert "utils: reimplement/fix mkdir_p()"

2013-04-18 Thread Stéphane Graber
On 04/18/2013 10:48 AM, Stéphane Graber wrote: > On 04/18/2013 10:34 AM, Stéphane Graber wrote: >> On 04/18/2013 10:32 AM, Stéphane Graber wrote: >>> This reverts commit 8de4140644f01180f2fdab55b0ab0f13d1c761c6. >>> >>> This commit was preventing container startup on my machine, making them >>> all

Re: [lxc-devel] [PATCH 1/2] Revert "utils: reimplement/fix mkdir_p()"

2013-04-18 Thread Stéphane Graber
On 04/18/2013 10:34 AM, Stéphane Graber wrote: > On 04/18/2013 10:32 AM, Stéphane Graber wrote: >> This reverts commit 8de4140644f01180f2fdab55b0ab0f13d1c761c6. >> >> This commit was preventing container startup on my machine, making them >> all fail with various "No such file or directory" errors.

[lxc-devel] [PATCH] remove duplicate method declaration (setup_cgroup).

2013-04-18 Thread Kevin Wilson
This patch removes duplicate method declaration (setup_cgroup) in conf.h. Signed-off-by: Kevin Wilson --- src/lxc/conf.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/lxc/conf.h b/src/lxc/conf.h index 465b1ec..0e87c69 100644 --- a/src/lxc/conf.h +++ b/src/lxc/conf.h @@ -313,8 +313,6 @

[lxc-devel] git tree and man pages

2013-04-18 Thread David Shwatrz
Hi, lxc-developers, I had performed git clone git://lxc.git.sourceforge.net/gitroot/lxc/lxc and under doc I don't see any man pages. for a lxc tar gz I downloaded, they are under doc. Is there a reason man pages are not in git ? DS --

Re: [lxc-devel] git tree and man pages

2013-04-18 Thread Stéphane Graber
On 04/18/2013 01:34 PM, David Shwatrz wrote: > Hi, lxc-developers, > I had performed > git clone git://lxc.git.sourceforge.net/gitroot/lxc/lxc > and under doc I don't see any man pages. > > for a lxc tar gz I downloaded, they are under doc. > > Is there a reason man pages are not in git ? > > >

Re: [lxc-devel] [PATCH] remove duplicate method declaration (setup_cgroup).

2013-04-18 Thread Serge Hallyn
Quoting Kevin Wilson (wkev...@gmail.com): > This patch removes duplicate method declaration (setup_cgroup) > in conf.h. > > Signed-off-by: Kevin Wilson Uh. What the *? How did I leave that in? Thanks. Acked-by: Serge E. Hallyn > --- > src/lxc/conf.h | 2 -- > 1 file changed, 2 deletions(-

[lxc-devel] [RFC PATCH] api_clone: implement basic directory-backed container clone

2013-04-18 Thread Serge Hallyn
1. commonize waitpid users to use a single helper. We frequently want to run something in a clean namespace, or fork off a script. This lets us keep the function doing fork:(1)exec(2)waitpid simpler. 2. start a blockdev backend implementation. This will be used for mounting, copying, and snapsh

Re: [lxc-devel] git tree and man pages

2013-04-18 Thread David Shwatrz
Hello, Thanks for the answer. Is there a way to generate the man pages after downloaded the git tree? When I ran "make" the man pages were not generated. regards, David On Thu, Apr 18, 2013 at 2:45 PM, Stéphane Graber wrote: > On 04/18/2013 01:34 PM, David Shwatrz wrote: >> Hi, lxc-developers

Re: [lxc-devel] git tree and man pages

2013-04-18 Thread Stéphane Graber
On 04/18/2013 05:13 PM, David Shwatrz wrote: > Hello, > Thanks for the answer. > > Is there a way to generate the man pages after downloaded the > git tree? When I ran "make" the man pages were not generated. > > regards, > David You need to pass --enable-doc to the configure script. > > On T

Re: [lxc-devel] [PATCH] python: Lots of fixes in C extension

2013-04-18 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > Fixes a lot of issues found by a code review done by Barry Warsaw. > > Those include: > - Wrong signature for getters > - Various memory leaks > - Various optimizations > - More consistent return values > - Proper exception handling > > Report

Re: [lxc-devel] git tree and man pages

2013-04-18 Thread David Shwatrz
Hi, Great. After "yum install docbook2X" and ./configure --enable-doc” it worked. rgs DS On Thu, Apr 18, 2013 at 6:31 PM, Stéphane Graber wrote: > On 04/18/2013 05:13 PM, David Shwatrz wrote: >> Hello, >> Thanks for the answer. >> >> Is there a way to generate the man pages after downloaded the

Re: [lxc-devel] [PATCH 1/2] Revert "utils: reimplement/fix mkdir_p()"

2013-04-18 Thread richard -rw- weinberger
On Thu, Apr 18, 2013 at 10:48 AM, Stéphane Graber wrote: > On 04/18/2013 10:34 AM, Stéphane Graber wrote: >> On 04/18/2013 10:32 AM, Stéphane Graber wrote: >>> This reverts commit 8de4140644f01180f2fdab55b0ab0f13d1c761c6. >>> >>> This commit was preventing container startup on my machine, making t

Re: [lxc-devel] [PATCH 2/2] Revert "start: Detect early failure of the new child"

2013-04-18 Thread richard -rw- weinberger
On Thu, Apr 18, 2013 at 10:32 AM, Stéphane Graber wrote: > This reverts commit 5a5c35c3a01afec515e688c8366e6f893985518d. > > This commit was preventing startup of containers using lxc hooks and > shutdown of all other containers, requiring the use of a good old > kill -9 to get rid of lxc-start af

Re: [lxc-devel] [PATCH 2/2] Revert "start: Detect early failure of the new child"

2013-04-18 Thread S . Çağlar Onur
Hi Richard, That happened to me yesterday. I think you can easily reproduce the issue by just starting a container, logging into it and calling poweroff. You will see that it will stuck at the end of it. Alternatively you can use python/c/go api to do the same which shows the same effect. Best,

Re: [lxc-devel] [PATCH 1/2] Revert "utils: reimplement/fix mkdir_p()"

2013-04-18 Thread Stéphane Graber
On 04/18/2013 07:14 PM, richard -rw- weinberger wrote: > On Thu, Apr 18, 2013 at 10:48 AM, Stéphane Graber wrote: >> On 04/18/2013 10:34 AM, Stéphane Graber wrote: >>> On 04/18/2013 10:32 AM, Stéphane Graber wrote: This reverts commit 8de4140644f01180f2fdab55b0ab0f13d1c761c6. This c

[lxc-devel] [RFC PATCH] allow multiple monitor clients

2013-04-18 Thread Dwight Engen
After the recent discussions on the lxc monitor, I took a closer look at it. It seems like Serge was resigned to having some sort of daemon as having multicast unix domain supported by the kernel is not going to happen any time soon, and doing it over loopback has some complications too. Initially

Re: [lxc-devel] [PATCH 2/2] Revert "start: Detect early failure of the new child"

2013-04-18 Thread Stéphane Graber
On 04/18/2013 08:07 PM, S.Çağlar Onur wrote: > Hi Richard, > > That happened to me yesterday. I think you can easily reproduce the > issue by just starting a container, logging into it and calling > poweroff. You will see that it will stuck at the end of it. > Alternatively you can use python/c/go

Re: [lxc-devel] [PATCH 2/2] Revert "start: Detect early failure of the new child"

2013-04-18 Thread richard -rw- weinberger
On Thu, Apr 18, 2013 at 8:07 PM, S.Çağlar Onur wrote: > Hi Richard, > > That happened to me yesterday. I think you can easily reproduce the issue by > just starting a container, logging into it and calling poweroff. You will > see that it will stuck at the end of it. Alternatively you can use > py

Re: [lxc-devel] [RFC PATCH] allow multiple monitor clients

2013-04-18 Thread Dwight Engen
On Thu, 18 Apr 2013 14:22:08 -0400 S.Çağlar Onur wrote: > Hey Dwight, > > This sounds great, I'll give it a try ASAP. In the meantime ,if you > want to test it yourself, you can grab go bindings from github via > "go get github.com/caglar10ur/lxc" but please keep in your mind that > you need my

Re: [lxc-devel] [RFC PATCH] allow multiple monitor clients

2013-04-18 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > After the recent discussions on the lxc monitor, I took a closer look at > it. It seems like Serge was resigned to having some sort of daemon as > having multicast unix domain supported by the kernel is not going to > happen any time soon, and doing

Re: [lxc-devel] [RFC PATCH] allow multiple monitor clients

2013-04-18 Thread Dwight Engen
On Thu, 18 Apr 2013 13:48:25 -0500 Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): > > After the recent discussions on the lxc monitor, I took a closer > > look at it. It seems like Serge was resigned to having some sort of > > daemon as having multicast unix domain supporte

Re: [lxc-devel] [RFC PATCH] allow multiple monitor clients

2013-04-18 Thread Dwight Engen
Thanks Çağlar! I'll look into those things. On Thu, 18 Apr 2013 15:08:19 -0400 S.Çağlar Onur wrote: > Hi, > > I think I got it why, most likely recvfrom gets an EINTR there like > select. > > int lxc_monitor_read_timeout(int fd, struct lxc_msg *msglxc, int > timeout) { > struct sockadd

[lxc-devel] [PATCH] python: Various fixes to the python scripts

2013-04-18 Thread Stéphane Graber
This fixes a few issues uncovered by the recent C module fix. In lxc-start-ephemeral, the hwaddr code wasn't actually working. Replace by code that properly iterates through the network interfaces and sets a new MAC address for each entry. In the python overlay, catch the newly emitted KeyError w

Re: [lxc-devel] [PATCH] python: Various fixes to the python scripts

2013-04-18 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > This fixes a few issues uncovered by the recent C module fix. > > In lxc-start-ephemeral, the hwaddr code wasn't actually working. > Replace by code that properly iterates through the network interfaces > and sets a new MAC address for each entry. >

Re: [lxc-devel] [PATCH 2/2] Revert "start: Detect early failure of the new child"

2013-04-18 Thread richard -rw- weinberger
On Thu, Apr 18, 2013 at 8:10 PM, Stéphane Graber wrote: > On 04/18/2013 08:07 PM, S.Çağlar Onur wrote: >> Hi Richard, >> >> That happened to me yesterday. I think you can easily reproduce the >> issue by just starting a container, logging into it and calling >> poweroff. You will see that it will

Re: [lxc-devel] [PATCH 1/2] Revert "utils: reimplement/fix mkdir_p()"

2013-04-18 Thread richard -rw- weinberger
On Thu, Apr 18, 2013 at 8:08 PM, Stéphane Graber wrote: > He only acked the second patch which made it extremely late to the > mailing-list (Serge got it early as he was directly CCed on it). > >> 3. If you encounter problems with one of my patches the lest thing you >> can do is CC'ing me. > > We