Re: [lxc-devel] using posix shell instead of bash

2012-11-14 Thread Natanael Copa
On Wed, 14 Nov 2012 08:40:39 +0100 Natanael Copa wrote: > I wonder if it there are any interest to make the scripts posix shell > compliant so they can run with for example busybox ash and dash. I should maybe add that I think the biggest challenge will be the longopts parsing. That said I have

Re: [lxc-devel] using posix shell instead of bash

2012-11-14 Thread Natanael Copa
On Wed, 14 Nov 2012 14:04:43 +0100 Natanael Copa wrote: > @@ -18,10 +18,11 @@ > # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA > 02111-1307 USA > lxc_path=@LXCPATH@ > +program=${0##*/} > > usage() > { > - echo "usage: $(basename $0) [--active] [--] [LS_OPTIONS...]" > >&2 >

Re: [lxc-devel] [PATCH] lxc-destroy: make it work with busybox

2012-11-14 Thread Serge Hallyn
Quoting Natanael Copa (nc...@alpinelinux.org): > Busybox 'rm' has no support for --one-file-system. We can make it work > on busybox with find ... -xdev. Hm, well it does slow it down a smidgeon, but no real objection from me. Still let's if anyone else has a comment. > Signed-off-by: Natanael C

Re: [lxc-devel] [PATCH] lxc-start: add option -p, --pidfile=FILE for use with --daemon

2012-11-14 Thread Serge Hallyn
Quoting Natanael Copa (nc...@alpinelinux.org): > Add option to create a pidfile for lxc-start daemon. This is helpful > for init scripts and process monitors. Why only when daemonizing? Someone could presumably first lxc-start by hand in the foreground, then another admin walks in and restarts th

[lxc-devel] [PATCH] ensure btrfs subvolume is removed when container creating fails

2012-11-14 Thread Frederic Crozat
Hi, while updating our package for LXC 0.8.0, I discovered that lxc-create didn't properly delete btrfs subvolume if container creation failed for any reason. Attached patch fixes this issue. -- Frederic Crozat SUSE >From 028d1b3eb110229113dc99f3587fac1f9fca9b0e Mon Sep 17 00:00:00 2001 From: F

[lxc-devel] [PATCH] Fix package name needed for building docs with RPM

2012-11-14 Thread Dwight Engen
Tested on Oracle Linux 6 and Fedora 17 Signed-off-by: Dwight Engen --- lxc.spec.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lxc.spec.in b/lxc.spec.in index 10b7254..7998cfd 100644 --- a/lxc.spec.in +++ b/lxc.spec.in @@ -30,7 +30,7 @@ Group: Applications/System L

Re: [lxc-devel] [PATCH] ensure btrfs subvolume is removed when container creating fails

2012-11-14 Thread Serge Hallyn
Quoting Frederic Crozat (fcro...@suse.com): > Hi, > > while updating our package for LXC 0.8.0, I discovered that lxc-create > didn't properly delete btrfs subvolume if container creation failed for > any reason. > > Attached patch fixes this issue. Acked-by: Serge E. Hallyn > -- > Frederic C

Re: [lxc-devel] using posix shell instead of bash

2012-11-14 Thread Serge Hallyn
Quoting Natanael Copa (nc...@alpinelinux.org): > Hi, > > I wonder if it there are any interest to make the scripts posix shell > compliant so they can run with for example busybox ash and dash. > > I would like to provide proper LCX support for Alpine Linux, which by > default runs from tmpfs. It

Re: [lxc-devel] [PATCH] Fix package name needed for building docs with RPM

2012-11-14 Thread Stéphane Graber
On 11/14/2012 10:44 AM, Dwight Engen wrote: > Tested on Oracle Linux 6 and Fedora 17 > > Signed-off-by: Dwight Engen Acked-by: Stéphane Graber And applied to staging branch. > --- > lxc.spec.in |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lxc.spec.in b/lxc.

Re: [lxc-devel] [PATCH] ensure btrfs subvolume is removed when container creating fails

2012-11-14 Thread Stéphane Graber
On 11/14/2012 10:47 AM, Serge Hallyn wrote: > Quoting Frederic Crozat (fcro...@suse.com): >> Hi, >> >> while updating our package for LXC 0.8.0, I discovered that lxc-create >> didn't properly delete btrfs subvolume if container creation failed for >> any reason. >> >> Attached patch fixes this iss

[lxc-devel] [PATCH] Fix checkconfig to handle kernel memory cgroup name change

2012-11-14 Thread Dwight Engen
The kernel config option for the memory cgroup was changed in 3.6 from CONFIG_CGROUP_MEM_RES_CTLR to CONFIG_MEMCG with commit c255a458. Signed-off-by: Dwight Engen --- src/lxc/lxc-checkconfig.in | 25 +++-- 1 files changed, 15 insertions(+), 10 deletions(-) diff --git a/sr

Re: [lxc-devel] using posix shell instead of bash

2012-11-14 Thread Michael H. Warfield
On Wed, 2012-11-14 at 09:54 -0600, Serge Hallyn wrote: > Quoting Natanael Copa (nc...@alpinelinux.org): > > Hi, > > > > I wonder if it there are any interest to make the scripts posix shell > > compliant so they can run with for example busybox ash and dash. > > > > I would like to provide proper

Re: [lxc-devel] using posix shell instead of bash

2012-11-14 Thread Stéphane Graber
On 11/14/2012 01:50 PM, Michael H. Warfield wrote: > On Wed, 2012-11-14 at 09:54 -0600, Serge Hallyn wrote: >> Quoting Natanael Copa (nc...@alpinelinux.org): >>> Hi, >>> >>> I wonder if it there are any interest to make the scripts posix shell >>> compliant so they can run with for example busybox

Re: [lxc-devel] [PATCH] lxc-destroy: make it work with busybox

2012-11-14 Thread Natanael Copa
On Wed, 14 Nov 2012 08:51:07 -0600 Serge Hallyn wrote: > Quoting Natanael Copa (nc...@alpinelinux.org): > > Busybox 'rm' has no support for --one-file-system. We can make it > > work on busybox with find ... -xdev. > > Hm, well it does slow it down a smidgeon, but no real objection > from me. S

Re: [lxc-devel] [PATCH] lxc-start: add option -p, --pidfile=FILE for use with --daemon

2012-11-14 Thread Natanael Copa
On Wed, 14 Nov 2012 08:44:41 -0600 Serge Hallyn wrote: > Quoting Natanael Copa (nc...@alpinelinux.org): > > Add option to create a pidfile for lxc-start daemon. This is helpful > > for init scripts and process monitors. > > Why only when daemonizing? Someone could presumably first lxc-start > b

Re: [lxc-devel] [PATCH] lxc-destroy: make it work with busybox

2012-11-14 Thread Serge Hallyn
Quoting Natanael Copa (nc...@alpinelinux.org): > On Wed, 14 Nov 2012 08:51:07 -0600 > Serge Hallyn wrote: > > > Quoting Natanael Copa (nc...@alpinelinux.org): > > > Busybox 'rm' has no support for --one-file-system. We can make it > > > work on busybox with find ... -xdev. > > > > Hm, well it do

Re: [lxc-devel] using posix shell instead of bash

2012-11-14 Thread Natanael Copa
On Wed, 14 Nov 2012 09:54:58 -0600 Serge Hallyn wrote: > (Note also that lxc-ls may be rewritten in python. Is that a problem > for your use case?) well... The Alpine Linux base system is 6MB excluding kernel. I offer to spend a day or so to save 700kb by getting rid of bash. and now you want

Re: [lxc-devel] using posix shell instead of bash

2012-11-14 Thread Natanael Copa
On Wed, 14 Nov 2012 09:54:58 -0600 Serge Hallyn wrote: > Quoting Natanael Copa (nc...@alpinelinux.org): forgot this... > > Would you be prepared for minor sacrifices to use posix compliant > > shell scripts? > > Someone else can jump in if they object, but I personally don't. Are > you willi

Re: [lxc-devel] using posix shell instead of bash

2012-11-14 Thread Natanael Copa
On Wed, 14 Nov 2012 13:50:54 -0500 "Michael H. Warfield" wrote: > Converting from bash to ash (which is very sh like) isn't too bad if > you are not making extensive use of arrays and string functions. It's > probably doable (having done it myself with some fairly sophisticated > bash scripts de

Re: [lxc-devel] using posix shell instead of bash

2012-11-14 Thread Serge Hallyn
Quoting Natanael Copa (nc...@alpinelinux.org): > On Wed, 14 Nov 2012 09:54:58 -0600 > Serge Hallyn wrote: > > > (Note also that lxc-ls may be rewritten in python. Is that a problem > > for your use case?) > > well... The Alpine Linux base system is 6MB excluding kernel. I offer > to spend a da

Re: [lxc-devel] using posix shell instead of bash

2012-11-14 Thread Serge Hallyn
Quoting Natanael Copa (nc...@alpinelinux.org): > On Wed, 14 Nov 2012 09:54:58 -0600 > Serge Hallyn wrote: > > > Quoting Natanael Copa (nc...@alpinelinux.org): > > forgot this... > > > > Would you be prepared for minor sacrifices to use posix compliant > > > shell scripts? > > > > Someone else

Re: [lxc-devel] Lxc-devel Digest, Vol 51, Issue 10

2012-11-14 Thread Han Yuejuan-B42073
Hello all, I use following way to start a container as a daemon: lxc-start –n -d and then connect to it using lxc-console: lxc-console -n But there is a problem: When execute " lxc-console -n ", then it will come with "lxc-console: 'ctx1' is stopped" Anyone has ideas about this