Re: [lxc-devel] [PATCH 0/3] The poor man's attach

2011-11-03 Thread Cedric Le Goater
> Hi Greg, > > I successfully applied the patches, but the compilation fails with: > > /home/dlezcano/work/src/lxc/src/lxc/lxc_init.c:164: undefined reference > to `lxc_error_set_and_log_siginfo' > /home/dlezcano/work/src/lxc/src/lxc/lxc_init.c:193: undefined reference > to `lxc_error_set_and_log_s

Re: [lxc-devel] [PATCH 0/3] The poor man's attach

2011-11-03 Thread Greg Kurz
On Sat, 2011-10-29 at 20:26 +0200, Daniel Lezcano wrote: > On 10/26/2011 05:13 PM, Greg Kurz wrote: > > Often people want to launch a command in an already > > running container. This can be achieved with the lxc-attach > > command, provided you have a patched kernel with full > > setns() support.

Re: [lxc-devel] [PATCH 0/3] The poor man's attach

2011-11-03 Thread Greg Kurz
On Thu, 2011-11-03 at 09:36 +0100, Cedric Le Goater wrote: > > Hi Greg, > > > > I successfully applied the patches, but the compilation fails with: > > > > /home/dlezcano/work/src/lxc/src/lxc/lxc_init.c:164: undefined reference > > to `lxc_error_set_and_log_siginfo' > > /home/dlezcano/work/src/lxc/

Re: [lxc-devel] [PATCH 0/3] The poor man's attach

2011-11-03 Thread Cedric Le Goater
>> --- lxc.git.orig/src/lxc/lxc_init.c >> +++ lxc.git/src/lxc/lxc_init.c >> @@ -36,6 +36,7 @@ >>#include >>#include >>#include >> +#include >> > > Hmm... Look at my original post, is included between > and. I guess you want to fix this warning: > > In function ‘handle_rexec_connect’: >

[lxc-devel] [PATCH 1/2] lxc: fix erroneous includes

2011-11-03 Thread Greg Kurz
The "" notation is preferrable if the header file is local. Signed-off-by: Greg Kurz --- src/lxc/genl.c |5 +++-- src/lxc/lxc_info.c |3 ++- src/lxc/mainloop.h |2 +- src/lxc/network.c |5 +++-- src/lxc/nl.c |3 ++- src/lxc/restart.c |3 ++- src/lxc/rtnl.c

[lxc-devel] [PATCH 2/2] lxc: use -iquote instead of -I

2011-11-03 Thread Greg Kurz
To avoid name collisions between local and system header files. For example, if you try to include the system file, you end up including the one from lxc... Signed-off-by: Greg Kurz --- src/lxc/Makefile.am |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/src/lxc/M

Re: [lxc-devel] [PATCH 0/3] The poor man's attach

2011-11-03 Thread Greg Kurz
On Thu, 2011-11-03 at 14:24 +0100, Cedric Le Goater wrote: > For a reason I don't fully understand, src/lxc/pty.h gets included > > instead of /usr/include/pty.h... hence the warning. > > src/lxc/pty.h comes with these include options: > > DEFAULT_INCLUDES = -I. -I$(srcdir) -I$(top_buildd