[lxc-devel] [PATCH 1/3] Bad checking of getconfig key

2010-09-16 Thread Clement Calmels
Without this patch all false config key that looks like a real one are valid. For example: lxc-execute -n foo -s 'lxc.utsnamebug= bar' With this patch it now raises an error: $ lxc-execute -n foo -s 'lxc.utsnamebug= bar' -- uname -a lxc-execute: unknow key lxc.utsnamebug Signed-off-by: Clement

[lxc-devel] [PATCH 2/3] Change configuration file parser

2010-09-16 Thread Clement Calmels
This change allow end of line comment and IMHO simplify parse_line function. Signed-off-by: Clement Calmels --- src/lxc/confile.c | 69 ++--- 1 files changed, 23 insertions(+), 46 deletions(-) diff --git a/src/lxc/confile.c b/src/lxc/confile.c

[lxc-devel] [PATCH 3/3] Remove unused parsing code

2010-09-16 Thread Clement Calmels
Signed-off-by: Clement Calmels --- src/lxc/parse.c | 72 --- src/lxc/parse.h | 12 - 2 files changed, 0 insertions(+), 84 deletions(-) diff --git a/src/lxc/parse.c b/src/lxc/parse.c index ee6b5de..156f05a 100644 --- a/src/lxc/parse

Re: [lxc-devel] [PATCH 1/3] Bad checking of getconfig key

2010-09-16 Thread Clément Calmels
This serie brings some new issues. Will rework on it. c. On jeu, 2010-09-16 at 16:05 +0200, Clement Calmels wrote: > Without this patch all false config key that looks like a real one are > valid. For example: > > lxc-execute -n foo -s 'lxc.utsnamebug= bar' > > With this patch it now raises an