Re: [lxc-devel] [PATCH 1/1] lxc_attach: fix break with user namespaces (v2)

2013-01-22 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Hi Serge, > > >Would you care to update the patch along these lines? > > Will do, but it will take me a few days time, since I have to set up an > environment where I can test user namespaces first. Awesome, it'll be good to have more people exper

Re: [lxc-devel] [PATCH 1/1] lxc_attach: fix break with user namespaces (v2)

2013-01-22 Thread Christian Seiler
Hi Serge, > Would you care to update the patch along these lines? Will do, but it will take me a few days time, since I have to set up an environment where I can test user namespaces first. Regards, Christian -- Master

Re: [lxc-devel] [PATCH 1/1] lxc_attach: fix break with user namespaces (v2)

2013-01-21 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Hi Serge, > > Just a few quick comments because I'm very interested in the lxc-attach > utility: > > > + ret = lxc_cgroup_prepare_attach(my_args.name, > > &cgroup_data); > > + if (ret < 0) { > > +

Re: [lxc-devel] [PATCH 1/1] lxc_attach: fix break with user namespaces (v2)

2013-01-21 Thread Christian Seiler
Hi Serge, Just a few quick comments because I'm very interested in the lxc-attach utility: > + ret = lxc_cgroup_prepare_attach(my_args.name, > &cgroup_data); > + if (ret < 0) { > + ERROR("failed to prepare attaching to cgroup");

Re: [lxc-devel] [PATCH 1/1] lxc_attach: fix break with user namespaces

2013-01-21 Thread Serge Hallyn
Quoting Serge Hallyn (serge.hal...@canonical.com): > When you clone a new user_ns, the child cannot write to the fds > opened by the parent. Hnadle this by doing an extra fork. The > grandparent hangs around and waits for its child to tell it the > pid of of the grandchild, which will be the one