Re: [lxc-devel] [PATCH] lxc-create: use posix shell instead of bash

2012-11-21 Thread Stéphane Graber
On 11/19/2012 11:36 AM, Serge Hallyn wrote: > Quoting Natanael Copa (nc...@alpinelinux.org): >> - use '[ -x /path/prog ]' instead of 'type /path/prog' >> - avoid getopt --longoptions >> - add \ at after && and || when those are at end of line >> - make sure condition expands to empty string if vari

Re: [lxc-devel] [PATCH] lxc-create: use posix shell instead of bash

2012-11-19 Thread Serge Hallyn
Quoting Natanael Copa (nc...@alpinelinux.org): > - use '[ -x /path/prog ]' instead of 'type /path/prog' > - avoid getopt --longoptions > - add \ at after && and || when those are at end of line > - make sure condition expands to empty string if variable is empty > looks good to me, thanks. Acked