Re: [lxc-devel] [PATCH] Invoke lxc_map_ids only when id_map is not empty

2013-03-13 Thread Serge Hallyn
Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): > With recent commits this code path prevents containers from starting > on vanilla kernels, because there's no /proc//{u,g}id_map support > there. > If it was intended to make user namespaces support mandatory, then > disregard t

Re: [lxc-devel] [PATCH] Invoke lxc_map_ids only when id_map is not empty

2013-03-13 Thread Alexander Vladimirov
With recent commits this code path prevents containers from starting on vanilla kernels, because there's no /proc//{u,g}id_map support there. If it was intended to make user namespaces support mandatory, then disregard that patch please. 2013/3/13 Serge Hallyn : > Quoting Alexander Vladimirov (ale

Re: [lxc-devel] [PATCH] Invoke lxc_map_ids only when id_map is not empty

2013-03-13 Thread Serge Hallyn
Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): > > Signed-off-by: Alexander Vladimirov Nothing wrong with this, but why do you want this? It will save you a 4096k allocation (which we could optimize away so it only happens if needed), and one function call, but that is all