Re: [lxc-devel] RFC: Refactoring lxc-attach

2013-04-29 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Hi there, > > any comments on my proposal? > > > The basic idea for the refactored attach API would be: > > > > - pid_t lxc_attach(const char* name, const char* lxcpath, > > options...) > > + create a socket pair for sync > > + f

Re: [lxc-devel] RFC: Refactoring lxc-attach

2013-04-28 Thread Christian Seiler
Hi there, any comments on my proposal? > The basic idea for the refactored attach API would be: > > - pid_t lxc_attach(const char* name, const char* lxcpath, > options...) > + create a socket pair for sync > + fork() (get rid of threading, nss stuff, etc.) > |- same pro

[lxc-devel] RFC: Refactoring lxc-attach

2013-04-25 Thread Christian Seiler
Hi there, Just a comment on my patch: > This patch just changes the code in the most simple manner to use > clone() instead of fork(). Since clone() requires a function to be > called instead of returning 0, we move the code of the child into a > function child_main. I wanted to make the patch a