On Tue, 29 Jan 2013 14:43:45 -0500
Dwight Engen wrote:
> Hi Natanael, thanks for the review!
>
> On Tue, 29 Jan 2013 09:46:29 +0100
> Natanael Copa wrote:
>
> [...]
> > > --- /dev/null
> > > +++ b/src/lua-lxc/Makefile.am
> > > @@ -0,0 +1,26 @@
> > > +if ENABLE_LUA
> > > +
> > > +luadir=$(datad
Hi Natanael, thanks for the review!
On Tue, 29 Jan 2013 09:46:29 +0100
Natanael Copa wrote:
[...]
> > --- /dev/null
> > +++ b/src/lua-lxc/Makefile.am
> > @@ -0,0 +1,26 @@
> > +if ENABLE_LUA
> > +
> > +luadir=$(datadir)/lua/5.1
> > +sodir=$(libdir)/lua/5.1/lxc
>
> maybe use something like:
>
>
On Tue, 29 Jan 2013 09:46:29 +0100
Natanael Copa wrote:
>
> I think that we should use 'pkg-config --exists' instead of testing for given
> distros.
>
> Something like:
> if pkg-config --exists lua5.1; then
> LUAPKGCONFIG=lua5.1
> else
> LUAPKGCONFIG=lua
> fi
>
> In case there might be
Thanks you very much for working on those bindings!
I think the code is good enough for inclusion in git, even if I have
some comments.
On Thu, 24 Jan 2013 11:42:22 -0500
Dwight Engen wrote:
> +# Lua module and scripts
> +if test x"$with_distro" = "xdebian" -o x"$with_distro" = "xubuntu" ; the
On 01/24/2013 11:42 AM, Dwight Engen wrote:
> The lua binding is based closely on the python binding. Also included are
> a test program for excercising the binding, and an lxc-top utility for
> showing statistics on running containers.
>
> Signed-off-by: Dwight Engen
Test build passed and the c
