Re: [lxc-devel] [PATCH RFC] Enable use of user namespaces in containers

2012-12-07 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > > + if (idmaplist) > > + free(idmaplist); > > + > > + if (idmap) { > > + free(idmap); > > + } > > ^ code style isn't really consistent here :) :) fixed in my git branch ---

Re: [lxc-devel] [PATCH RFC] Enable use of user namespaces in containers

2012-12-06 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): ... > I'm also wondering, what's the state of lxc-attach wrt user namespaces? > does it need any updating too? I need to check that still - I'm not sure. > > @@ -1221,7 +1221,7 @@ static int setup_kmsg(const struct lxc_rootfs *rootfs, > > return

Re: [lxc-devel] [PATCH RFC] Enable use of user namespaces in containers

2012-12-06 Thread Stéphane Graber
On 12/06/2012 10:02 AM, Serge Hallyn wrote: > The rootfs will need to be chowned to the mapped userids, which can > be done with the /usr/bin/uidmapshift tool shipped with the nsexec > package in ppa:serge-hallyn/userns-natty. > The container config supports new entries of the form: > lxc.id_map =

[lxc-devel] [PATCH RFC] Enable use of user namespaces in containers

2012-12-06 Thread Serge Hallyn
The rootfs will need to be chowned to the mapped userids, which can be done with the /usr/bin/uidmapshift tool shipped with the nsexec package in ppa:serge-hallyn/userns-natty. The container config supports new entries of the form: lxc.id_map = U 10 0 1 lxc.id_map = G 10 0 1 meani