Re: [lxc-devel] [PATCH 2/2] lxc_attach: Clean up cgroup attaching code

2013-03-04 Thread Christian Seiler
Hi Serge, > (Note - no signed-off-by in this patch. How are you generating them? > I'd recommend either using git-send-email, or get format-patch...) Oh, I didn't know git format-patch had a --signoff option, I always added the line manually when committing and this time I just forgot it. ;-) >

Re: [lxc-devel] [PATCH 2/2] lxc_attach: Clean up cgroup attaching code

2013-03-04 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Since lxc_attach now works with two fork()s anyway due to user > namespaces, the code for attaching to cgroups can be simplified again. > > This patch removes the prepare/finish/dispose functions for attaching > to cgroups and just keeps the lxc_cgr

[lxc-devel] [PATCH 2/2] lxc_attach: Clean up cgroup attaching code

2013-03-03 Thread Christian Seiler
Since lxc_attach now works with two fork()s anyway due to user namespaces, the code for attaching to cgroups can be simplified again. This patch removes the prepare/finish/dispose functions for attaching to cgroups and just keeps the lxc_cgroup_attach function. --- src/lxc/cgroup.c | 154 ++-