Re: [lxc-devel] [PATCH 2/2] fix some larger memory leaks in cgroup code

2013-09-25 Thread S . Çağlar Onur
On Wed, Sep 25, 2013 at 4:56 PM, Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): > > Okay, it looks like you didn't merge any of the first one ("cleanup > > fds, memory in lxc_cgroup_load_meta2()") so I'll look at rebasing that > > on git head, re-valgrind, and resubmit. Than

Re: [lxc-devel] [PATCH 2/2] fix some larger memory leaks in cgroup code

2013-09-25 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > Okay, it looks like you didn't merge any of the first one ("cleanup > fds, memory in lxc_cgroup_load_meta2()") so I'll look at rebasing that > on git head, re-valgrind, and resubmit. Thanks. Thanks! -serge

Re: [lxc-devel] [PATCH 2/2] fix some larger memory leaks in cgroup code

2013-09-25 Thread Dwight Engen
On Wed, 25 Sep 2013 15:08:37 -0500 Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): > > On Wed, 25 Sep 2013 14:44:07 -0400 > > S.Çağlar Onur wrote: > > > > > Uhh something is wrong with this commit > > > > Hey Serge, I think this has to do with the rebase after the split >

Re: [lxc-devel] [PATCH 2/2] fix some larger memory leaks in cgroup code

2013-09-25 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > On Wed, 25 Sep 2013 14:44:07 -0400 > S.Çağlar Onur wrote: > > > Uhh something is wrong with this commit > > Hey Serge, I think this has to do with the rebase after the split up as > it certinaly wasn't seg faulting on me originally. The split als

Re: [lxc-devel] [PATCH 2/2] fix some larger memory leaks in cgroup code

2013-09-25 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): > Uhh something is wrong with this commit > (178938fe0ac891092205d76f67af855dcf7397af), both go bindings and some lxc > tools started to seg fault > sudo lxc-ps > Segmentation fault (core dumped) > Segmentation fault (core dumped) > Segmentation fault (core

Re: [lxc-devel] [PATCH 2/2] fix some larger memory leaks in cgroup code

2013-09-25 Thread Dwight Engen
On Wed, 25 Sep 2013 14:44:07 -0400 S.Çağlar Onur wrote: > Uhh something is wrong with this commit Hey Serge, I think this has to do with the rebase after the split up as it certinaly wasn't seg faulting on me originally. The split also appears to have introduced a couple new leaks (ie. line in t

Re: [lxc-devel] [PATCH 2/2] fix some larger memory leaks in cgroup code

2013-09-25 Thread S . Çağlar Onur
Uhh something is wrong with this commit (178938fe0ac891092205d76f67af855dcf7397af), both go bindings and some lxc tools started to seg fault sudo lxc-ps Segmentation fault (core dumped) Segmentation fault (core dumped) Segmentation fault (core dumped) Segmentation fault (core dumped) Segmentation f

[lxc-devel] [PATCH 2/2] fix some larger memory leaks in cgroup code

2013-09-24 Thread Serge Hallyn
From: Dwight Engen Don't worry about saved_errno since none of the *_free routines will set it Signed-off-by: Dwight Engen Signed-off-by: Serge Hallyn --- src/lxc/cgroup.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/lxc/cgroup.c b/src/lxc/cgroup