Re: [lxc-devel] [PATCH 11/17] Use srand/rand instead of initstate/random

2013-08-19 Thread Stéphane Graber
On Fri, Aug 16, 2013 at 05:25:34PM +0100, Daniel P. Berrange wrote: > On Fri, Aug 16, 2013 at 06:01:25PM +0200, Stéphane Graber wrote: > > On Fri, Aug 16, 2013 at 10:36:58AM -0500, Serge Hallyn wrote: > > > Quoting Stéphane Graber (stgra...@ubuntu.com): > > > > initstate/random doesn't work on bion

Re: [lxc-devel] [PATCH 11/17] Use srand/rand instead of initstate/random

2013-08-16 Thread Daniel P. Berrange
On Fri, Aug 16, 2013 at 06:01:25PM +0200, Stéphane Graber wrote: > On Fri, Aug 16, 2013 at 10:36:58AM -0500, Serge Hallyn wrote: > > Quoting Stéphane Graber (stgra...@ubuntu.com): > > > initstate/random doesn't work on bionic, srand/rand works on everything, > > > so let's use that. > > > > Is ran

Re: [lxc-devel] [PATCH 11/17] Use srand/rand instead of initstate/random

2013-08-16 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > On Fri, Aug 16, 2013 at 10:36:58AM -0500, Serge Hallyn wrote: > > Quoting Stéphane Graber (stgra...@ubuntu.com): > > > initstate/random doesn't work on bionic, srand/rand works on everything, > > > so let's use that. > > > > Is rand_r available on b

Re: [lxc-devel] [PATCH 11/17] Use srand/rand instead of initstate/random

2013-08-16 Thread Stéphane Graber
On Fri, Aug 16, 2013 at 10:36:58AM -0500, Serge Hallyn wrote: > Quoting Stéphane Graber (stgra...@ubuntu.com): > > initstate/random doesn't work on bionic, srand/rand works on everything, > > so let's use that. > > Is rand_r available on bionic? > > rand() isn't thread-safe. Unfortunately no, I

Re: [lxc-devel] [PATCH 11/17] Use srand/rand instead of initstate/random

2013-08-16 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > initstate/random doesn't work on bionic, srand/rand works on everything, > so let's use that. Is rand_r available on bionic? rand() isn't thread-safe. > Signed-off-by: Stéphane Graber > --- > src/lxc/conf.c | 5 ++--- > 1 file changed, 2 inserti

[lxc-devel] [PATCH 11/17] Use srand/rand instead of initstate/random

2013-08-16 Thread Stéphane Graber
initstate/random doesn't work on bionic, srand/rand works on everything, so let's use that. Signed-off-by: Stéphane Graber --- src/lxc/conf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/lxc/conf.c b/src/lxc/conf.c index 867a150..3d99469 100644 --- a/src/lxc/conf.