Re: [lxc-devel] [PATCH 1/4] coverity: don't reference beyond structure

2013-05-14 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > On Fri, 3 May 2013 13:47:59 -0400 > Dwight Engen wrote: > > > On Fri, 3 May 2013 12:23:29 -0500 > > Serge Hallyn wrote: > > > > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > > On Fri, 3 May 2013 11:17:08 -0500 > > > > Serge Hallyn wro

Re: [lxc-devel] [PATCH 1/4] coverity: don't reference beyond structure

2013-05-14 Thread Dwight Engen
On Fri, 3 May 2013 13:47:59 -0400 Dwight Engen wrote: > On Fri, 3 May 2013 12:23:29 -0500 > Serge Hallyn wrote: > > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > On Fri, 3 May 2013 11:17:08 -0500 > > > Serge Hallyn wrote: > > > > > > > can that be correct? That changes the value of

Re: [lxc-devel] [PATCH 1/4] coverity: don't reference beyond structure

2013-05-03 Thread Dwight Engen
On Fri, 3 May 2013 12:23:29 -0500 Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): > > On Fri, 3 May 2013 11:17:08 -0500 > > Serge Hallyn wrote: > > > > > can that be correct? That changes the value of the > > > pointer. NLMSG_DATA adds aligned sizeof(struct nlmsghdr). >

Re: [lxc-devel] [PATCH 1/4] coverity: don't reference beyond structure

2013-05-03 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > On Fri, 3 May 2013 11:17:08 -0500 > Serge Hallyn wrote: > > > can that be correct? That changes the value of the > > pointer. NLMSG_DATA adds aligned sizeof(struct nlmsghdr). > > The current code is relying on the fact that our genlmsg looks li

Re: [lxc-devel] [PATCH 1/4] coverity: don't reference beyond structure

2013-05-03 Thread Dwight Engen
On Fri, 3 May 2013 11:17:08 -0500 Serge Hallyn wrote: > can that be correct? That changes the value of the > pointer. NLMSG_DATA adds aligned sizeof(struct nlmsghdr). The current code is relying on the fact that our genlmsg looks like this: struct genlmsg { struct nlmsghdr nlmsghdr;

Re: [lxc-devel] [PATCH 1/4] coverity: don't reference beyond structure

2013-05-03 Thread Serge Hallyn
can that be correct? That changes the value of the pointer. NLMSG_DATA adds aligned sizeof(struct nlmsghdr). I suspect lxc is doing the right thing in practice, but could do some sort of casting somewhere to tell coverity to lighten up. But I haven't yet figured out what that is. Quoting Dwigh

[lxc-devel] [PATCH 1/4] coverity: don't reference beyond structure

2013-05-03 Thread Dwight Engen
Signed-off-by: Dwight Engen --- src/lxc/genl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lxc/genl.c b/src/lxc/genl.c index 873b084..8fcb6b7 100644 --- a/src/lxc/genl.c +++ b/src/lxc/genl.c @@ -55,7 +55,7 @@ static int genetlink_resolve_family(const char *family)