Hello Serge,
> Ok, I've got no objection to this, but if I decide to do this before
> resending the patch I won't get around to it for quite some time. I'll
> push a github tree with a simpler consolidated patch, and if you have
> time to implement the above in a branch based on what I push, plea
Quoting Christian Seiler (christ...@iwakd.de):
> Hi there,
>
> > So my suggestion is basically to:
> > - Kill lxc-shutdown
> > - Change lxc-stop so that:
> >* Default behaviour is to call shutdown(), wait 15s for STOPPED, if
> > not STOPPED, print a message to the user and call stop()
> >
+1 from me also, I like it simplified for lxc-stop to just "do the right
thing".
On Fri, 17 May 2013 21:02:22 +
Brent Tubbs wrote:
> +1 to Christian's suggestions. I run LXC containers under Supervisor,
> which provides per-program config options for 'stopsignal' and
> 'stopwaitsecs' that w
+1 to Christian's suggestions. I run LXC containers under Supervisor,
which provides per-program config options for 'stopsignal' and
'stopwaitsecs' that would map really well to what he's proposed.
On 5/17/13 1:55 PM, "Christian Seiler" wrote:
>Hi there,
>
>> So my suggestion is basically to:
>
Hi there,
> So my suggestion is basically to:
> - Kill lxc-shutdown
> - Change lxc-stop so that:
>* Default behaviour is to call shutdown(), wait 15s for STOPPED, if
> not STOPPED, print a message to the user and call stop()
>* We have a -r option to reboot the container (with proper che
Quoting Stéphane Graber (stgra...@ubuntu.com):
> On 05/17/2013 03:15 PM, Serge Hallyn wrote:
> > implement c->reboot(c) in the api. Remove lxc-shutdown.in, the
> > bash script. Replace it with lxc_shutdown.c which uses the
> > API.
>
>
> Thanks for those changes. As we briefly discussed on IRC,
On 05/17/2013 03:15 PM, Serge Hallyn wrote:
> implement c->reboot(c) in the api. Remove lxc-shutdown.in, the
> bash script. Replace it with lxc_shutdown.c which uses the
> API.
Thanks for those changes. As we briefly discussed on IRC, I think we
should rework a bit the set of binaries we have t
implement c->reboot(c) in the api. Remove lxc-shutdown.in, the
bash script. Replace it with lxc_shutdown.c which uses the
API.
Signed-off-by: Serge Hallyn
---
configure.ac| 1 -
src/lxc/Makefile.am | 3 +-
src/lxc/arguments.h | 4 +-
src/lxc/lxc-shutdown.in | 165