Re: [lxc-devel] [PATCH 1/1] lxc_create: prepend pretty header to config file

2013-07-12 Thread Daniel P. Berrange
On Fri, Jul 12, 2013 at 11:00:09AM -0500, Serge Hallyn wrote: > Quoting Daniel P. Berrange (berra...@redhat.com): > > Copy+pasting code for encryption algorithms is really not nice. > > It means that instead of distributors of your package being able > > to rely on the fact 'gnutls' is (eg) FIPS ce

Re: [lxc-devel] [PATCH 1/1] lxc_create: prepend pretty header to config file

2013-07-12 Thread Stéphane Graber
On Fri, Jul 12, 2013 at 04:49:33PM +0100, Daniel P. Berrange wrote: > On Fri, Jul 12, 2013 at 10:27:14AM -0500, Serge Hallyn wrote: > > Quoting Stéphane Graber (stgra...@ubuntu.com): > > > On Thu, Jul 11, 2013 at 11:51:25PM -0500, Serge Hallyn wrote: > > > > Define a sha1sum_file() function in util

Re: [lxc-devel] [PATCH 1/1] lxc_create: prepend pretty header to config file

2013-07-12 Thread Serge Hallyn
Quoting Daniel P. Berrange (berra...@redhat.com): > Copy+pasting code for encryption algorithms is really not nice. > It means that instead of distributors of your package being able > to rely on the fact 'gnutls' is (eg) FIPS certified, they now have > to explicitly certify the copy of the code in

Re: [lxc-devel] [PATCH 1/1] lxc_create: prepend pretty header to config file

2013-07-12 Thread Daniel P. Berrange
On Fri, Jul 12, 2013 at 10:27:14AM -0500, Serge Hallyn wrote: > Quoting Stéphane Graber (stgra...@ubuntu.com): > > On Thu, Jul 11, 2013 at 11:51:25PM -0500, Serge Hallyn wrote: > > > Define a sha1sum_file() function in utils.c (which requires configure.ac > > > to check for -lcrypto and -lssl). Us

Re: [lxc-devel] [PATCH 1/1] lxc_create: prepend pretty header to config file

2013-07-12 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > On Thu, Jul 11, 2013 at 11:51:25PM -0500, Serge Hallyn wrote: > > Define a sha1sum_file() function in utils.c (which requires configure.ac > > to check for -lcrypto and -lssl). Use that in lxcapi_create to write out > > the sha1sum of the template b

Re: [lxc-devel] [PATCH 1/1] lxc_create: prepend pretty header to config file

2013-07-12 Thread Stéphane Graber
On Thu, Jul 11, 2013 at 11:51:25PM -0500, Serge Hallyn wrote: > Define a sha1sum_file() function in utils.c (which requires configure.ac > to check for -lcrypto and -lssl). Use that in lxcapi_create to write out > the sha1sum of the template being used. > > Signed-off-by: Serge Hallyn > --- > c

[lxc-devel] [PATCH 1/1] lxc_create: prepend pretty header to config file

2013-07-11 Thread Serge Hallyn
Define a sha1sum_file() function in utils.c (which requires configure.ac to check for -lcrypto and -lssl). Use that in lxcapi_create to write out the sha1sum of the template being used. Signed-off-by: Serge Hallyn --- configure.ac |2 + src/lxc/Makefile.am|2 +- src/lxc/lx