Re: [lxc-devel] [PATCH 1/1] lxc-create: add zfs support

2013-05-04 Thread Tamas Papp
On 04/23/2013 09:59 PM, Stéphane Graber wrote: > On 04/23/2013 01:28 AM, Serge Hallyn wrote: >> Quoting Stéphane Graber (stgra...@ubuntu.com): >>> I'm not a big user of lxc-clone (yet) but I think as we redesign that >>> part of the code, consistency across backend should be a primary goal >>> even

Re: [lxc-devel] [PATCH 1/1] lxc-create: add zfs support

2013-05-04 Thread Tamas Papp
On 04/21/2013 03:37 PM, Serge Hallyn wrote: > > Quoting Serge Hallyn (serge.hal...@ubuntu.com): >> Any feedback on this patch? >> >> I also have a question on behavior details. Until now, we've set up >> btrfs containers so that $lxcpath is a subvolume, and then each >> $rootfs is a subvolume. W

Re: [lxc-devel] [PATCH 1/1] lxc-create: add zfs support

2013-05-04 Thread Tamas Papp
On 04/23/2013 10:51 PM, Stéphane Graber wrote: > If we don't set the block device as lxc.rootfs, then the host has to > mount the LVM outside of the container's mount namespace, which we > prefer not to have to do, especially as you get into a chicken and egg > problem where the LVM path is set in

Re: [lxc-devel] [PATCH 1/1] lxc-create: add zfs support

2013-04-23 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > On 04/23/2013 10:41 PM, Tamas Papp wrote: > > On 04/23/2013 09:59 PM, Stéphane Graber wrote: > >> On 04/23/2013 01:28 AM, Serge Hallyn wrote: > >>> Quoting Stéphane Graber (stgra...@ubuntu.com): > I'm not a big user of lxc-clone (yet) but I thin

Re: [lxc-devel] [PATCH 1/1] lxc-create: add zfs support

2013-04-23 Thread Stéphane Graber
On 04/23/2013 10:41 PM, Tamas Papp wrote: > On 04/23/2013 09:59 PM, Stéphane Graber wrote: >> On 04/23/2013 01:28 AM, Serge Hallyn wrote: >>> Quoting Stéphane Graber (stgra...@ubuntu.com): I'm not a big user of lxc-clone (yet) but I think as we redesign that part of the code, consistency

Re: [lxc-devel] [PATCH 1/1] lxc-create: add zfs support

2013-04-23 Thread Stéphane Graber
On 04/23/2013 01:28 AM, Serge Hallyn wrote: > Quoting Stéphane Graber (stgra...@ubuntu.com): >> I'm not a big user of lxc-clone (yet) but I think as we redesign that >> part of the code, consistency across backend should be a primary goal >> even if that causes some slight changes in behaviour from

Re: [lxc-devel] [PATCH 1/1] lxc-create: add zfs support

2013-04-22 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > I'm not a big user of lxc-clone (yet) but I think as we redesign that > part of the code, consistency across backend should be a primary goal > even if that causes some slight changes in behaviour from previous > implementations. Ok it finally dawne

Re: [lxc-devel] [PATCH 1/1] lxc-create: add zfs support

2013-04-21 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > On 04/21/2013 03:37 PM, Serge Hallyn wrote: > > Quoting Serge Hallyn (serge.hal...@ubuntu.com): > >> Any feedback on this patch? > >> > >> I also have a question on behavior details. Until now, we've set up > >> btrfs containers so that $lxcpath is

Re: [lxc-devel] [PATCH 1/1] lxc-create: add zfs support

2013-04-21 Thread Stéphane Graber
On 04/21/2013 03:37 PM, Serge Hallyn wrote: > Quoting Serge Hallyn (serge.hal...@ubuntu.com): >> Any feedback on this patch? >> >> I also have a question on behavior details. Until now, we've set up >> btrfs containers so that $lxcpath is a subvolume, and then each >> $rootfs is a subvolume. Wit

Re: [lxc-devel] [PATCH 1/1] lxc-create: add zfs support

2013-04-21 Thread Serge Hallyn
Quoting Serge Hallyn (serge.hal...@ubuntu.com): > Any feedback on this patch? > > I also have a question on behavior details. Until now, we've set up > btrfs containers so that $lxcpath is a subvolume, and then each > $rootfs is a subvolume. With zfs, per Papp's request, we're making > the (zfs

Re: [lxc-devel] [PATCH 1/1] lxc-create: add zfs support

2013-04-20 Thread Serge Hallyn
Any feedback on this patch? I also have a question on behavior details. Until now, we've set up btrfs containers so that $lxcpath is a subvolume, and then each $rootfs is a subvolume. With zfs, per Papp's request, we're making the (zfs equivalent of a subvolume) at the $lxcpath/$lxc_name. So t

[lxc-devel] [PATCH 1/1] lxc-create: add zfs support

2013-04-11 Thread Serge Hallyn
This is based on patch from Papp Tamas (thanks). It also does some reorganizing of lxc-create to commonize some of the backingstore handling. I didn't test on btrfs or zfs, but did test that '-B btrfs' and '-B zfs' properly fail when needed, and that lvm and dir and _unset still work as they shou