On 01/24/2013 01:04 PM, Serge Hallyn wrote:
> Until now, if a lxc-* (i.e. lxc-start) command did not specify a logfile
> (with -o logfile), the default was effectively 'none'. With this patch,
> the default becomes a per-container log file.
>
> If a container config file specifies 'lxc.logfile',
Until now, if a lxc-* (i.e. lxc-start) command did not specify a logfile
(with -o logfile), the default was effectively 'none'. With this patch,
the default becomes a per-container log file.
If a container config file specifies 'lxc.logfile', that will override
the default. If a '-o logfile' arg
Quoting Stéphane Graber (stgra...@ubuntu.com):
> Just a note that the two commits for this change caused a regression
> breaking at least lxc-info.
>
> I have reverted both commits from the staging branch for now and will
> re-review a newer version of the patch when Serge has some time to work
>
Just a note that the two commits for this change caused a regression
breaking at least lxc-info.
I have reverted both commits from the staging branch for now and will
re-review a newer version of the patch when Serge has some time to work
on it.
--
Stéphane Graber
Ubuntu developer
http://www.ubu
On 01/16/2013 05:37 PM, Serge Hallyn wrote:
> Quoting Stéphane Graber (stgra...@ubuntu.com):
> ...
>> We probably should have code to actually create the path if it's
>> missing, similar to what's done for /var/lib/lxc and /var/cache/lxc.
>
> How about the following patch on top of the original?
>
On 01/16/2013 12:02 AM, Serge Hallyn wrote:
> [ Thanks to Stéphane and Dwight for the feedback on the previous patch ]
>
> Until now, if a lxc-* (i.e. lxc-start) command did not specify a logfile
> (with -o logfile), the default was effectively 'none'. With this patch,
> the default becomes $LOGP
Quoting Stéphane Graber (stgra...@ubuntu.com):
...
> We probably should have code to actually create the path if it's
> missing, similar to what's done for /var/lib/lxc and /var/cache/lxc.
How about the following patch on top of the original?
log_open: make sure the parent directory for logfiles
On 01/16/2013 12:02 AM, Serge Hallyn wrote:
> [ Thanks to Stéphane and Dwight for the feedback on the previous patch ]
>
> Until now, if a lxc-* (i.e. lxc-start) command did not specify a logfile
> (with -o logfile), the default was effectively 'none'. With this patch,
> the default becomes $LOGP
[ Thanks to Stéphane and Dwight for the feedback on the previous patch ]
Until now, if a lxc-* (i.e. lxc-start) command did not specify a logfile
(with -o logfile), the default was effectively 'none'. With this patch,
the default becomes $LOGPATH//.log. LOGPATH is
specified at configure time wit
