Re: [lxc-devel] [PATCH] tests/startone: wrong set_cgroup_item check

2013-07-03 Thread Serge Hallyn
Quoting Serge Hallyn (serge.hal...@ubuntu.com): > Quoting Purcareata Bogdan-B43198 (b43...@freescale.com): > > So lxcapi_set_cgroup_item() shouldn't return ret instead of (ret == 0)? > > No. Then it would return "(bool)0 -> false", whereas currently it > returns "(ret == 0) -> true" > > -serge

Re: [lxc-devel] [PATCH] tests/startone: wrong set_cgroup_item check

2013-07-03 Thread Serge Hallyn
Quoting Purcareata Bogdan-B43198 (b43...@freescale.com): > So lxcapi_set_cgroup_item() shouldn't return ret instead of (ret == 0)? No. Then it would return "(bool)0 -> false", whereas currently it returns "(ret == 0) -> true" -serge --

Re: [lxc-devel] [PATCH] tests/startone: wrong set_cgroup_item check

2013-07-03 Thread Purcareata Bogdan-B43198
> -Original Message- > From: Serge Hallyn [mailto:serge.hal...@ubuntu.com] > Sent: Wednesday, July 03, 2013 3:46 PM > To: Purcareata Bogdan-B43198 > Cc: lxc-devel@lists.sourceforge.net > Subject: Re: [lxc-devel] [PATCH] tests/startone: wrong set_cgroup_item check >

Re: [lxc-devel] [PATCH] tests/startone: wrong set_cgroup_item check

2013-07-03 Thread Serge Hallyn
> Subject: Re: [lxc-devel] [PATCH] tests/startone: wrong set_cgroup_item check > > > > Quoting Bogdan Purcareata (bogdan.purcare...@freescale.com): > > > Minor typo. > > > > > > Signed-off-by: Bogdan Purcareata > > > --- > > > src/tests/start

Re: [lxc-devel] [PATCH] tests/startone: wrong set_cgroup_item check

2013-07-03 Thread Purcareata Bogdan-B43198
> -Original Message- > From: Serge Hallyn [mailto:serge.hal...@ubuntu.com] > Sent: Tuesday, July 02, 2013 5:27 PM > To: Purcareata Bogdan-B43198 > Cc: lxc-devel@lists.sourceforge.net > Subject: Re: [lxc-devel] [PATCH] tests/startone: wrong set_cgroup_item check &

Re: [lxc-devel] [PATCH] tests/startone: wrong set_cgroup_item check

2013-07-02 Thread Serge Hallyn
Quoting Bogdan Purcareata (bogdan.purcare...@freescale.com): > Minor typo. > > Signed-off-by: Bogdan Purcareata > --- > src/tests/startone.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/tests/startone.c b/src/tests/startone.c > index d781e75..2c1f39b 100644 >

[lxc-devel] [PATCH] tests/startone: wrong set_cgroup_item check

2013-07-02 Thread Bogdan Purcareata
Minor typo. Signed-off-by: Bogdan Purcareata --- src/tests/startone.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tests/startone.c b/src/tests/startone.c index d781e75..2c1f39b 100644 --- a/src/tests/startone.c +++ b/src/tests/startone.c @@ -201,7 +201,7 @@ int mai