Re: [lxc-devel] [PATCH] replace redundant creat() with open()

2013-11-12 Thread S . Çağlar Onur
On Nov 8, 2013 5:20 PM, "Serge Hallyn" wrote: > > Quoting S.Çağlar Onur (cag...@10ur.org): > > Hey Serge, > > > > On Fri, Nov 8, 2013 at 4:06 PM, Serge Hallyn wrote: > > > Quoting S.Çağlar Onur (cag...@10ur.org): > > >> creat() is equivalent to open() with flags equal to O_CREAT|O_WRONLY|O_TRUNC

Re: [lxc-devel] [PATCH] replace redundant creat() with open()

2013-11-08 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): > Hey Serge, > > On Fri, Nov 8, 2013 at 4:06 PM, Serge Hallyn wrote: > > Quoting S.Çağlar Onur (cag...@10ur.org): > >> creat() is equivalent to open() with flags equal to > >> O_CREAT|O_WRONLY|O_TRUNC > > > > Hi, > > > > I'm confused - what is redundant i

Re: [lxc-devel] [PATCH] replace redundant creat() with open()

2013-11-08 Thread S . Çağlar Onur
Hey Serge, On Fri, Nov 8, 2013 at 4:06 PM, Serge Hallyn wrote: > Quoting S.Çağlar Onur (cag...@10ur.org): >> creat() is equivalent to open() with flags equal to O_CREAT|O_WRONLY|O_TRUNC > > Hi, > > I'm confused - what is redundant in the use of creat()? If there is an > improvement here then I d

Re: [lxc-devel] [PATCH] replace redundant creat() with open()

2013-11-08 Thread Serge Hallyn
Quoting S.Çağlar Onur (cag...@10ur.org): > creat() is equivalent to open() with flags equal to O_CREAT|O_WRONLY|O_TRUNC Hi, I'm confused - what is redundant in the use of creat()? If there is an improvement here then I don't understand what it is. Otherwise I'd argue creat() is more concise and

[lxc-devel] [PATCH] replace redundant creat() with open()

2013-11-08 Thread S . Çağlar Onur
creat() is equivalent to open() with flags equal to O_CREAT|O_WRONLY|O_TRUNC Signed-off-by: S.Çağlar Onur --- src/lxc/bdev.c | 2 +- src/lxc/conf.c | 6 +++--- src/lxc/lxc_start.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/lxc/bdev.c b/src/lxc/bdev.c ind