Re: [lxc-devel] [PATCH] lxc-shutdown: use posix shell instead of bash

2013-01-04 Thread Natanael Copa
On Wed, 02 Jan 2013 13:49:51 -0500 Stéphane Graber wrote: > Turns out that not all kill implementations allow "-s SIG", some > instead required "-s ". As far as I can tell, all > implementations support the latter, so I pushed a change to use that > instead. Sorry about that. lxc-shutdown does

Re: [lxc-devel] [PATCH] lxc-shutdown: use posix shell instead of bash

2013-01-02 Thread Stéphane Graber
On 01/02/2013 12:57 PM, Stéphane Graber wrote: > On 12/27/2012 03:52 AM, Natanael Copa wrote: >> - avoid getopt --longoptions >> - use 'which' instead of 'type' to detect existance of tools >> - specify -s SIG with kill >> >> Signed-off-by: Natanael Copa > > Looks good. Pushed. Turns out that no

Re: [lxc-devel] [PATCH] lxc-shutdown: use posix shell instead of bash

2013-01-02 Thread Stéphane Graber
On 12/27/2012 03:52 AM, Natanael Copa wrote: > - avoid getopt --longoptions > - use 'which' instead of 'type' to detect existance of tools > - specify -s SIG with kill > > Signed-off-by: Natanael Copa Looks good. Pushed. Acked-by: Stéphane Graber > --- > dash didn't complain when I tested it,

[lxc-devel] [PATCH] lxc-shutdown: use posix shell instead of bash

2012-12-27 Thread Natanael Copa
- avoid getopt --longoptions - use 'which' instead of 'type' to detect existance of tools - specify -s SIG with kill Signed-off-by: Natanael Copa --- dash didn't complain when I tested it, but it did not shut down the container due to busybox init uses other signals for poweroff/reboot. The powe