Re: [lxc-devel] [PATCH] fix segfault on lxc-create with bad template name

2013-09-26 Thread Serge Hallyn
Quoting Serge Hallyn (serge.hal...@ubuntu.com): > Quoting Dwight Engen (dwight.en...@oracle.com): > > - change get_template_path() to only return NULL or non-NULL since one of > > the callers was doing a free(-1) which caused the segfault. Handle the > > NULL template case in the lxcapi_create(

Re: [lxc-devel] [PATCH] fix segfault on lxc-create with bad template name

2013-09-25 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > - change get_template_path() to only return NULL or non-NULL since one of > the callers was doing a free(-1) which caused the segfault. Handle the > NULL template case in the lxcapi_create() caller. Hm, some people really do want to run lxc-cre

[lxc-devel] [PATCH] fix segfault on lxc-create with bad template name

2013-09-25 Thread Dwight Engen
- change get_template_path() to only return NULL or non-NULL since one of the callers was doing a free(-1) which caused the segfault. Handle the NULL template case in the lxcapi_create() caller. - make sure to free(tpath) in the sha1sum_file() failure case Signed-off-by: Dwight Engen --- sr