Re: [lxc-devel] [PATCH] fix getline(3) memory leaks

2013-05-22 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Hi there, > > > Yeah I've tested before (because I used to want to think glibc would > > check for that) and it definately segvs. I'll push this patch with > > that added. > > I'm a bit confused, this goes against everything I know about C memory

Re: [lxc-devel] [PATCH] fix getline(3) memory leaks

2013-05-22 Thread Christian Seiler
Hi there, > Yeah I've tested before (because I used to want to think glibc would > check for that) and it definately segvs. I'll push this patch with > that added. I'm a bit confused, this goes against everything I know about C memory management: ANSI C (ANSI X3J11/88-090, May 13, 1988) [1], Se

Re: [lxc-devel] [PATCH] fix getline(3) memory leaks

2013-05-21 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > On Tue, 21 May 2013 17:07:54 -0500 > Serge Hallyn wrote: > > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > Signed-off-by: Dwight Engen > > > --- > > > src/lxc/attach.c | 2 +- > > > src/lxc/cgroup.c | 1 + > > > 2 files changed, 2 inse

Re: [lxc-devel] [PATCH] fix getline(3) memory leaks

2013-05-21 Thread Dwight Engen
On Tue, 21 May 2013 17:07:54 -0500 Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): > > Signed-off-by: Dwight Engen > > --- > > src/lxc/attach.c | 2 +- > > src/lxc/cgroup.c | 1 + > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/src/lxc/attach.c b/

Re: [lxc-devel] [PATCH] fix getline(3) memory leaks

2013-05-21 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > Signed-off-by: Dwight Engen > --- > src/lxc/attach.c | 2 +- > src/lxc/cgroup.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/lxc/attach.c b/src/lxc/attach.c > index a7e9074..d8b4915 100644 > --- a/src/lxc/attach.c

[lxc-devel] [PATCH] fix getline(3) memory leaks

2013-05-21 Thread Dwight Engen
Signed-off-by: Dwight Engen --- src/lxc/attach.c | 2 +- src/lxc/cgroup.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lxc/attach.c b/src/lxc/attach.c index a7e9074..d8b4915 100644 --- a/src/lxc/attach.c +++ b/src/lxc/attach.c @@ -114,6 +114,7 @@ struct lxc_proc_contex