Re: [lxc-devel] [PATCH] don't leak the rootfs.pin fd into the container

2013-03-11 Thread Serge Hallyn
Quoting Ward, David - 0663 - MITLL (david.w...@ll.mit.edu): > On 03/10/2013 11:45 PM, Serge Hallyn wrote: > >Quoting Ward, David - 0663 - MITLL (david.w...@ll.mit.edu): > >>Hi Serge, > >> > >>This patch seems to have introduced a regression. When I use > >>lxc-execute with a very simple container

Re: [lxc-devel] [PATCH] don't leak the rootfs.pin fd into the container

2013-03-11 Thread Ward, David - 0663 - MITLL
On 03/10/2013 11:45 PM, Serge Hallyn wrote: Quoting Ward, David - 0663 - MITLL (david.w...@ll.mit.edu): Hi Serge, This patch seems to have introduced a regression. When I use lxc-execute with a very simple container (which only sets the utsname), the terminal input is not forwarded to the appl

Re: [lxc-devel] [PATCH] don't leak the rootfs.pin fd into the container

2013-03-10 Thread Serge Hallyn
Quoting Ward, David - 0663 - MITLL (david.w...@ll.mit.edu): > Hi Serge, > > This patch seems to have introduced a regression. When I use > lxc-execute with a very simple container (which only sets the > utsname), the terminal input is not forwarded to the application > anymore. In particular, ru

Re: [lxc-devel] [PATCH] don't leak the rootfs.pin fd into the container

2013-03-10 Thread Ward, David - 0663 - MITLL
Hi Serge, This patch seems to have introduced a regression. When I use lxc-execute with a very simple container (which only sets the utsname), the terminal input is not forwarded to the application anymore. In particular, running "lxc-execute -n $CONTAINER -- bash" returns immediately witho

Re: [lxc-devel] [PATCH] don't leak the rootfs.pin fd into the container

2013-01-21 Thread Stéphane Graber
On 01/17/2013 10:53 AM, Serge Hallyn wrote: > Only the container parent needs to keep that fd open. Close it > as soon as the container's first task is spawned. Else it can > show up in /proc/$$/fd in the container. > > Signed-off-by: Serge Hallyn Acked-by: Stéphane Graber > --- > src/lxc/s

[lxc-devel] [PATCH] don't leak the rootfs.pin fd into the container

2013-01-17 Thread Serge Hallyn
Only the container parent needs to keep that fd open. Close it as soon as the container's first task is spawned. Else it can show up in /proc/$$/fd in the container. Signed-off-by: Serge Hallyn --- src/lxc/start.c | 12 +++- src/lxc/start.h | 1 + 2 files changed, 8 insertions(+), 5 d